[GitHub] jerrypeng commented on issue #2884: move downloader registry map to yaml

jerrypeng commented on issue #2884: move downloader registry map to yaml URL: https://github.com/apache/incubator-heron/pull/2884#issuecomment-387153148 I feel the changes have made the downloader a lot more complicated. Now we have to potentially pass in a cluster mode, heron home path,

[GitHub] jerrypeng commented on issue #2884: move downloader registry map to yaml

jerrypeng commented on issue #2884: move downloader registry map to yaml URL: https://github.com/apache/incubator-heron/pull/2884#issuecomment-387153148 I feel the changes have made the downloader a lot more complicated. Now we have to pass in a cluster mode or config path because we have

[GitHub] jerrypeng commented on issue #2884: move downloader registry map to yaml

jerrypeng commented on issue #2884: move downloader registry map to yaml URL: https://github.com/apache/incubator-heron/pull/2884#issuecomment-387153148 I feel the changes have made the downloader a lot more complicated. Now we have to pass in a cluster mode or config path because we have

[GitHub] jerrypeng commented on issue #2884: move downloader registry map to yaml

jerrypeng commented on issue #2884: move downloader registry map to yaml URL: https://github.com/apache/incubator-heron/pull/2884#issuecomment-387148313 So the arguments are changed for the downloader right? Won't this break existing usages of the downloader. Heron standalone/nomad calls