nlu90 commented on issue #2692: Making emit, ack, and fail thread safe URL: https://github.com/apache/incubator-heron/pull/2692#issuecomment-390284998 @bornej It is possible to utilizing multithreads in Heron even without this patch. The only requirement is that you need to ack/fail the processed tuple in the original main thread for correctness. If your topology is AT-MOST-ONCE semantics, then you don't even need to worry about this problem. @srkukarni After reviewing this long converstaion and the changes made, it looks good to me. But I think we need to mention the thread-safe acking to users very carefully, ensures them that EFFECTLY-ONCE might be broken if they don't implement `preSave` carefully.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
