Re: About stream manager's quitting logic on connection failures

PR is here: https://github.com/twitter/heron/pull/2711 It should be quite simple, most changes are in config files. On Mon, Feb 5, 2018 at 1:40 PM, Ning Wang wrote: > Cool. Thanks! > > On Mon, Feb 5, 2018 at 11:01 AM, Karthik Ramasamy > wrote: > >>

Re: About stream manager's quitting logic on connection failures

Cool. Thanks! On Mon, Feb 5, 2018 at 11:01 AM, Karthik Ramasamy wrote: > Ning - let us get this rolled out soon. > > Cheers > /karthik > > > On Feb 5, 2018, at 10:57 AM, Sanjeev Kulkarni > wrote: > > > > This sounds good to me! > > > > On Mon, Feb 5,

Re: About stream manager's quitting logic on connection failures

Ning - let us get this rolled out soon. Cheers /karthik > On Feb 5, 2018, at 10:57 AM, Sanjeev Kulkarni wrote: > > This sounds good to me! > > On Mon, Feb 5, 2018 at 1:08 AM, Ning Wang wrote: > >> Yeah. That is an option too. In fact it was my

Re: About stream manager's quitting logic on connection failures

This sounds good to me! On Mon, Feb 5, 2018 at 1:08 AM, Ning Wang wrote: > Yeah. That is an option too. In fact it was my first try: > https://github.com/twitter/heron/pull/2693 (just an initiative, not > completed, a count map should be used instead of a single total

Re: About stream manager's quitting logic on connection failures

Yeah. That is an option too. In fact it was my first try: https://github.com/twitter/heron/pull/2693 (just an initiative, not completed, a count map should be used instead of a single total count) In most cases, I think both solutions should have the same result. A few reasons I changed to a