Re: Proposing Changes To Heron ECO

2018-03-29 Thread Karthik Ramasamy
Good proposal - uses existing code and adds more capabilities for custom grouping. +1 On Thu, Mar 29, 2018 at 8:16 PM Josh Fischer wrote: > I've recently discovered a bug while trying to create a custom grouping > example with ECO. > > Historically with Flux (which ECO is

Proposing Changes To Heron ECO

2018-03-29 Thread Josh Fischer
I've recently discovered a bug while trying to create a custom grouping example with ECO. Historically with Flux (which ECO is based off of) you would define a custom grouping like below. - name: "bolt-1 --> bolt2" from: "bolt-1" to: "bolt-2" grouping: type: CUSTOM

Re: Proposing Changes To Heron

2018-03-01 Thread Karthik Ramasamy
Good for a first pass. Otherwise, if you have comments, please address them in the document. On Thu, Mar 1, 2018 at 7:53 AM, Josh Fischer wrote: > There are still a few comments and thoughts outstanding. Is this proposal > good to go for a first pass to implement? > >

Re: Proposing Changes To Heron

2018-03-01 Thread Josh Fischer
There are still a few comments and thoughts outstanding. Is this proposal good to go for a first pass to implement? Anyone should be able to comment with this link. https://docs.google.com/document/d/1PxLCyR_H-mOgPjyFj3DhWXryKW21CH2zFWwzTnqjfEA/edit?usp=sharing On Mon, Feb 26, 2018 at 10:07 PM

Re: Proposing Changes To Heron

2018-02-26 Thread Yaliang Wang
Josh, Totally agree with your concern. I was bringing that idea into conversation and thought that as a back up solution. Since Heron is getting more and more popular, it would be really nice to have SQL support. I think having a built-in Heron SQL can shorten the development iteration since

Re: Proposing Changes To Heron

2018-02-26 Thread Karthik Ramasamy
Thanks Josh for initiating this. It will be a great feature to add for Heron. cheers /karthik > On Feb 26, 2018, at 11:11 AM, Josh Fischer wrote: > > Jerry, > > Great point. Lets keep things simple for the migration to make sure the > implementation is correct. Then we

Re: Proposing Changes To Heron

2018-02-26 Thread Josh Fischer
Jerry, Great point. Lets keep things simple for the migration to make sure the implementation is correct. Then we can modify from there. On Sun, Feb 25, 2018 at 11:28 PM, Jerry Peng wrote: > Thanks Josh for taking the initiative to get this start! SQL on Heron >

Re: Proposing Changes To Heron

2018-02-26 Thread Ning Wang
+1 for Heron SQL On Sun, Feb 25, 2018 at 9:28 PM, Jerry Peng wrote: > Thanks Josh for taking the initiative to get this start! SQL on Heron > will be a great feature! The plan sounds great to me. Lets first get > an initial version of the Heron SQL out and then we

Re: Proposing Changes To Heron

2018-02-25 Thread Jerry Peng
Thanks Josh for taking the initiative to get this start! SQL on Heron will be a great feature! The plan sounds great to me. Lets first get an initial version of the Heron SQL out and then we can worry about custom / user defined sources and sinks. We can even start talking about UDFs (User

Re: Proposing Changes To Heron

2018-02-25 Thread Fu Maosong
+1 to SQL on Heron! 2018-02-25 21:05 GMT-08:00 Josh Fischer : > Please see this google drive link for adding comments. I will copy and > paste the drive doc below as well. > > https://docs.google.com/document/d/1PxLCyR_H- >

Proposing Changes To Heron

2018-02-25 Thread Josh Fischer
Please see this google drive link for adding comments. I will copy and paste the drive doc below as well. https://docs.google.com/document/d/1PxLCyR_H-mOgPjyFj3DhWXryKW21CH2zFWwzTnqjfEA/edit?usp=sharing Proposal Below *I am writing this document to propose changes and to start