Review Request 70486: HIVE-21610: Union operator can flow in the wrong stage causing NPE

2019-04-16 Thread Antal Sinkovits via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70486/ --- Review request for hive, Zoltan Haindrich, Naveen Gangam, and Peter Vary.

Review Request 69560: HIVE-21035: Race condition in SparkUtilities#getSparkSession

2018-12-12 Thread Antal Sinkovits via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69560/ --- Review request for hive, Denys Kuzmenko, Peter Vary, and Adam Szita.

Re: Review Request 68474: HIVE-20440

2018-11-07 Thread Antal Sinkovits via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68474/ --- (Updated nov. 7, 2018, 2:38 du) Review request for hive, Naveen Gangam, Sahil

Re: Review Request 68474: HIVE-20440

2018-11-07 Thread Antal Sinkovits via Review Board
> On okt. 16, 2018, 2:56 du, Sahil Takiar wrote: > > Could we add some more E2E integration tests? I'm thinking they could at > > the granularity of a `MapJoinOperator`? For example, confirm that starting > > a new query actually evicts everything from the cache? We want to make sure > > we

Re: Review Request 68474: HIVE-20440

2018-11-06 Thread Antal Sinkovits via Review Board
> On okt. 16, 2018, 2:50 du, Sahil Takiar wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SmallTableCache.java > > Lines 131 (patched) > > > > > > why do we run the action just for the l2 cache? L2

Re: Review Request 68474: HIVE-20440

2018-11-06 Thread Antal Sinkovits via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68474/ --- (Updated nov. 6, 2018, 12:28 du) Review request for hive, Naveen Gangam, Sahil

Re: Review Request 68474: HIVE-20440

2018-11-06 Thread Antal Sinkovits via Review Board
> On okt. 16, 2018, 2:56 du, Sahil Takiar wrote: > > Could we add some more E2E integration tests? I'm thinking they could at > > the granularity of a `MapJoinOperator`? For example, confirm that starting > > a new query actually evicts everything from the cache? We want to make sure > > we

Re: Review Request 69107: HIVE-20512

2018-10-31 Thread Antal Sinkovits via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69107/#review210230 ---

Re: Review Request 69107: HIVE-20512

2018-10-24 Thread Antal Sinkovits via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69107/#review209950 ---

Re: Review Request 69022: HIVE-20737: Local SparkContext is shared between user sessions and should be closed only when there is no active

2018-10-18 Thread Antal Sinkovits via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69022/#review209739 --- Ship it! Ship It! - Antal Sinkovits On okt. 16, 2018, 4:49

Re: Review Request 68474: HIVE-20440

2018-10-10 Thread Antal Sinkovits via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68474/ --- (Updated okt. 10, 2018, 1:20 du) Review request for hive, Naveen Gangam, Sahil

Re: Review Request 68683: Add new configuration to set the size of the global compile lock

2018-09-26 Thread Antal Sinkovits via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68683/#review209017 --- common/src/java/org/apache/hadoop/hive/conf/HiveConf.java Lines

Re: Review Request 68474: HIVE-20440: Create better cache eviction policy for SmallTableCache

2018-09-19 Thread Antal Sinkovits via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68474/ --- (Updated szept. 19, 2018, 11:14 du) Review request for hive, Naveen Gangam,

Re: Review Request 68744: Add Surrogate Keys function to Hive

2018-09-18 Thread Antal Sinkovits via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68744/#review208733 ---

Review Request 68474: HIVE-20440: Create better cache eviction policy for SmallTableCache

2018-08-22 Thread Antal Sinkovits via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68474/ --- Review request for hive, Naveen Gangam, Sahil Takiar, Adam Szita, and Xuefu

Review Request 67250: HIVE-17317 - Make Dbcp configurable using hive properties in hive-site.xml

2018-05-22 Thread Antal Sinkovits via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67250/ --- Review request for hive and Peter Vary. Bugs: HIVE-17317