Re: Review Request 41457: HIVE-11865

2015-12-18 Thread Jesús Camacho Rodríguez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41457/ --- (Updated Dec. 18, 2015, 5:28 p.m.) Review request for hive, Ashutosh Chauhan

[jira] [Created] (HIVE-12708) Hive on Spark doesn't work with Kerboresed HBase [Spark Branch]

2015-12-18 Thread Xuefu Zhang (JIRA)
Xuefu Zhang created HIVE-12708: -- Summary: Hive on Spark doesn't work with Kerboresed HBase [Spark Branch] Key: HIVE-12708 URL: https://issues.apache.org/jira/browse/HIVE-12708 Project: Hive

Re: Review Request 41457: HIVE-11865

2015-12-18 Thread John Pullokkaran
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41457/#review111254 --- ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java

Re: Review Request 41431: HIVE-12674 HS2 Tez session lifetime

2015-12-18 Thread Sergey Shelukhin
> On Dec. 17, 2015, 10:51 a.m., Vikram Dixit Kumaraswamy wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPoolManager.java, > > line 129 > > > > > > expiration queue length is fixed at 11?

using the Hive SQL parser in Spark

2015-12-18 Thread Reynold Xin
Hi Hive devs, I would like to share with you Spark's plan w.r.t. SQL parser going forward. As you may (or may not) know, Spark SQL has had two parsers so far: - a very simple one based on Scala's parser combinator; and - one that depends on Hive's The Scala parser combinator one was written

Re: Review Request 41457: HIVE-11865

2015-12-18 Thread John Pullokkaran
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41457/#review111247 --- ql/src/java/org/apache/hadoop/hive/ql/optimizer/Optimizer.java

Re: Review Request 41457: HIVE-11865

2015-12-18 Thread John Pullokkaran
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41457/#review111255 --- ql/src/java/org/apache/hadoop/hive/ql/plan/FilterDesc.java (line

Re: using the Hive SQL parser in Spark

2015-12-18 Thread Gopal Vijayaraghavan
>We have looked into various options, and it looks like the best option is >to copy the ANTLR grammar file from Hive into Spark. Because the grammar >file is tightly coupled with Hive's semantic analysis, we need to refactor >some code to use them so it will end up becoming the .g file plus some

Re: Review Request 41457: HIVE-11865

2015-12-18 Thread John Pullokkaran
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41457/#review111248 ---

[jira] [Created] (HIVE-12712) HiveInputFormat may fail to column names to read in some cases

2015-12-18 Thread Prasanth Jayachandran (JIRA)
Prasanth Jayachandran created HIVE-12712: Summary: HiveInputFormat may fail to column names to read in some cases Key: HIVE-12712 URL: https://issues.apache.org/jira/browse/HIVE-12712

Re: Review Request 41431: HIVE-12674 HS2 Tez session lifetime

2015-12-18 Thread Sergey Shelukhin
> On Dec. 17, 2015, 10:51 a.m., Vikram Dixit Kumaraswamy wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPoolManager.java, > > line 467 > > > > > > Can you raise a jira for follow up on this?

Re: Review Request 41535: HIVE-12632 LLAP: don't use IO elevator for ACID tables

2015-12-18 Thread j . prasanth . j
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41535/#review111323 --- Ship it! Ship It! - Prasanth_J On Dec. 18, 2015, 9:40 p.m.,

Re: Review Request 41377: HIVE-12528 don't start HS2 Tez sessions in a single thread

2015-12-18 Thread Siddharth Seth
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41377/#review111342 --- TezSessionState - does that need to be synchronized on various

[jira] [Created] (HIVE-12711) Document howto disable web ui in config of hive.server2.webui.port

2015-12-18 Thread Thejas M Nair (JIRA)
Thejas M Nair created HIVE-12711: Summary: Document howto disable web ui in config of hive.server2.webui.port Key: HIVE-12711 URL: https://issues.apache.org/jira/browse/HIVE-12711 Project: Hive

Re: Review Request 40589: Implement limit push down through union all in CBO

2015-12-18 Thread John Pullokkaran
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40589/#review111311 ---

[jira] [Created] (HIVE-12710) add better logging for Tez session creation thread failures

2015-12-18 Thread Sergey Shelukhin (JIRA)
Sergey Shelukhin created HIVE-12710: --- Summary: add better logging for Tez session creation thread failures Key: HIVE-12710 URL: https://issues.apache.org/jira/browse/HIVE-12710 Project: Hive

Re: Review Request 40867: HIVE-11527 - bypass HiveServer2 thrift interface for query results

2015-12-18 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40867/#review111316 --- jdbc/src/java/org/apache/hive/jdbc/HiveQueryResultSet.java (line

Re: Review Request 40865: Implement/Enable constant related optimization rules in Calcite: enable HiveReduceExpressionsRule to fold constants

2015-12-18 Thread pengcheng xiong
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40865/ --- (Updated Dec. 19, 2015, 12:28 a.m.) Review request for hive and John

Re: Review Request 41431: HIVE-12674 HS2 Tez session lifetime

2015-12-18 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41431/ --- (Updated Dec. 19, 2015, 12:59 a.m.) Review request for hive, Siddharth Seth

Re: Review Request 41431: HIVE-12674 HS2 Tez session lifetime

2015-12-18 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41431/#review111327 ---

Re: Review Request 41431: HIVE-12674 HS2 Tez session lifetime

2015-12-18 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41431/ --- (Updated Dec. 19, 2015, 1:03 a.m.) Review request for hive, Siddharth Seth and

[jira] [Created] (HIVE-12709) further improve user level explain

2015-12-18 Thread Pengcheng Xiong (JIRA)
Pengcheng Xiong created HIVE-12709: -- Summary: further improve user level explain Key: HIVE-12709 URL: https://issues.apache.org/jira/browse/HIVE-12709 Project: Hive Issue Type: Sub-task

Re: Review Request 41457: HIVE-11865

2015-12-18 Thread Jesús Camacho Rodríguez
> On Dec. 18, 2015, 7:59 p.m., John Pullokkaran wrote: > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveSortMergeRule.java, > > line 1 > > > > > > These seems cosmetic, do we need these? These

Re: Review Request 41457: HIVE-11865

2015-12-18 Thread Jesús Camacho Rodríguez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41457/#review111288 --- ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java

Re: Review Request 41457: HIVE-11865

2015-12-18 Thread Jesús Camacho Rodríguez
> On Dec. 18, 2015, 8:09 p.m., John Pullokkaran wrote: > > ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java, line 492 > > > > > > This is fragile; i.e reusing the flag whether to run CBO or not for >

Re: using the Hive SQL parser in Spark

2015-12-18 Thread Reynold Xin
(Please use reply-all so I see the replies) Responses inline. On Fri, Dec 18, 2015 at 1:17 PM, Yin Huai wrote: > Let me add Reynold to the thread. > > On Fri, Dec 18, 2015 at 12:36 PM, Gopal Vijayaraghavan > wrote: > >> >> >We have looked into

Re: Review Request 41457: HIVE-11865

2015-12-18 Thread Jesús Camacho Rodríguez
> On Dec. 18, 2015, 7:52 p.m., John Pullokkaran wrote: > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/Optimizer.java, line 112 > > > > > > In the CBO Success path the additional const prop seems unnecessary. >

Re: Review Request 41377: HIVE-12528 don't start HS2 Tez sessions in a single thread

2015-12-18 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41377/ --- (Updated Dec. 18, 2015, 10:10 p.m.) Review request for hive, Gunther

Re: Review Request 41457: HIVE-11865

2015-12-18 Thread Jesús Camacho Rodríguez
> On Dec. 18, 2015, 8:09 p.m., John Pullokkaran wrote: > > ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java, line 492 > > > > > > This is fragile; i.e reusing the flag whether to run CBO or not for >

Re: using the Hive SQL parser in Spark

2015-12-18 Thread Yin Huai
Let me add Reynold to the thread. On Fri, Dec 18, 2015 at 12:36 PM, Gopal Vijayaraghavan wrote: > > >We have looked into various options, and it looks like the best option is > >to copy the ANTLR grammar file from Hive into Spark. Because the grammar > >file is tightly

Re: Review Request 41535: HIVE-12632 LLAP: don't use IO elevator for ACID tables

2015-12-18 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41535/ --- (Updated Dec. 18, 2015, 9:40 p.m.) Review request for hive and Prasanth_J.

Re: Review Request 41457: HIVE-11865

2015-12-18 Thread Jesús Camacho Rodríguez
> On Dec. 18, 2015, 8:12 p.m., John Pullokkaran wrote: > > ql/src/java/org/apache/hadoop/hive/ql/plan/FilterDesc.java, line 167 > > > > > > This is fragile. > > State will have to be maintained; i.e unset if a

Re: Review Request 41457: HIVE-11865

2015-12-18 Thread Jesús Camacho Rodríguez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41457/ --- (Updated Dec. 18, 2015, 10:19 p.m.) Review request for hive, Ashutosh Chauhan

Re: Review Request 40867: HIVE-11527 - bypass HiveServer2 thrift interface for query results

2015-12-18 Thread Sergey Shelukhin
> On Dec. 3, 2015, 9:40 p.m., Sergey Shelukhin wrote: > > jdbc/src/java/org/apache/hive/jdbc/HiveQueryResultSet.java, line 390 > > > > > > some existing configuration is probably needed (and better) > > Takanobu

Review Request 41582: HIVE-12713: Miscellaneous improvements in driver compile and execute logging

2015-12-18 Thread Chaoyu Tang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41582/ --- Review request for hive. Bugs: HIVE-12713

Re: Review Request 40865: Implement/Enable constant related optimization rules in Calcite: enable HiveReduceExpressionsRule to fold constants

2015-12-18 Thread John Pullokkaran
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40865/#review111348 ---

Re: Review Request 40865: Implement/Enable constant related optimization rules in Calcite: enable HiveReduceExpressionsRule to fold constants

2015-12-18 Thread John Pullokkaran
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40865/#review111351 ---

Re: Review Request 40865: Implement/Enable constant related optimization rules in Calcite: enable HiveReduceExpressionsRule to fold constants

2015-12-18 Thread John Pullokkaran
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40865/#review111345 ---

Re: Review Request 40865: Implement/Enable constant related optimization rules in Calcite: enable HiveReduceExpressionsRule to fold constants

2015-12-18 Thread John Pullokkaran
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40865/#review111344 ---

Re: Review Request 40865: Implement/Enable constant related optimization rules in Calcite: enable HiveReduceExpressionsRule to fold constants

2015-12-18 Thread John Pullokkaran
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40865/#review111349 ---

[jira] [Created] (HIVE-12713) Miscellaneous improvements in driver compile and execute logging

2015-12-18 Thread Chaoyu Tang (JIRA)
Chaoyu Tang created HIVE-12713: -- Summary: Miscellaneous improvements in driver compile and execute logging Key: HIVE-12713 URL: https://issues.apache.org/jira/browse/HIVE-12713 Project: Hive