Re: Review Request 44201: HIVE-13188: Allow users of RetryingThriftClient to close transport

2016-03-02 Thread Rajat Khandelwal
> On March 1, 2016, 1:55 p.m., Amareshwari Sriramadasu wrote: > > service/src/test/org/apache/hive/service/cli/TestRetryingThriftCLIServiceClient.java, > > line 61 > > > > > > Can you update test to call new method

Re: Review Request 44201: HIVE-13188: Allow users of RetryingThriftClient to close transport

2016-03-02 Thread Rajat Khandelwal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44201/ --- (Updated March 3, 2016, 12:20 p.m.) Review request for hive. Bugs:

Re: Review Request 44172: HIVE-11483: Add encoding and decoding for query string config

2016-03-02 Thread Amareshwari Sriramadasu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44172/#review121807 --- common/src/java/org/apache/hadoop/hive/conf/HiveConf.java (line

Re: Review Request 44201: HIVE-13188: Allow users of RetryingThriftClient to close transport

2016-03-02 Thread Amareshwari Sriramadasu
> On March 1, 2016, 8:25 a.m., Amareshwari Sriramadasu wrote: > > service/src/test/org/apache/hive/service/cli/TestRetryingThriftCLIServiceClient.java, > > line 61 > > > > > > Can you update test to call new method

Re: Review Request 18182: HIVE-5370. format_number udf should take user specifed format as argument

2016-03-02 Thread Amareshwari Sriramadasu
> On March 2, 2016, 5:53 p.m., Ashutosh Chauhan wrote: > > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFFormatNumber.java, > > line 178 > > > > > > I assume you only allow F to be a constant string.

Re: Review Request 18182: HIVE-5370. format_number udf should take user specifed format as argument

2016-03-02 Thread Amareshwari Sriramadasu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18182/ --- (Updated March 3, 2016, 6:19 a.m.) Review request for hive, Ashutosh Chauhan,

[jira] [Created] (HIVE-13199) NDC stopped working in LLAP logging

2016-03-02 Thread Prasanth Jayachandran (JIRA)
Prasanth Jayachandran created HIVE-13199: Summary: NDC stopped working in LLAP logging Key: HIVE-13199 URL: https://issues.apache.org/jira/browse/HIVE-13199 Project: Hive Issue Type:

Re: Review Request 42134: More information to user on GetOperationStatus in Hive Server2 when query is still executing

2016-03-02 Thread Szehon Ho
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42134/#review121751 --- This requirement is very similar to webui's display of

[jira] [Created] (HIVE-13198) Authorization issues with cascading views

2016-03-02 Thread Pengcheng Xiong (JIRA)
Pengcheng Xiong created HIVE-13198: -- Summary: Authorization issues with cascading views Key: HIVE-13198 URL: https://issues.apache.org/jira/browse/HIVE-13198 Project: Hive Issue Type:

Re: Review Request 18182: HIVE-5370. format_number udf should take user specifed format as argument

2016-03-02 Thread Ashutosh Chauhan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18182/#review121679 ---

Re: Review Request 44271: HIVE-12270 : Add DBTokenStore support to HS2 delegation token

2016-03-02 Thread Chaoyu Tang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44271/ --- (Updated March 2, 2016, 4:39 p.m.) Review request for hive. Changes ---

Review Request 44271: HIVE-12270 : Add DBTokenStore support to HS2 delegation token

2016-03-02 Thread Chaoyu Tang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44271/ --- Review request for hive. Bugs: HIVE-12270

[jira] [Created] (HIVE-13197) Add adapted constprog2.q and constprog_partitioner.q tests back

2016-03-02 Thread Jesus Camacho Rodriguez (JIRA)
Jesus Camacho Rodriguez created HIVE-13197: -- Summary: Add adapted constprog2.q and constprog_partitioner.q tests back Key: HIVE-13197 URL: https://issues.apache.org/jira/browse/HIVE-13197

Re: Review Request 42134: More information to user on GetOperationStatus in Hive Server2 when query is still executing

2016-03-02 Thread Akshay Goyal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42134/ --- (Updated March 2, 2016, 11:44 a.m.) Review request for hive and Amareshwari

Re: Review Request 42134: More information to user on GetOperationStatus in Hive Server2 when query is still executing

2016-03-02 Thread Akshay Goyal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42134/ --- (Updated March 2, 2016, 11:09 a.m.) Review request for hive and Amareshwari