Re: Review Request 59205: HIVE-16579: CachedStore: improvements to partition col stats caching and cache column stats for unpartitioned table

2017-05-14 Thread Daniel Dai
> On May 14, 2017, 7:38 a.m., Daniel Dai wrote: > > metastore/src/java/org/apache/hadoop/hive/metastore/cache/CachedStore.java > > Lines 528 (patched) > > > > > > If using dirty flag, databaseCacheLock can be

Re: Review Request 59205: HIVE-16579: CachedStore: improvements to partition col stats caching and cache column stats for unpartitioned table

2017-05-14 Thread Thejas Nair
> On May 14, 2017, 7:38 a.m., Daniel Dai wrote: > > metastore/src/java/org/apache/hadoop/hive/metastore/cache/CachedStore.java > > Line 381 (original), 526 (patched) > > > > > > I think we only need a dirty flag, it

Re: Review Request 59205: HIVE-16579: CachedStore: improvements to partition col stats caching and cache column stats for unpartitioned table

2017-05-14 Thread Thejas Nair
> On May 14, 2017, 7:38 a.m., Daniel Dai wrote: > > metastore/src/java/org/apache/hadoop/hive/metastore/cache/CachedStore.java > > Lines 528 (patched) > > > > > > If using dirty flag, databaseCacheLock can be

Re: Review Request 59205: HIVE-16579: CachedStore: improvements to partition col stats caching and cache column stats for unpartitioned table

2017-05-14 Thread Thejas Nair
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59205/#review174906 ---

Re: Review Request 59205: HIVE-16579: CachedStore: improvements to partition col stats caching and cache column stats for unpartitioned table

2017-05-14 Thread Daniel Dai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59205/#review174907 ---

Re: Review Request 59205: HIVE-16579: CachedStore: improvements to partition col stats caching and cache column stats for unpartitioned table

2017-05-14 Thread Thejas Nair
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59205/#review174905 ---