Re: Review Request 64490: HIVE-14498

2017-12-15 Thread Jesús Camacho Rodríguez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64490/ --- (Updated Dec. 16, 2017, 2:19 a.m.) Review request for hive, Ashutosh Chauhan

[jira] [Created] (HIVE-18288) merge/concat not support on Acid table

2017-12-15 Thread Eugene Koifman (JIRA)
Eugene Koifman created HIVE-18288: - Summary: merge/concat not support on Acid table Key: HIVE-18288 URL: https://issues.apache.org/jira/browse/HIVE-18288 Project: Hive Issue Type: Sub-task

Re: Review Request 64595: HIVE-18257 implement scheduling policy configuration instead of hardcoding fair scheduling

2017-12-15 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64595/ --- (Updated Dec. 15, 2017, 11:21 p.m.) Review request for hive, Harish Jaiprakash

Re: Review Request 64595: HIVE-18257 implement scheduling policy configuration instead of hardcoding fair scheduling

2017-12-15 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64595/ --- (Updated Dec. 15, 2017, 11:20 p.m.) Review request for hive, Harish Jaiprakash

[jira] [Created] (HIVE-18287) Scratch dir permission check doesn't honor Ranger based privileges

2017-12-15 Thread Thejas M Nair (JIRA)
Thejas M Nair created HIVE-18287: Summary: Scratch dir permission check doesn't honor Ranger based privileges Key: HIVE-18287 URL: https://issues.apache.org/jira/browse/HIVE-18287 Project: Hive

Re: Review Request 64555: HIVE-18230 create plan like plan, and replace plan commands for easy modification

2017-12-15 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64555/ --- (Updated Dec. 15, 2017, 10:16 p.m.) Review request for hive, Harish Jaiprakash

Re: Review Request 64555: HIVE-18230 create plan like plan, and replace plan commands for easy modification

2017-12-15 Thread Sergey Shelukhin
> On Dec. 15, 2017, 4:48 a.m., Harish Jaiprakash wrote: > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java > > Lines 9869 (patched) > > > > > > Hmm... if people use replace

Re: Review Request 64433: HIVE-18203 change the way WM is enabled and allow dropping the last resource plan

2017-12-15 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64433/ --- (Updated Dec. 15, 2017, 9:19 p.m.) Review request for hive, Harish Jaiprakash

Re: Review Request 64433: HIVE-18203 change the way WM is enabled and allow dropping the last resource plan

2017-12-15 Thread Sergey Shelukhin
> On Dec. 11, 2017, 4:56 a.m., Harish Jaiprakash wrote: > > ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java > > Lines 939 (patched) > > > > > > Yup, seem unintuitive to use enable in one and

Re: [DISCUSS] IMetaStoreClient and HMS Thrift API exception handling

2017-12-15 Thread Alan Gates
Sorry, I didn’t make clear which suggestion I was responding to, as there are multiple suggestions in the thread. ​Adding new exceptions is fine, as long as it doesn’t break old clients like Thejas mentions. And clearly cleaning up NPEs is good. Changing which exceptions are thrown when a

[jira] [Created] (HIVE-18286) java.lang.ClassCastException: org.apache.hadoop.hive.ql.exec.vector.DoubleColumnVector cannot be cast to org.apache.hadoop.hive.ql.exec.vector.LongColumnVector

2017-12-15 Thread Eugene Koifman (JIRA)
Eugene Koifman created HIVE-18286: - Summary: java.lang.ClassCastException: org.apache.hadoop.hive.ql.exec.vector.DoubleColumnVector cannot be cast to org.apache.hadoop.hive.ql.exec.vector.LongColumnVector Key: HIVE-18286

Re: Review Request 64356: HIVE-18078 WM getSession needs some retry logic

2017-12-15 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64356/ --- (Updated Dec. 15, 2017, 7:07 p.m.) Review request for hive and Prasanth_J.

Re: [DISCUSS] IMetaStoreClient and HMS Thrift API exception handling

2017-12-15 Thread Thejas Nair
Alan, The changes suggested by Peter was to add another checked exception, which is a subclass of TException. And TException is already being thrown by all thrift api calls. So it should not break any applications. The only concern I have is some issues if old client is used with new servers. We

Re: Review Request 64631: HIVE-18273 add LLAP-level counters for WM

2017-12-15 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64631/ --- (Updated Dec. 15, 2017, 6:36 p.m.) Review request for hive and Prasanth_J.

[jira] [Created] (HIVE-18285) StatsTask uses a cached ql.metadata.Table object

2017-12-15 Thread Eugene Koifman (JIRA)
Eugene Koifman created HIVE-18285: - Summary: StatsTask uses a cached ql.metadata.Table object Key: HIVE-18285 URL: https://issues.apache.org/jira/browse/HIVE-18285 Project: Hive Issue Type:

Re: [DISCUSS] IMetaStoreClient and HMS Thrift API exception handling

2017-12-15 Thread Peter Vary
Hi Alan, I think I understand your point. If we come up with the standalone MetaStore but the interface is completely different then the original one, then we will lose in adoption. I agree with your assessment. Do you (or anyone) have any ideas, how can we rationalize the interface without

Re: Adding Hive Metastore functions to add and alter partitions for multiple tables

2017-12-15 Thread Andrew Sherman
Thanks Kaijie. One concern is that the new functions effectively expand the size of the transactions and the work that must be undone if they fail. So the question is whether the benefit is large enough to justify adding complexity. If no-one else has comments then you should probably think

[jira] [Created] (HIVE-18284) NPE when inserting data with 'distribute by'

2017-12-15 Thread Aki Tanaka (JIRA)
Aki Tanaka created HIVE-18284: - Summary: NPE when inserting data with 'distribute by' Key: HIVE-18284 URL: https://issues.apache.org/jira/browse/HIVE-18284 Project: Hive Issue Type: Bug

Re: [DISCUSS] IMetaStoreClient and HMS Thrift API exception handling

2017-12-15 Thread Alan Gates
We do not want to break either the Thrift APIs or the IMetaStoreClient ones. I do not know if we have ever declared them to be public or not, but they are de facto public in that everyone uses them. Consider that these are used by Impala, Presto, Qubole, Amazon's Glue, Spark, and probably others

Re: apache hive builds

2017-12-15 Thread Adam Szita
This should be fixed now. Some conclusions can be seen in at: https://issues.apache.org/jira/browse/HIVE-18263?focusedCommentId=16292354=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16292354 On 11 December 2017 at 18:48, Adam Szita wrote: > Hi

Re: [DISCUSS] IMetaStoreClient and HMS Thrift API exception handling

2017-12-15 Thread Peter Vary
If the application using the old API does not handle the original exceptions differently than the TExceptions then it should work as expected. > On Dec 14, 2017, at 10:50 PM, Thejas Nair wrote: > > This direction looks good to me. > If the new exceptions are inheriting

Re: [DISCUSS] IMetaStoreClient and HMS Thrift API exception handling

2017-12-15 Thread Peter Vary
It makes perfect sense to me to clean up the API when we release the standalone MetaStore. +1 for the API cleanup in general! > On Dec 15, 2017, at 1:53 AM, Alexander Kolbasov wrote: > > +1 for API cleanup in general! > > On Thu, Dec 14, 2017 at 4:25 PM, Sergey Shelukhin