Re: Review Request 69663: HIVE-16976

2019-01-07 Thread Deepak Jaiswal
> On Jan. 7, 2019, 4:41 p.m., Jesús Camacho Rodríguez wrote: > > ql/src/java/org/apache/hadoop/hive/ql/ppd/SyntheticJoinPredicate.java > > Lines 284 (patched) > > > > > > We should add a call to extended version

[jira] [Created] (HIVE-21098) DPP: SyntheticJoinPredicate transitivity for < > and BETWEEN needs extension

2019-01-07 Thread Deepak Jaiswal (JIRA)
Deepak Jaiswal created HIVE-21098: - Summary: DPP: SyntheticJoinPredicate transitivity for < > and BETWEEN needs extension Key: HIVE-21098 URL: https://issues.apache.org/jira/browse/HIVE-21098

Re: Review Request 69663: HIVE-16976

2019-01-07 Thread Deepak Jaiswal
> On Jan. 7, 2019, 4:41 p.m., Jesús Camacho Rodríguez wrote: > > ql/src/java/org/apache/hadoop/hive/ql/ppd/SyntheticJoinPredicate.java > > Lines 330 (patched) > > > > > > Should we still return null if function text

Re: Review Request 69663: HIVE-16976

2019-01-07 Thread Deepak Jaiswal
> On Jan. 7, 2019, 10:40 p.m., Jesús Camacho Rodríguez wrote: > > ql/src/java/org/apache/hadoop/hive/ql/ppd/SyntheticJoinPredicate.java > > Lines 254 (patched) > > > > > > srcPos and targetPos do not seem to refer

Re: Review Request 69663: HIVE-16976

2019-01-07 Thread Jesús Camacho Rodríguez
> On Jan. 7, 2019, 10:40 p.m., Jesús Camacho Rodríguez wrote: > > ql/src/java/org/apache/hadoop/hive/ql/ppd/SyntheticJoinPredicate.java > > Lines 254 (patched) > > > > > > srcPos and targetPos do not seem to refer

Re: Review Request 69663: HIVE-16976

2019-01-07 Thread Jesús Camacho Rodríguez
> On Jan. 7, 2019, 4:41 p.m., Jesús Camacho Rodríguez wrote: > > ql/src/java/org/apache/hadoop/hive/ql/ppd/SyntheticJoinPredicate.java > > Lines 330 (patched) > > > > > > Should we still return null if function text

Re: Review Request 69663: HIVE-16976

2019-01-07 Thread Deepak Jaiswal
> On Jan. 7, 2019, 4:41 p.m., Jesús Camacho Rodríguez wrote: > > ql/src/java/org/apache/hadoop/hive/ql/ppd/SyntheticJoinPredicate.java > > Line 182 (original) > > > > > > Can you bring this back and delete 'if

Re: Review Request 69663: HIVE-16976

2019-01-07 Thread Jesús Camacho Rodríguez
> On Jan. 7, 2019, 4:41 p.m., Jesús Camacho Rodríguez wrote: > > ql/src/java/org/apache/hadoop/hive/ql/ppd/SyntheticJoinPredicate.java > > Line 182 (original) > > > > > > Can you bring this back and delete 'if

Re: Review Request 69663: HIVE-16976

2019-01-07 Thread Jesús Camacho Rodríguez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69663/#review211745 ---

Re: Review Request 69663: HIVE-16976

2019-01-07 Thread Deepak Jaiswal
> On Jan. 7, 2019, 4:41 p.m., Jesús Camacho Rodríguez wrote: > > Can we add some tests for the new feature? The reason there is no test yet is because it does nothing end to end. Both DPP route and semijoin reduction route dont process the predicate yet. > On Jan. 7, 2019, 4:41 p.m., Jesús

Re: Review Request 69664: HIVE-21077 : Database and Catalogs should have creation time

2019-01-07 Thread Adam Holley via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69664/#review211734 ---

Re: Review Request 69664: HIVE-21077 : Database and Catalogs should have creation time

2019-01-07 Thread Vihang Karajgaonkar via Review Board
> On Jan. 4, 2019, 5:33 p.m., Karthik Manamcheri wrote: > > > > Karthik Manamcheri wrote: > 1. While we are at it, can we make sure that the "create time" exists for > everything else (if required)? Such as catalog, partitions.. > 2. Out of curiosity.. are there any tests to ensure

Re: Review Request 69664: HIVE-21077 : Database and Catalogs should have creation time

2019-01-07 Thread Vihang Karajgaonkar via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69664/ --- (Updated Jan. 7, 2019, 7:16 p.m.) Review request for hive, Karthik Manamcheri,

Re: Review Request 69663: HIVE-16976

2019-01-07 Thread Jesús Camacho Rodríguez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69663/#review211725 --- Can we add some tests for the new feature?

[jira] [Created] (HIVE-21097) Replace SparkConf dependency from HS2 with Hadoop Conf

2019-01-07 Thread Adam Szita (JIRA)
Adam Szita created HIVE-21097: - Summary: Replace SparkConf dependency from HS2 with Hadoop Conf Key: HIVE-21097 URL: https://issues.apache.org/jira/browse/HIVE-21097 Project: Hive Issue Type:

[jira] [Created] (HIVE-21096) Remove unnecessary Spark dependency from HS2 process

2019-01-07 Thread Adam Szita (JIRA)
Adam Szita created HIVE-21096: - Summary: Remove unnecessary Spark dependency from HS2 process Key: HIVE-21096 URL: https://issues.apache.org/jira/browse/HIVE-21096 Project: Hive Issue Type:

[jira] [Created] (HIVE-21095) 'Show create table' should not display a time zone for timestamp with local time zone

2019-01-07 Thread Karen Coppage (JIRA)
Karen Coppage created HIVE-21095: Summary: 'Show create table' should not display a time zone for timestamp with local time zone Key: HIVE-21095 URL: https://issues.apache.org/jira/browse/HIVE-21095

Review Request 69683: [HIVE-21071] Improve getInputSummary

2019-01-07 Thread David Mollitor
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69683/ --- Review request for hive. Repository: hive-git Description --- Improve

[jira] [Created] (HIVE-21094) Store TIMESTAMP WITH LOCAL TIME ZONE in UTC instead of writer's time zone

2019-01-07 Thread Karen Coppage (JIRA)
Karen Coppage created HIVE-21094: Summary: Store TIMESTAMP WITH LOCAL TIME ZONE in UTC instead of writer's time zone Key: HIVE-21094 URL: https://issues.apache.org/jira/browse/HIVE-21094 Project:

[jira] [Created] (HIVE-21093) Push grouping sets in Aggregate operator to JDBC sources from Calcite

2019-01-07 Thread Jesus Camacho Rodriguez (JIRA)
Jesus Camacho Rodriguez created HIVE-21093: -- Summary: Push grouping sets in Aggregate operator to JDBC sources from Calcite Key: HIVE-21093 URL: https://issues.apache.org/jira/browse/HIVE-21093

Re: Review Request 69633: HIVE-20159 Do Not Print StackTraces to STDERR in ConditionalResolverSkewJoin

2019-01-07 Thread Peter Vary via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69633/#review211722 --- Thanks for the fix! Fix it and ship it!