Re: Is Github PR mandatory?

2019-03-14 Thread Mani M
It's used as substitution for review board. With Regards M.Mani +61 432 461 087 On Fri, 15 Mar 2019, 13:59 Rui Li, wrote: > Hi, > > I believe we still need to upload patch to JIRA for precommit testing. So > just want to make sure whether opening a github PR is mandatory? Or is it > just a

[GitHub] [hive] coder-chenzhi opened a new pull request #571: HIVE-21392 Fix misconfigurations of DataNucleus log in log4j.properties

2019-03-14 Thread GitBox
coder-chenzhi opened a new pull request #571: HIVE-21392 Fix misconfigurations of DataNucleus log in log4j.properties URL: https://github.com/apache/hive/pull/571 HIVE-21392 Misconfigurations of DataNucleus log in log4j.properties In the patch of

[GitHub] [hive] coder-chenzhi commented on issue #556: HIVE-21392 Fix misconfigurations of DataNucleus log in log4j.properties

2019-03-14 Thread GitBox
coder-chenzhi commented on issue #556: HIVE-21392 Fix misconfigurations of DataNucleus log in log4j.properties URL: https://github.com/apache/hive/pull/556#issuecomment-473141798 I have closed these PR because I am not familiar with `git rebase` and introduce some misoperation. And I will

[GitHub] [hive] coder-chenzhi closed pull request #556: HIVE-21392 Fix misconfigurations of DataNucleus log in log4j.properties

2019-03-14 Thread GitBox
coder-chenzhi closed pull request #556: HIVE-21392 Fix misconfigurations of DataNucleus log in log4j.properties URL: https://github.com/apache/hive/pull/556 This is an automated message from the Apache Git Service. To

Is Github PR mandatory?

2019-03-14 Thread Rui Li
Hi, I believe we still need to upload patch to JIRA for precommit testing. So just want to make sure whether opening a github PR is mandatory? Or is it just a substitution for the review board? -- Best regards! Rui Li

[jira] [Created] (HIVE-21450) Buffer Reader is not closed during executeInitSql

2019-03-14 Thread mahesh kumar behera (JIRA)
mahesh kumar behera created HIVE-21450: -- Summary: Buffer Reader is not closed during executeInitSql Key: HIVE-21450 URL: https://issues.apache.org/jira/browse/HIVE-21450 Project: Hive

[GitHub] [hive] vineetgarg02 closed pull request #552: Hive 21279

2019-03-14 Thread GitBox
vineetgarg02 closed pull request #552: Hive 21279 URL: https://github.com/apache/hive/pull/552 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [hive] sankarh commented on a change in pull request #388: HIVE-20057: Fix Hive table conversion DESCRIBE table bug

2019-03-14 Thread GitBox
sankarh commented on a change in pull request #388: HIVE-20057: Fix Hive table conversion DESCRIBE table bug URL: https://github.com/apache/hive/pull/388#discussion_r265716913 ## File path:

[GitHub] [hive] sankarh commented on a change in pull request #388: HIVE-20057: Fix Hive table conversion DESCRIBE table bug

2019-03-14 Thread GitBox
sankarh commented on a change in pull request #388: HIVE-20057: Fix Hive table conversion DESCRIBE table bug URL: https://github.com/apache/hive/pull/388#discussion_r265716913 ## File path:

[GitHub] [hive] jcamachor closed pull request #557: HIVE-21338 Remove order by and limit for aggregates

2019-03-14 Thread GitBox
jcamachor closed pull request #557: HIVE-21338 Remove order by and limit for aggregates URL: https://github.com/apache/hive/pull/557 This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Created] (HIVE-21449) implement 'WITHIN GROUP' clause

2019-03-14 Thread Laszlo Bodor (JIRA)
Laszlo Bodor created HIVE-21449: --- Summary: implement 'WITHIN GROUP' clause Key: HIVE-21449 URL: https://issues.apache.org/jira/browse/HIVE-21449 Project: Hive Issue Type: Bug

[GitHub] [hive] jcamachor commented on a change in pull request #567: HIVE-21382: Group by keys reduction optimization - keys are not reduced in query23

2019-03-14 Thread GitBox
jcamachor commented on a change in pull request #567: HIVE-21382: Group by keys reduction optimization - keys are not reduced in query23 URL: https://github.com/apache/hive/pull/567#discussion_r265644194 ## File path:

[GitHub] [hive] BELUGABEHR closed pull request #561: HIVE-21264: Improvements Around CharTypeInfo

2019-03-14 Thread GitBox
BELUGABEHR closed pull request #561: HIVE-21264: Improvements Around CharTypeInfo URL: https://github.com/apache/hive/pull/561 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [hive] pudidic opened a new pull request #570: HIVE-21437: Vectorization: Decimal64 division with integer columns (t…

2019-03-14 Thread GitBox
pudidic opened a new pull request #570: HIVE-21437: Vectorization: Decimal64 division with integer columns (t… URL: https://github.com/apache/hive/pull/570 …eddy Choi) This is an automated message from the Apache Git

[GitHub] [hive] ShubhamChaurasia commented on issue #534: HIVE-21270: A UDTF to show schema (column names and types) of given q…

2019-03-14 Thread GitBox
ShubhamChaurasia commented on issue #534: HIVE-21270: A UDTF to show schema (column names and types) of given q… URL: https://github.com/apache/hive/pull/534#issuecomment-472827282 @rmsmani thanks. Closed. This is an

[GitHub] [hive] ShubhamChaurasia closed pull request #534: HIVE-21270: A UDTF to show schema (column names and types) of given q…

2019-03-14 Thread GitBox
ShubhamChaurasia closed pull request #534: HIVE-21270: A UDTF to show schema (column names and types) of given q… URL: https://github.com/apache/hive/pull/534 This is an automated message from the Apache Git Service. To

[GitHub] [hive] rmsmani commented on issue #556: HIVE-21392 Fix misconfigurations of DataNucleus log in log4j.properties

2019-03-14 Thread GitBox
rmsmani commented on issue #556: HIVE-21392 Fix misconfigurations of DataNucleus log in log4j.properties URL: https://github.com/apache/hive/pull/556#issuecomment-472804714 @coder-chenzhi The build got failed for the given patch. The details available in the JIRA.

[GitHub] [hive] rmsmani commented on issue #534: HIVE-21270: A UDTF to show schema (column names and types) of given q…

2019-03-14 Thread GitBox
rmsmani commented on issue #534: HIVE-21270: A UDTF to show schema (column names and types) of given q… URL: https://github.com/apache/hive/pull/534#issuecomment-472803709 @ShubhamChaurasia As the sources merged, can you close this PR.

[GitHub] [hive] rmsmani commented on issue #566: support select Date and Timestamp type values into variables

2019-03-14 Thread GitBox
rmsmani commented on issue #566: support select Date and Timestamp type values into variables URL: https://github.com/apache/hive/pull/566#issuecomment-472802836 HI @dingqiangliu What is the Jira Ticket number for this. If jira ticket is not available, 1.Raise the jira

[GitHub] [hive] rmsmani commented on issue #561: HIVE-21264: Improvements Around CharTypeInfo

2019-03-14 Thread GitBox
rmsmani commented on issue #561: HIVE-21264: Improvements Around CharTypeInfo URL: https://github.com/apache/hive/pull/561#issuecomment-472798917 HI @BELUGABEHR As the Jira ticket is RESOLVED & merged to branch, please close this PR

[jira] [Created] (HIVE-21448) Insert Overwrite of a full ACID table when the select returns no data is not creating an empty base dir.

2019-03-14 Thread Abhishek Somani (JIRA)
Abhishek Somani created HIVE-21448: -- Summary: Insert Overwrite of a full ACID table when the select returns no data is not creating an empty base dir. Key: HIVE-21448 URL:

[jira] [Created] (HIVE-21447) Constraints: Adding a constraint twice takes 120+ seconds to fail

2019-03-14 Thread Gopal V (JIRA)
Gopal V created HIVE-21447: -- Summary: Constraints: Adding a constraint twice takes 120+ seconds to fail Key: HIVE-21447 URL: https://issues.apache.org/jira/browse/HIVE-21447 Project: Hive Issue