Re: Review Request 60753: Add HLL as an alternative to FM sketch to compute stats

2017-07-13 Thread Andrew Sherman
ndran" in HyperLogLogUtils.java should probably be removed - Andrew Sherman On July 13, 2017, 12:12 a.m., pengcheng xiong wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://revi

Re: [DISCUSS] Separating out the metastore as its own TLP

2017-07-11 Thread Andrew Sherman
On Fri, Jun 30, 2017 at 5:05 PM, Owen O'Malley wrote: > On Fri, Jun 30, 2017 at 3:26 PM, Chao Sun wrote: > > > and maybe a different project name? > > > > Yes, it certainly needs a new name. I'd like to suggest Riven. > > .. Owen > How about "Flora"?

Re: Review Request 60445: HIVE-16935: Hive should strip comments from input before choosing which CommandProcessor to run.

2017-07-05 Thread Andrew Sherman
ervice/cli/operation/ExecuteStatementOperation.java 2dd90b69b3bf789b1a3928129cf801b17884033f Diff: https://reviews.apache.org/r/60445/diff/4/ Changes: https://reviews.apache.org/r/60445/diff/3-4/ Testing --- Added new test case. Hand tested with Hue and Jdbc. Thanks, Andrew Sherman

Re: Review Request 60445: HIVE-16935: Hive should strip comments from input before choosing which CommandProcessor to run.

2017-06-30 Thread Andrew Sherman
/operation/ExecuteStatementOperation.java 2dd90b69b3bf789b1a3928129cf801b17884033f Diff: https://reviews.apache.org/r/60445/diff/3/ Changes: https://reviews.apache.org/r/60445/diff/2-3/ Testing --- Added new test case. Hand tested with Hue and Jdbc. Thanks, Andrew Sherman

Re: Review Request 60445: HIVE-16935: Hive should strip comments from input before choosing which CommandProcessor to run.

2017-06-29 Thread Andrew Sherman
/operation/ExecuteStatementOperation.java 2dd90b69b3bf789b1a3928129cf801b17884033f Diff: https://reviews.apache.org/r/60445/diff/2/ Changes: https://reviews.apache.org/r/60445/diff/1-2/ Testing --- Added new test case. Hand tested with Hue and Jdbc. Thanks, Andrew Sherman

Re: Review Request 60445: HIVE-16935: Hive should strip comments from input before choosing which CommandProcessor to run.

2017-06-29 Thread Andrew Sherman
e need this as public? Yes, it is called from org.apache.hive.beeline.Commands - Andrew --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60445/#review179088 -

Re: Review Request 60445: HIVE-16935: Hive should strip comments from input before choosing which CommandProcessor to run.

2017-06-29 Thread Andrew Sherman
ndrew --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60445/#review179073 --- On June 26, 2017, 8:35 p.m., Andrew Sherman wrote: &

[jira] [Created] (HIVE-16991) HiveMetaStoreClient needs a 2-arg constructor for backwards compatibility

2017-06-29 Thread Andrew Sherman (JIRA)
Andrew Sherman created HIVE-16991: - Summary: HiveMetaStoreClient needs a 2-arg constructor for backwards compatibility Key: HIVE-16991 URL: https://issues.apache.org/jira/browse/HIVE-16991 Project

Review Request 60445: HIVE-16935: Hive should strip comments from input before choosing which CommandProcessor to run.

2017-06-26 Thread Andrew Sherman
ache.org/r/60445/diff/1/ Testing --- Added new test case. Hand tested with Hue and Jdbc. Thanks, Andrew Sherman

[jira] [Created] (HIVE-16935) Hive should strip comments from input before choosing which CommandProcessor to run.

2017-06-21 Thread Andrew Sherman (JIRA)
Andrew Sherman created HIVE-16935: - Summary: Hive should strip comments from input before choosing which CommandProcessor to run. Key: HIVE-16935 URL: https://issues.apache.org/jira/browse/HIVE-16935

<    1   2