Re: Review Request 54341: HIVE-15353: Metastore throws NPE if StorageDescriptor.cols is null

2018-02-05 Thread Anthony Hsu via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54341/ --- (Updated 二月 6, 2018, 3:01 a.m.) Review request for hive, Carl Steinbach and

Re: Review Request 62321: HIVE-17530: ClassCastException when converting uniontype

2017-09-14 Thread Anthony Hsu via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62321/ --- (Updated 九月 15, 2017, 1:52 a.m.) Review request for hive, Carl Steinbach and

Review Request 62321: HIVE-17530: ClassCastException when converting uniontype

2017-09-13 Thread Anthony Hsu via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62321/ --- Review request for hive, Carl Steinbach and Ratandeep Ratti. Bugs: HIVE-17530

Re: Review Request 62247: HIVE-17394: AvroSerde is regenerating TypeInfo objects for each nullable Avro field for every row

2017-09-12 Thread Anthony Hsu via Review Board
> On 九月 12, 2017, 5:02 p.m., Ratandeep Ratti wrote: > > serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroDeserializer.java > > Line 305 (original), 305 (patched) > > > > > > This comment is misleading now and

Re: Review Request 62247: HIVE-17394: AvroSerde is regenerating TypeInfo objects for each nullable Avro field for every row

2017-09-12 Thread Anthony Hsu via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62247/ --- (Updated 九月 12, 2017, 10:43 p.m.) Review request for hive, Carl Steinbach and

Review Request 62247: HIVE-17394: AvroSerde is regenerating TypeInfo objects for each nullable Avro field for every row

2017-09-12 Thread Anthony Hsu via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62247/ --- Review request for hive, Carl Steinbach and Ratandeep Ratti. Bugs: HIVE-17394

Re: Review Request 60303: HIVE-16908: Update table and partition replication tests to not use 2nd HCat instance

2017-06-22 Thread Anthony Hsu via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60303/#review178710 ---

Re: Review Request 59885: HIVE-16844: Fix Connection leak in ObjectStore when new Conf object is used

2017-06-08 Thread Anthony Hsu via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59885/#review177432 --- Ship it! Looks good to me. - Anthony Hsu On 六月 7, 2017,

Re: Review Request 59885: HIVE-16844: Fix Connection leak in ObjectStore when new Conf object is used

2017-06-08 Thread Anthony Hsu via Review Board
> On 六月 7, 2017, 8:45 p.m., Anthony Hsu wrote: > > metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java > > Line 302 (original), 304 (patched) > > > > > > Do we need to close the PersistenceManager

Re: Review Request 59867: HIVE-16831: Add unit tests for NPE fixes in HIVE-12054

2017-06-07 Thread Anthony Hsu via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59867/#review177223 --- Ship it! Looks good to me! - Anthony Hsu On 六月 6, 2017,

Re: Review Request 59885: HIVE-16844: Fix Connection leak in ObjectStore when new Conf object is used

2017-06-07 Thread Anthony Hsu via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59885/#review177222 ---

Review Request 59303: HIVE-16670: Hive should automatically clean up hive.downloaded.resources.dir

2017-05-15 Thread Anthony Hsu via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59303/ --- Review request for hive. Bugs: HIVE-16670