Review Request 36086: Removed LazyBinaryUtil dependency for DateWritable by porting byte -- int logic.

2015-07-01 Thread Nishant Kelkar
6cedf4c88dc07926aa5f15d657daeaea2156e58c serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinaryDate.java d0c2504ba529803be2880dcbb440ef8cdce1590a Diff: https://reviews.apache.org/r/36086/diff/ Testing --- Thanks, Nishant Kelkar

Re: Review Request 35968: 1. Added preliminary UDF code for cosine similarity. 2. Added unit tests and integration tests. 3. Registered the UDF in the FunctionRegistry class.

2015-06-29 Thread Nishant Kelkar
is: cosine_similarity(Text, Text, Text) Each Text can be one of {S=something,E=empty,N=null} Unit tests written for the following cases: 1. cosine_similarity(S, S, S) 2. cosine_similarity(S, E, S) 3. cosine_similarity(N, E, S) 4. cosine_similarity(S, S, E) 5. cosine_similarity(N, N, N) Thanks, Nishant

Re: Review Request 35968: 1. Added preliminary UDF code for cosine similarity. 2. Added unit tests and integration tests. 3. Registered the UDF in the FunctionRegistry class.

2015-06-29 Thread Nishant Kelkar
(line 4) https://reviews.apache.org/r/35968/#comment142597 Oh, sorry didn't read well. You mean math3. Yes, you're right about this. Moving to use {code} Math.pow(double, double) {code} instead. - Nishant Kelkar On June 28, 2015, 11:39 a.m., Nishant Kelkar wrote

Re: Review Request 35968: 1. Added preliminary UDF code for cosine similarity. 2. Added unit tests and integration tests. 3. Registered the UDF in the FunctionRegistry class.

2015-06-28 Thread Nishant Kelkar
/java/org/apache/hadoop/hive/ql/udf/UDFCosineSimilarity.java (line 122) https://reviews.apache.org/r/35968/#comment142338 These still throw HiveException, but I've included all of the code in evaluate() in try/catch, and catch returns null. - Nishant Kelkar On June 28, 2015, 11:22 a.m

Re: Review Request 35968: 1. Added preliminary UDF code for cosine similarity. 2. Added unit tests and integration tests. 3. Registered the UDF in the FunctionRegistry class.

2015-06-28 Thread Nishant Kelkar
/udf_cosine_similarity_wrongargs_3.q.out PRE-CREATION ql/src/test/results/clientpositive/show_functions.q.out 5de4ffcd1ace477af026b83fb7bfb8068fc192b3 ql/src/test/results/clientpositive/udf_cosine_similarity.q.out PRE-CREATION Diff: https://reviews.apache.org/r/35968/diff/ Testing --- Thanks, Nishant

Re: Review Request 35968: 1. Added preliminary UDF code for cosine similarity. 2. Added unit tests and integration tests. 3. Registered the UDF in the FunctionRegistry class.

2015-06-28 Thread Nishant Kelkar
, Nishant Kelkar

[jira] [Created] (HIVE-11136) Unused Logger in org.apache.hadoop.hive.ql.udf.generic.GenericUDAFCount

2015-06-28 Thread Nishant Kelkar (JIRA)
Nishant Kelkar created HIVE-11136: - Summary: Unused Logger in org.apache.hadoop.hive.ql.udf.generic.GenericUDAFCount Key: HIVE-11136 URL: https://issues.apache.org/jira/browse/HIVE-11136 Project

Re: Review Request 35968: 1. Added preliminary UDF code for cosine similarity. 2. Added unit tests and integration tests. 3. Registered the UDF in the FunctionRegistry class.

2015-06-28 Thread Nishant Kelkar
/show_functions.q.out 5de4ffcd1ace477af026b83fb7bfb8068fc192b3 ql/src/test/results/clientpositive/udf_cosine_similarity.q.out PRE-CREATION Diff: https://reviews.apache.org/r/35968/diff/ Testing --- Thanks, Nishant Kelkar

Re: Review Request 35968: 1. Added preliminary UDF code for cosine similarity. 2. Added unit tests and integration tests. 3. Registered the UDF in the FunctionRegistry class.

2015-06-28 Thread Nishant Kelkar
to, to be backwards compatible with people compiling with Java 1.6. ql/src/java/org/apache/hadoop/hive/ql/udf/UDFCosineSimilarity.java (line 109) https://reviews.apache.org/r/35968/#comment142320 Do we usually log such edge cases in Hive? If yes, I could add a slf4j logger to this UDF. - Nishant Kelkar

Review Request 35968: 1. Added preliminary UDF code for cosine similarity. 2. Added unit tests and integration tests. 3. Registered the UDF in the FunctionRegistry class.

2015-06-27 Thread Nishant Kelkar
, Nishant Kelkar

[jira] [Created] (HIVE-11114) Documentation of Pentaho Missing from Maven Central

2015-06-25 Thread Nishant Kelkar (JIRA)
Nishant Kelkar created HIVE-4: - Summary: Documentation of Pentaho Missing from Maven Central Key: HIVE-4 URL: https://issues.apache.org/jira/browse/HIVE-4 Project: Hive Issue

Re: Cloning Hive Trunk: HadoopArchives Dependency Not Found

2015-06-24 Thread Nishant Kelkar
Hmm, so I just ran the same command with 'mvn clean compile -Phadoop-1' and 'mvn clean compile -Phadoop-2' and they seem to work. Thanks @all! I guess this wasn't an issue. :) Thanks and Regards, Nishant Kelkar On Wed, Jun 24, 2015 at 1:59 AM, Nishant Kelkar nishant@gmail.com wrote: Hi

Re: Cloning Hive Trunk: HadoopArchives Dependency Not Found

2015-06-24 Thread Nishant Kelkar
compile' and seeing everything pass and build with success. Best Regards, Nishant Kelkar

[jira] [Updated] (HIVE-8642) Hive stack() UDTF Doesn't Support NULL Insert Values

2014-10-29 Thread Nishant Kelkar (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-8642?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nishant Kelkar updated HIVE-8642: - Summary: Hive stack() UDTF Doesn't Support NULL Insert Values (was: Hive stack() Method Doesn't

[jira] [Commented] (HIVE-8642) Hive stack() UDTF Doesn't Support NULL Insert Values

2014-10-29 Thread Nishant Kelkar (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-8642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14188151#comment-14188151 ] Nishant Kelkar commented on HIVE-8642: -- Stack trace for the exception: {code} 2014-10

[jira] [Commented] (HIVE-8642) Hive stack() UDTF Doesn't Support NULL Insert Values

2014-10-29 Thread Nishant Kelkar (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-8642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14188209#comment-14188209 ] Nishant Kelkar commented on HIVE-8642: -- Thanks [~navis]! This solves my problem

[jira] [Created] (HIVE-8642) Hive stack() Method Doesn't Support NULL Insert Values

2014-10-28 Thread Nishant Kelkar (JIRA)
Nishant Kelkar created HIVE-8642: Summary: Hive stack() Method Doesn't Support NULL Insert Values Key: HIVE-8642 URL: https://issues.apache.org/jira/browse/HIVE-8642 Project: Hive Issue Type

[jira] [Commented] (HIVE-8642) Hive stack() Method Doesn't Support NULL Insert Values

2014-10-28 Thread Nishant Kelkar (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-8642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14187864#comment-14187864 ] Nishant Kelkar commented on HIVE-8642: -- Pardon me if I've missed out on any details

[jira] [Created] (HIVE-7181) Beginner User On Apache Jira

2014-06-05 Thread Nishant Kelkar (JIRA)
Nishant Kelkar created HIVE-7181: Summary: Beginner User On Apache Jira Key: HIVE-7181 URL: https://issues.apache.org/jira/browse/HIVE-7181 Project: Hive Issue Type: Wish

[jira] [Commented] (HIVE-7181) Beginner User On Apache Jira

2014-06-05 Thread Nishant Kelkar (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-7181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14019393#comment-14019393 ] Nishant Kelkar commented on HIVE-7181: -- [~leftylev], thanks so much! These links