Re: Review Request 72113: DML execution on TEZ always outputs the message 'No rows affected'

2020-02-14 Thread Panos Garefalakis via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72113/#review219591 --- Ship it! +1 from me as well As discussed the extra 0s in the

Re: Review Request 71871: StringIndexOutOfBoundsException when getting sessionId from worker node name

2019-12-05 Thread Panos Garefalakis via Review Board
> On Dec. 5, 2019, 4:43 p.m., Panos Garefalakis wrote: > > llap-client/src/java/org/apache/hadoop/hive/registry/impl/ZkRegistryBase.java > > Lines 478 (patched) > > > > > > Hey Attila, > > > > With Java's

Re: Review Request 71871: StringIndexOutOfBoundsException when getting sessionId from worker node name

2019-12-05 Thread Panos Garefalakis via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71871/#review218941 ---

Re: Review Request 71845: ConcurrentModificationException in TriggerValidatorRunnable stops trigger processing

2019-12-02 Thread Panos Garefalakis via Review Board
> On Dec. 2, 2019, 12:43 p.m., Panos Garefalakis wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPoolManager.java > > Line 533 (original), 533 (patched) > > > > > > Hey Attila, > > > >

Re: Review Request 71845: ConcurrentModificationException in TriggerValidatorRunnable stops trigger processing

2019-12-02 Thread Panos Garefalakis via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71845/#review218875 ---

Re: Review Request 71784: HiveProtoLoggingHook might leak memory

2019-11-19 Thread Panos Garefalakis via Review Board
> On Nov. 19, 2019, 10:24 p.m., Panos Garefalakis wrote: > > ql/src/java/org/apache/hadoop/hive/ql/hooks/HiveProtoLoggingHook.java > > Lines 192 (patched) > > > > > > The solution makes sense to me, however maybe we

Re: Review Request 71784: HiveProtoLoggingHook might leak memory

2019-11-19 Thread Panos Garefalakis via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71784/#review218694 ---

Re: Review Request 71707: Performance degradation on single row inserts

2019-11-05 Thread Panos Garefalakis via Review Board
> On Nov. 5, 2019, 4:33 p.m., Panos Garefalakis wrote: > > standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/utils/FileUtils.java > > Lines 328 (patched) > > > > > > Hey Attila,

Re: Review Request 71707: Performance degradation on single row inserts

2019-11-05 Thread Panos Garefalakis via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71707/#review218505 ---