[jira] [Created] (HIVE-24880) Add host and version information to compection queue

2021-03-12 Thread Peter Varga (Jira)
Peter Varga created HIVE-24880: -- Summary: Add host and version information to compection queue Key: HIVE-24880 URL: https://issues.apache.org/jira/browse/HIVE-24880 Project: Hive Issue Type

[jira] [Created] (HIVE-24825) Create AcidMetricsService

2021-02-24 Thread Peter Varga (Jira)
Peter Varga created HIVE-24825: -- Summary: Create AcidMetricsService Key: HIVE-24825 URL: https://issues.apache.org/jira/browse/HIVE-24825 Project: Hive Issue Type: Sub-task Reporter

[jira] [Created] (HIVE-24824) Define metrics for compaction observability

2021-02-24 Thread Peter Varga (Jira)
Peter Varga created HIVE-24824: -- Summary: Define metrics for compaction observability Key: HIVE-24824 URL: https://issues.apache.org/jira/browse/HIVE-24824 Project: Hive Issue Type: Improvement

[jira] [Created] (HIVE-24785) Fix HIVE_COMPACTOR_COMPACT_MM property

2021-02-16 Thread Peter Varga (Jira)
Peter Varga created HIVE-24785: -- Summary: Fix HIVE_COMPACTOR_COMPACT_MM property Key: HIVE-24785 URL: https://issues.apache.org/jira/browse/HIVE-24785 Project: Hive Issue Type: Bug

[jira] [Created] (HIVE-24738) Reuse committed filelist from directInsert manifest during loadPartition

2021-02-04 Thread Peter Varga (Jira)
Peter Varga created HIVE-24738: -- Summary: Reuse committed filelist from directInsert manifest during loadPartition Key: HIVE-24738 URL: https://issues.apache.org/jira/browse/HIVE-24738 Project: Hive

[jira] [Created] (HIVE-24682) Collect dynamic partition info in FileSink for direct insert and reuse it in Movetask

2021-01-25 Thread Peter Varga (Jira)
Peter Varga created HIVE-24682: -- Summary: Collect dynamic partition info in FileSink for direct insert and reuse it in Movetask Key: HIVE-24682 URL: https://issues.apache.org/jira/browse/HIVE-24682

[jira] [Created] (HIVE-24679) Reuse FullDPSpecs in loadDynamicPartitions to avoid double listing

2021-01-22 Thread Peter Varga (Jira)
Peter Varga created HIVE-24679: -- Summary: Reuse FullDPSpecs in loadDynamicPartitions to avoid double listing Key: HIVE-24679 URL: https://issues.apache.org/jira/browse/HIVE-24679 Project: Hive

[jira] [Created] (HIVE-24669) Improve Filesystem usage in Hive::loadPartitionInternal

2021-01-20 Thread Peter Varga (Jira)
Peter Varga created HIVE-24669: -- Summary: Improve Filesystem usage in Hive::loadPartitionInternal Key: HIVE-24669 URL: https://issues.apache.org/jira/browse/HIVE-24669 Project: Hive Issue Type

[jira] [Created] (HIVE-24668) Improve FileSystem usage in dynamic partition handling

2021-01-20 Thread Peter Varga (Jira)
Peter Varga created HIVE-24668: -- Summary: Improve FileSystem usage in dynamic partition handling Key: HIVE-24668 URL: https://issues.apache.org/jira/browse/HIVE-24668 Project: Hive Issue Type

[jira] [Created] (HIVE-24655) Improve FileSystem usage in OrcRawRecordMerger

2021-01-19 Thread Peter Varga (Jira)
Peter Varga created HIVE-24655: -- Summary: Improve FileSystem usage in OrcRawRecordMerger Key: HIVE-24655 URL: https://issues.apache.org/jira/browse/HIVE-24655 Project: Hive Issue Type

[jira] [Created] (HIVE-24643) Access Operation state directly where possible

2021-01-15 Thread Peter Varga (Jira)
Peter Varga created HIVE-24643: -- Summary: Access Operation state directly where possible Key: HIVE-24643 URL: https://issues.apache.org/jira/browse/HIVE-24643 Project: Hive Issue Type

[jira] [Created] (HIVE-24630) clean up multiple parseDelta implementation in AcidUtils

2021-01-13 Thread Peter Varga (Jira)
Peter Varga created HIVE-24630: -- Summary: clean up multiple parseDelta implementation in AcidUtils Key: HIVE-24630 URL: https://issues.apache.org/jira/browse/HIVE-24630 Project: Hive Issue Type

[jira] [Created] (HIVE-24615) Remove unnecessary FileSystem listing from Initiator

2021-01-11 Thread Peter Varga (Jira)
Peter Varga created HIVE-24615: -- Summary: Remove unnecessary FileSystem listing from Initiator Key: HIVE-24615 URL: https://issues.apache.org/jira/browse/HIVE-24615 Project: Hive Issue Type

[jira] [Created] (HIVE-24602) Retry compaction after configured time

2021-01-07 Thread Peter Varga (Jira)
Peter Varga created HIVE-24602: -- Summary: Retry compaction after configured time Key: HIVE-24602 URL: https://issues.apache.org/jira/browse/HIVE-24602 Project: Hive Issue Type: Improvement

[jira] [Created] (HIVE-24581) Remove AcidUtils call from OrcInputformat for non transactional tables

2021-01-04 Thread Peter Varga (Jira)
Peter Varga created HIVE-24581: -- Summary: Remove AcidUtils call from OrcInputformat for non transactional tables Key: HIVE-24581 URL: https://issues.apache.org/jira/browse/HIVE-24581 Project: Hive

[jira] [Created] (HIVE-24548) CompactionHeartbeater leaks metastore connections

2020-12-16 Thread Peter Varga (Jira)
Peter Varga created HIVE-24548: -- Summary: CompactionHeartbeater leaks metastore connections Key: HIVE-24548 URL: https://issues.apache.org/jira/browse/HIVE-24548 Project: Hive Issue Type: Bug

[jira] [Created] (HIVE-24535) Cleanup AcidUtils.Directory and remove unnecessary filesystem listings

2020-12-14 Thread Peter Varga (Jira)
Peter Varga created HIVE-24535: -- Summary: Cleanup AcidUtils.Directory and remove unnecessary filesystem listings Key: HIVE-24535 URL: https://issues.apache.org/jira/browse/HIVE-24535 Project: Hive

[jira] [Created] (HIVE-24516) Txnhandler onrename might ignore exceptions

2020-12-10 Thread Peter Varga (Jira)
Peter Varga created HIVE-24516: -- Summary: Txnhandler onrename might ignore exceptions Key: HIVE-24516 URL: https://issues.apache.org/jira/browse/HIVE-24516 Project: Hive Issue Type: Bug

[jira] [Created] (HIVE-24481) Skipped compaction can cause data corruption with streaming

2020-12-03 Thread Peter Varga (Jira)
Peter Varga created HIVE-24481: -- Summary: Skipped compaction can cause data corruption with streaming Key: HIVE-24481 URL: https://issues.apache.org/jira/browse/HIVE-24481 Project: Hive Issue

[jira] [Created] (HIVE-24477) Separate production and test code in TxnDbUtil

2020-12-03 Thread Peter Varga (Jira)
Peter Varga created HIVE-24477: -- Summary: Separate production and test code in TxnDbUtil Key: HIVE-24477 URL: https://issues.apache.org/jira/browse/HIVE-24477 Project: Hive Issue Type

[jira] [Created] (HIVE-24403) change min_history_level schema change to be compatible with previous version

2020-11-17 Thread Peter Varga (Jira)
Peter Varga created HIVE-24403: -- Summary: change min_history_level schema change to be compatible with previous version Key: HIVE-24403 URL: https://issues.apache.org/jira/browse/HIVE-24403 Project

[jira] [Created] (HIVE-24401) COMPACTOR_CRUD_QUERY_BASED description in HiveConf is outdated

2020-11-17 Thread Peter Varga (Jira)
Peter Varga created HIVE-24401: -- Summary: COMPACTOR_CRUD_QUERY_BASED description in HiveConf is outdated Key: HIVE-24401 URL: https://issues.apache.org/jira/browse/HIVE-24401 Project: Hive

Re: Result of the TPC-DS benchmark on Hive master branch

2020-11-14 Thread Peter Varga
Hi Sungwoo, The query 14 result changed because of HIVE-24233 But this SemanticException is thrown to avoid the Nullpointer in SemanticAnalyzer, the root cause is still the cbo failure before, I guess with the same exception as was in your previous test run. Peter On Fri, Nov 13, 2020 at 6:56 PM

[jira] [Created] (HIVE-24329) Add HMS notification for compaction commit

2020-10-29 Thread Peter Varga (Jira)
Peter Varga created HIVE-24329: -- Summary: Add HMS notification for compaction commit Key: HIVE-24329 URL: https://issues.apache.org/jira/browse/HIVE-24329 Project: Hive Issue Type: New Feature

[jira] [Created] (HIVE-24291) Compaction Cleaner prematurely cleans up deltas

2020-10-20 Thread Peter Varga (Jira)
Peter Varga created HIVE-24291: -- Summary: Compaction Cleaner prematurely cleans up deltas Key: HIVE-24291 URL: https://issues.apache.org/jira/browse/HIVE-24291 Project: Hive Issue Type: Bug

[jira] [Created] (HIVE-24233) except subquery throws nullpointer with cbo disabled

2020-10-05 Thread Peter Varga (Jira)
Peter Varga created HIVE-24233: -- Summary: except subquery throws nullpointer with cbo disabled Key: HIVE-24233 URL: https://issues.apache.org/jira/browse/HIVE-24233 Project: Hive Issue Type

[jira] [Created] (HIVE-24219) TestStreaming is flaky

2020-10-01 Thread Peter Varga (Jira)
Peter Varga created HIVE-24219: -- Summary: TestStreaming is flaky Key: HIVE-24219 URL: https://issues.apache.org/jira/browse/HIVE-24219 Project: Hive Issue Type: Bug Reporter: Peter

[jira] [Created] (HIVE-24162) Query based compaction looses bloom filter

2020-09-14 Thread Peter Varga (Jira)
Peter Varga created HIVE-24162: -- Summary: Query based compaction looses bloom filter Key: HIVE-24162 URL: https://issues.apache.org/jira/browse/HIVE-24162 Project: Hive Issue Type: Bug

[jira] [Created] (HIVE-23994) TestRetryable is unstable

2020-08-05 Thread Peter Varga (Jira)
Peter Varga created HIVE-23994: -- Summary: TestRetryable is unstable Key: HIVE-23994 URL: https://issues.apache.org/jira/browse/HIVE-23994 Project: Hive Issue Type: Bug Reporter

[jira] [Created] (HIVE-23956) Delete delta directory file information should be pushed to execution side

2020-07-30 Thread Peter Varga (Jira)
Peter Varga created HIVE-23956: -- Summary: Delete delta directory file information should be pushed to execution side Key: HIVE-23956 URL: https://issues.apache.org/jira/browse/HIVE-23956 Project: Hive

[jira] [Created] (HIVE-23837) HbaseStorageHandler is not configured properly when the FileSinkOperator is the child of a MergeJoinWork

2020-07-13 Thread Peter Varga (Jira)
Peter Varga created HIVE-23837: -- Summary: HbaseStorageHandler is not configured properly when the FileSinkOperator is the child of a MergeJoinWork Key: HIVE-23837 URL: https://issues.apache.org/jira/browse/HIVE

[jira] [Created] (HIVE-23819) Use ranges in ValidReadTxnList serialization

2020-07-08 Thread Peter Varga (Jira)
Peter Varga created HIVE-23819: -- Summary: Use ranges in ValidReadTxnList serialization Key: HIVE-23819 URL: https://issues.apache.org/jira/browse/HIVE-23819 Project: Hive Issue Type

[jira] [Created] (HIVE-23762) TestPigHBaseStorageHandler tests are flaky

2020-06-25 Thread Peter Varga (Jira)
Peter Varga created HIVE-23762: -- Summary: TestPigHBaseStorageHandler tests are flaky Key: HIVE-23762 URL: https://issues.apache.org/jira/browse/HIVE-23762 Project: Hive Issue Type: Bug

[jira] [Created] (HIVE-23725) ValidTxnManager snapshot outdating causing partial reads in merge inserst

2020-06-19 Thread Peter Varga (Jira)
Peter Varga created HIVE-23725: -- Summary: ValidTxnManager snapshot outdating causing partial reads in merge inserst Key: HIVE-23725 URL: https://issues.apache.org/jira/browse/HIVE-23725 Project: Hive

[jira] [Created] (HIVE-23715) Fix zookeeper ssl keystore password handling issues

2020-06-17 Thread Peter Varga (Jira)
Peter Varga created HIVE-23715: -- Summary: Fix zookeeper ssl keystore password handling issues Key: HIVE-23715 URL: https://issues.apache.org/jira/browse/HIVE-23715 Project: Hive Issue Type: Bug

[jira] [Created] (HIVE-23671) MSCK repair should handle transactional tables in certain usecases

2020-06-10 Thread Peter Varga (Jira)
Peter Varga created HIVE-23671: -- Summary: MSCK repair should handle transactional tables in certain usecases Key: HIVE-23671 URL: https://issues.apache.org/jira/browse/HIVE-23671 Project: Hive

Re: Review Request 72532: HIVE-23495 AcidUtils.getAcidState cleanup

2020-06-08 Thread Peter Varga via Review Board
dUtils.java > > Line 1937 (original), 1880 (patched) > > <https://reviews.apache.org/r/72532/diff/2/?file=2232788#file2232788line1997> > > > > Does this need to be public? fixed - Peter ------- This is an automatically generated e-mail. To reply, visit: https://

Re: Review Request 72532: HIVE-23495 AcidUtils.getAcidState cleanup

2020-06-08 Thread Peter Varga via Review Board
/diff/3/ Changes: https://reviews.apache.org/r/72532/diff/2-3/ Testing --- Thanks, Peter Varga

Re: Review Request 72528: ValidTxnManager doesn't consider txns opened and committed between snapshot generation and locking when evaluating ValidTxnListState

2020-06-08 Thread Peter Varga via Review Board
> On May 20, 2020, 3:16 p.m., Peter Varga wrote: > > ql/src/java/org/apache/hadoop/hive/ql/Driver.java > > Lines 686 (patched) > > <https://reviews.apache.org/r/72528/diff/1/?file=2232587#file2232587line686> > > > > I have concerns here, but I am not su

Re: Review Request 72488: HIVE-23413: New config to skip all locks

2020-06-03 Thread Peter Varga via Review Board
/ql/lockmgr/TestDbTxnManager2.java 8a15b7cc5d Diff: https://reviews.apache.org/r/72488/diff/2/ Changes: https://reviews.apache.org/r/72488/diff/1-2/ Testing --- Thanks, Peter Varga

Re: Review Request 72488: HIVE-23413: New config to skip all locks

2020-06-03 Thread Peter Varga via Review Board
ps://reviews.apache.org/r/72488/#review220947 ------- On June 3, 2020, 9:20 a.m., Peter Varga wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 72532: HIVE-23495 AcidUtils.getAcidState cleanup

2020-05-21 Thread Peter Varga via Review Board
/apache/hadoop/hive/ql/io/orc/TestOrcRawRecordMerger.java f63c40a7b5 streaming/src/test/org/apache/hive/streaming/TestStreaming.java 6101caac66 Diff: https://reviews.apache.org/r/72532/diff/2/ Changes: https://reviews.apache.org/r/72532/diff/1-2/ Testing --- Thanks, Peter Varga

Re: Review Request 72528: ValidTxnManager doesn't consider txns opened and committed between snapshot generation and locking when evaluating ValidTxnListState

2020-05-20 Thread Peter Varga via Review Board
> On May 20, 2020, 3:16 p.m., Peter Varga wrote: > > ql/src/java/org/apache/hadoop/hive/ql/Driver.java > > Lines 686 (patched) > > <https://reviews.apache.org/r/72528/diff/1/?file=2232587#file2232587line686> > > > > I have concerns here, but I am not su

Review Request 72532: HIVE-23495 AcidUtils.getAcidState cleanup

2020-05-20 Thread Peter Varga via Review Board
/TestOrcRawRecordMerger.java f63c40a7b5 streaming/src/test/org/apache/hive/streaming/TestStreaming.java 6101caac66 Diff: https://reviews.apache.org/r/72532/diff/1/ Testing --- Thanks, Peter Varga

Re: Review Request 72528: ValidTxnManager doesn't consider txns opened and committed between snapshot generation and locking when evaluating ValidTxnListState

2020-05-20 Thread Peter Varga via Review Board
he snapshot isolation. - Peter Varga On May 19, 2020, 11:19 a.m., Denys Kuzmenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://rev

Re: Review Request 72480: HIVE-23242 Fix flaky tests testHouseKeepingThreadExistence

2020-05-20 Thread Peter Varga via Review Board
0e2c35acaa Diff: https://reviews.apache.org/r/72480/diff/3/ Changes: https://reviews.apache.org/r/72480/diff/2-3/ Testing --- Thanks, Peter Varga

Re: Review Request 72480: HIVE-23242 Fix flaky tests testHouseKeepingThreadExistence

2020-05-20 Thread Peter Varga via Review Board
This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72480/#review220824 --- On May 20, 2020, 2:03 p.m., Peter Varga wrote: > > -

Re: Review Request 72465: HIVE-23340 TxnHandler cleanup

2020-05-20 Thread Peter Varga via Review Board
/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnStatus.java PRE-CREATION Diff: https://reviews.apache.org/r/72465/diff/4/ Changes: https://reviews.apache.org/r/72465/diff/3-4/ Testing --- Thanks, Peter Varga

Re: Review Request 72465: HIVE-23340 TxnHandler cleanup

2020-05-20 Thread Peter Varga via Review Board
cessary switch between the two representation. - Peter --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72465/#review220802 ------- On May 7, 2020, 11:58 a.m., Peter Varga wrote: > > --

[jira] [Created] (HIVE-23495) AcidUtils.getAcidState cleanup

2020-05-18 Thread Peter Varga (Jira)
Peter Varga created HIVE-23495: -- Summary: AcidUtils.getAcidState cleanup Key: HIVE-23495 URL: https://issues.apache.org/jira/browse/HIVE-23495 Project: Hive Issue Type: Improvement

Review Request 72488: HIVE-23413: New config to skip all locks

2020-05-11 Thread Peter Varga via Review Board
f/1/ Testing --- Thanks, Peter Varga

[jira] [Created] (HIVE-23413) Create a new config to skip all locks

2020-05-08 Thread Peter Varga (Jira)
Peter Varga created HIVE-23413: -- Summary: Create a new config to skip all locks Key: HIVE-23413 URL: https://issues.apache.org/jira/browse/HIVE-23413 Project: Hive Issue Type: Improvement

Re: Review Request 72480: HIVE-23242 Fix flaky tests testHouseKeepingThreadExistence

2020-05-08 Thread Peter Varga via Review Board
2702e69f86 Diff: https://reviews.apache.org/r/72480/diff/2/ Changes: https://reviews.apache.org/r/72480/diff/1-2/ Testing --- Thanks, Peter Varga

[jira] [Created] (HIVE-23392) Metastore upgrade script TXN_LOCK_TBL rename inconsistency

2020-05-07 Thread Peter Varga (Jira)
Peter Varga created HIVE-23392: -- Summary: Metastore upgrade script TXN_LOCK_TBL rename inconsistency Key: HIVE-23392 URL: https://issues.apache.org/jira/browse/HIVE-23392 Project: Hive Issue

Re: Review Request 72465: HIVE-23340 TxnHandler cleanup

2020-05-07 Thread Peter Varga via Review Board
ric txn object (i.e TxnInfo)? I don't think TxnUtils is a > > good place for domain objects. > > Peter Varga wrote: > I didn't really know which way to go. The TxnInfo is missing the type > field and I did not want to change the api. > The tables used b

Re: Review Request 72465: HIVE-23340 TxnHandler cleanup

2020-05-07 Thread Peter Varga via Review Board
/metastore/txn/TxnStatus.java PRE-CREATION Diff: https://reviews.apache.org/r/72465/diff/3/ Changes: https://reviews.apache.org/r/72465/diff/2-3/ Testing --- Thanks, Peter Varga

Review Request 72480: HIVE-23242 Fix flaky tests testHouseKeepingThreadExistence

2020-05-07 Thread Peter Varga via Review Board
/TestMetastoreHousekeepingNonLeader.java 0341d3c03b Diff: https://reviews.apache.org/r/72480/diff/1/ Testing --- Thanks, Peter Varga

Re: Review Request 72470: ACID: Concurrent MERGE INSERT operations produce duplicates

2020-05-05 Thread Peter Varga via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72470/#review220631 --- Ship it! Ship It! - Peter Varga On May 5, 2020, 8:33 a.m

Re: Review Request 72465: HIVE-23340 TxnHandler cleanup

2020-05-05 Thread Peter Varga via Review Board
e-mail. To reply, visit: https://reviews.apache.org/r/72465/#review220593 ------- On May 4, 2020, 1:22 p.m., Peter Varga wrote: > > --- > This is an automatically ge

Re: Review Request 72470: ACID: Concurrent MERGE INSERT operations produce duplicates

2020-05-05 Thread Peter Varga via Review Board
/hive/ql/Context.java Lines 1198 (patched) <https://reviews.apache.org/r/72470/#comment309189> Do you need a separate field for that, you could just check the operation type? - Peter Varga On May 4, 2020, 4:33 p.m., Denys Kuzmenko

Re: Review Request 72465: HIVE-23340 TxnHandler cleanup

2020-05-04 Thread Peter Varga via Review Board
/TxnUtils.java 4ee1a45aae Diff: https://reviews.apache.org/r/72465/diff/2/ Changes: https://reviews.apache.org/r/72465/diff/1-2/ Testing --- Thanks, Peter Varga

Review Request 72465: HIVE-23340 TxnHandler cleanup

2020-05-04 Thread Peter Varga via Review Board
--- Thanks, Peter Varga

[jira] [Created] (HIVE-23341) Merge HMS ACID related calls to improve performance

2020-04-30 Thread Peter Varga (Jira)
Peter Varga created HIVE-23341: -- Summary: Merge HMS ACID related calls to improve performance Key: HIVE-23341 URL: https://issues.apache.org/jira/browse/HIVE-23341 Project: Hive Issue Type

[jira] [Created] (HIVE-23340) TxnHandler cleanup

2020-04-30 Thread Peter Varga (Jira)
Peter Varga created HIVE-23340: -- Summary: TxnHandler cleanup Key: HIVE-23340 URL: https://issues.apache.org/jira/browse/HIVE-23340 Project: Hive Issue Type: Improvement Reporter

Re: Review Request 72388: HIVE-23048 Use sequences for TXN_ID generation

2020-04-28 Thread Peter Varga via Review Board
-CREATION Diff: https://reviews.apache.org/r/72388/diff/6/ Changes: https://reviews.apache.org/r/72388/diff/5-6/ Testing --- Thanks, Peter Varga

Re: Review Request 72388: HIVE-23048 Use sequences for TXN_ID generation

2020-04-28 Thread Peter Varga via Review Board
0500 ------- On April 24, 2020, 3:40 p.m., Peter Varga wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72388/ &

[jira] [Created] (HIVE-23311) Fix ValidTxnManager regression

2020-04-28 Thread Peter Varga (Jira)
Peter Varga created HIVE-23311: -- Summary: Fix ValidTxnManager regression Key: HIVE-23311 URL: https://issues.apache.org/jira/browse/HIVE-23311 Project: Hive Issue Type: Bug Components

Re: Review Request 72388: HIVE-23048 Use sequences for TXN_ID generation

2020-04-24 Thread Peter Varga via Review Board
This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72388/#review220487 ------- On April 24, 2020, 3:40 p.m., Peter Varga wrote: > >

Re: Review Request 72388: HIVE-23048 Use sequences for TXN_ID generation

2020-04-24 Thread Peter Varga via Review Board
m., Denys Kuzmenko wrote: > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java > > Lines 891 (patched) > > <https://reviews.apache.org/r/72388/diff/4/?file=2227465#file2227465line957> > > > > redund

Re: Review Request 72388: HIVE-23048 Use sequences for TXN_ID generation

2020-04-24 Thread Peter Varga via Review Board
/Oracle.java 0b070e19ac standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/txn/TestOpenTxn.java PRE-CREATION Diff: https://reviews.apache.org/r/72388/diff/5/ Changes: https://reviews.apache.org/r/72388/diff/4-5/ Testing --- Thanks, Peter Varga

Re: Review Request 72388: HIVE-23048 Use sequences for TXN_ID generation

2020-04-23 Thread Peter Varga via Review Board
/hadoop/hive/metastore/txn/TestOpenTxn.java PRE-CREATION Diff: https://reviews.apache.org/r/72388/diff/4/ Changes: https://reviews.apache.org/r/72388/diff/3-4/ Testing --- Thanks, Peter Varga

Re: Review Request 72388: HIVE-23048 Use sequences for TXN_ID generation

2020-04-21 Thread Peter Varga via Review Board
> > > > Can it be null? Could we add constraint on db level instead of multiple > > checks in backend code? > > Peter Varga wrote: > It should not be null, but the constraint is that there must be always > one record in the table, not a nonnull column. >

Re: Review Request 72388: HIVE-23048 Use sequences for TXN_ID generation

2020-04-21 Thread Peter Varga via Review Board
> > > > openTxns(dbConn, stmt, rqst) is used in replTableWriteIdState as well. > > Do we have to check there for timeout as well? > > Peter Varga wrote: > This is an alarming catch. What kind of queries run on a replication. I > put there the table lock, but it

Re: Review Request 72388: HIVE-23048 Use sequences for TXN_ID generation

2020-04-21 Thread Peter Varga via Review Board
/Oracle.java 0b070e19ac standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/txn/TestOpenTxn.java PRE-CREATION Diff: https://reviews.apache.org/r/72388/diff/3/ Changes: https://reviews.apache.org/r/72388/diff/2-3/ Testing --- Thanks, Peter Varga

Re: Review Request 72380: HIVE-23207 Create integration tests for TxnManager for different rdbms metastores

2020-04-21 Thread Peter Varga via Review Board
eviews.apache.org/r/72380/#review220352 --- On April 21, 2020, 10:22 a.m., Peter Varga wrote: > > --- > This is an automatically generated e-mail. To re

Re: Review Request 72388: HIVE-23048 Use sequences for TXN_ID generation

2020-04-21 Thread Peter Varga via Review Board
> > > > Can it be null? Could we add constraint on db level instead of multiple > > checks in backend code? > > Peter Varga wrote: > It should not be null, but the constraint is that there must be always > one record in the table, not a nonnull column. >

Re: Review Request 72380: HIVE-23207 Create integration tests for TxnManager for different rdbms metastores

2020-04-21 Thread Peter Varga via Review Board
machine the 50 tests in TestDbTxnManager2 on postgres runs under 5 minutes. Thanks, Peter Varga

Re: Review Request 72388: HIVE-23048 Use sequences for TXN_ID generation

2020-04-21 Thread Peter Varga via Review Board
/Oracle.java 0b070e19ac standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/txn/TestOpenTxn.java PRE-CREATION Diff: https://reviews.apache.org/r/72388/diff/2/ Changes: https://reviews.apache.org/r/72388/diff/1-2/ Testing --- Thanks, Peter Varga

Re: Review Request 72388: HIVE-23048 Use sequences for TXN_ID generation

2020-04-21 Thread Peter Varga via Review Board
; > > This is again a single query implemented with 3 SQL query and a java > > code. Am I right? Yes, however it is a backgroung method. Does it worth to sacrifice the easier logging and debugging for some performance gain? - Peter

Re: Review Request 72388: HIVE-23048 Use sequences for TXN_ID generation

2020-04-21 Thread Peter Varga via Review Board
a nonnull column. - Peter --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72388/#review220367 --- On April 20,

Review Request 72388: HIVE-23048 Use sequences for TXN_ID generation

2020-04-20 Thread Peter Varga via Review Board
://reviews.apache.org/r/72388/diff/1/ Testing --- Thanks, Peter Varga

Re: Review Request 72380: HIVE-23207 Create integration tests for TxnManager for different rdbms metastores

2020-04-20 Thread Peter Varga via Review Board
- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72380/#review220352 ------- On April 17, 2020, 3:24 p.m., Peter Varga wrote: > >

Review Request 72380: HIVE-23207 Create integration tests for TxnManager for different rdbms metastores

2020-04-17 Thread Peter Varga via Review Board
/java/org/apache/hadoop/hive/metastore/dbinstall/rules/Mysql.java c537d95470 Diff: https://reviews.apache.org/r/72380/diff/1/ Testing --- On my machine the 50 tests in TestDbTxnManager2 on postgres runs under 5 minutes. Thanks, Peter Varga

[jira] [Created] (HIVE-23232) Fix flaky TestJdbcWithServiceDiscovery.testKillQueryWithDifferentServerZKTurnedOff

2020-04-17 Thread Peter Varga (Jira)
Peter Varga created HIVE-23232: -- Summary: Fix flaky TestJdbcWithServiceDiscovery.testKillQueryWithDifferentServerZKTurnedOff Key: HIVE-23232 URL: https://issues.apache.org/jira/browse/HIVE-23232 Project

[jira] [Created] (HIVE-23207) Create integration tests for TxnManager for different rdbms metstores

2020-04-14 Thread Peter Varga (Jira)
Peter Varga created HIVE-23207: -- Summary: Create integration tests for TxnManager for different rdbms metstores Key: HIVE-23207 URL: https://issues.apache.org/jira/browse/HIVE-23207 Project: Hive

Re: Review Request 72276: HIVE-23084: Implement kill query in multiple HS2 environment

2020-04-06 Thread Peter Varga via Review Board
/hive/common/ZooKeeperHiveHelper.java 71d8651712 Diff: https://reviews.apache.org/r/72276/diff/3/ Changes: https://reviews.apache.org/r/72276/diff/2-3/ Testing --- Thanks, Peter Varga

Re: Review Request 72276: HIVE-23084: Implement kill query in multiple HS2 environment

2020-04-01 Thread Peter Varga via Review Board
eviews.apache.org/r/72276/#review220102 --- On March 27, 2020, 10:08 a.m., Peter Varga wrote: > > --- > This is an automatically generated e-mail. To re

Re: Review Request 72276: HIVE-23084: Implement kill query in multiple HS2 environment

2020-03-30 Thread Peter Varga via Review Board
ere? We break out the loop immediatly after this. The progress flag is not used after that. - Peter --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72276/#review220102 ---

Review Request 72276: HIVE-23084: Implement kill query in multiple HS2 environment

2020-03-27 Thread Peter Varga via Review Board
PRE-CREATION standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/common/ZooKeeperHiveHelper.java 71d8651712 Diff: https://reviews.apache.org/r/72276/diff/1/ Testing --- Thanks, Peter Varga

[jira] [Created] (HIVE-23084) Implement kill query in multiple HS2 environment

2020-03-26 Thread Peter Varga (Jira)
Peter Varga created HIVE-23084: -- Summary: Implement kill query in multiple HS2 environment Key: HIVE-23084 URL: https://issues.apache.org/jira/browse/HIVE-23084 Project: Hive Issue Type

Review Request 72246: HIVE-23045: Zookeeper SSL/TLS support

2020-03-19 Thread Peter Varga via Review Board
-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/security/ZooKeeperTokenStore.java af52fcc5f6 Diff: https://reviews.apache.org/r/72246/diff/1/ Testing --- Thanks, Peter Varga

[jira] [Created] (HIVE-23045) Zookeeper SSL/TLS support

2020-03-18 Thread Peter Varga (Jira)
Peter Varga created HIVE-23045: -- Summary: Zookeeper SSL/TLS support Key: HIVE-23045 URL: https://issues.apache.org/jira/browse/HIVE-23045 Project: Hive Issue Type: Improvement

[jira] [Created] (HIVE-23019) Fix TestTxnCommandsForMmTable test case

2020-03-12 Thread Peter Varga (Jira)
Peter Varga created HIVE-23019: -- Summary: Fix TestTxnCommandsForMmTable test case Key: HIVE-23019 URL: https://issues.apache.org/jira/browse/HIVE-23019 Project: Hive Issue Type: Bug