3217)
<https://reviews.apache.org/r/50359/#comment209915>
This code in both branches of 'if/else' are identical except for the
'destination path'. Maybe factor that out?
- Reuben Kuhnert
On 七月 27, 2016, 10:56 p.m., Sergio Pena
-CREATION
Diff: https://reviews.apache.org/r/47040/diff/
Testing
---
Thanks,
Reuben Kuhnert
pache/hadoop/hive/metastore/ObjectStore.java (line 2830)
<https://reviews.apache.org/r/48233/#comment201898>
Maybe StringUtils.isEmpty? I think it will do both of these checks for you.
- Reuben Kuhnert
On 六月 6, 2016, 6:19 p.m.,
+1 Drop Java7 support, start using JDK8 features.
On Fri, Jun 3, 2016 at 12:39 PM, Prasanth Jayachandran <
pjayachand...@hortonworks.com> wrote:
> +1 for using jdk8 as minimum required version.
>
> Thanks
> Prasanth
>
>
>
>
> On Fri, Jun 3, 2016 at 10:21 AM -0700, "Siddharth Seth"
ction in an invalid state. Thanks!
- Reuben
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47040/#review133592
-------
On M
/src/main/java/org/apache/hadoop/hive/schshim/QueueAllocator.java
PRE-CREATION
shims/scheduler/src/test/java/org/apache/hadoop/hive/schshim/TestFairSchedulerQueueAllocator.java
PRE-CREATION
Diff: https://reviews.apache.org/r/47040/diff/
Testing
---
Thanks,
Reuben Kuhnert
/QueueAllocator.java
PRE-CREATION
shims/scheduler/src/test/java/org/apache/hadoop/hive/schshim/TestFairSchedulerQueueAllocator.java
PRE-CREATION
Diff: https://reviews.apache.org/r/47040/diff/
Testing
---
Thanks,
Reuben Kuhnert
/main/java/org/apache/hadoop/hive/schshim/QueueAllocator.java
PRE-CREATION
shims/scheduler/src/test/java/org/apache/hadoop/hive/schshim/TestFairSchedulerQueueAllocator.java
PRE-CREATION
Diff: https://reviews.apache.org/r/47040/diff/
Testing
---
Thanks,
Reuben Kuhnert
/apache/hadoop/hive/schshim/TestFairSchedulerQueueAllocator.java
PRE-CREATION
Diff: https://reviews.apache.org/r/47040/diff/
Testing
---
Thanks,
Reuben Kuhnert
shims/scheduler/src/test/java/org/apache/hadoop/hive/schshim/TestFairScheduler.java
PRE-CREATION
Diff: https://reviews.apache.org/r/47040/diff/
Testing
---
Thanks,
Reuben Kuhnert
/hadoop/hive/schshim/TestFairScheduler.java
PRE-CREATION
Diff: https://reviews.apache.org/r/47040/diff/
Testing
---
Thanks,
Reuben Kuhnert
, Mohit Sabharwal wrote:
> > shims/scheduler/src/main/java/org/apache/hadoop/hive/schshim/FairSchedulerShim.java,
> > line 132
> > <https://reviews.apache.org/r/47040/diff/5/?file=1379895#file1379895line132>
> >
> > nit: cleaner with
> &g
/scheduler/src/test/java/org/apache/hadoop/hive/schshim/TestFairScheduler.java
PRE-CREATION
Diff: https://reviews.apache.org/r/47040/diff/
Testing
---
Thanks,
Reuben Kuhnert
/org/apache/hadoop/hive/schshim/QueueAllocator.java
PRE-CREATION
shims/scheduler/src/test/java/org/apache/hadoop/hive/schshim/TestFairScheduler.java
PRE-CREATION
Diff: https://reviews.apache.org/r/47040/diff/
Testing
---
Thanks,
Reuben Kuhnert
> rename to getConfigForUser(...)
> >
> > Also, not quiet sure why this needs to be synchronized.
The configuration resolvers are cached. But the cache is cleared if the
location of 'fair-scheduler.xml' (YARN_SCHEDULER_FILE_PROPERTY) changes, or is
mod
-CREATION
shims/scheduler/src/test/java/org/apache/hadoop/hive/schshim/TestFairScheduler.java
PRE-CREATION
Diff: https://reviews.apache.org/r/47040/diff/
Testing
---
Thanks,
Reuben Kuhnert
/FairSchedulerShim.java
372244dc3c989d2a3ae2eb2bfb8cd0a235705e18
Diff: https://reviews.apache.org/r/47040/diff/
Testing
---
Thanks,
Reuben Kuhnert
ps://reviews.apache.org/r/47040/#review132054
-------
On 5 5, 2016, 8:06 오후, Reuben Kuhnert wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47040/
> ---
/FairSchedulerShim.java
372244dc3c989d2a3ae2eb2bfb8cd0a235705e18
Diff: https://reviews.apache.org/r/47040/diff/
Testing
---
Thanks,
Reuben Kuhnert
Reuben Kuhnert created HIVE-13696:
-
Summary: Validate jobs submitted to fair-scheduler
Key: HIVE-13696
URL: https://issues.apache.org/jira/browse/HIVE-13696
Project: Hive
Issue Type
Reuben Kuhnert created HIVE-13478:
-
Summary: [Cleanup] Improve HookUtils performance
Key: HIVE-13478
URL: https://issues.apache.org/jira/browse/HIVE-13478
Project: Hive
Issue Type
Reuben Kuhnert created HIVE-13387:
-
Summary: Beeline fails silently from missing dependency
Key: HIVE-13387
URL: https://issues.apache.org/jira/browse/HIVE-13387
Project: Hive
Issue Type
Reuben Kuhnert created HIVE-13385:
-
Summary: [Cleanup] Streamline Beeline instantiation
Key: HIVE-13385
URL: https://issues.apache.org/jira/browse/HIVE-13385
Project: Hive
Issue Type: Task
Reuben Kuhnert created HIVE-13311:
-
Summary: MetaDataFormatUtils throws NPE when HiveDecimal.create is
null
Key: HIVE-13311
URL: https://issues.apache.org/jira/browse/HIVE-13311
Project: Hive
locally + Tested against Hive-Jenkins.
Thanks,
Reuben Kuhnert
Reuben Kuhnert created HIVE-13231:
-
Summary: Show helpful error message on failure to create nested
table in nested directory
Key: HIVE-13231
URL: https://issues.apache.org/jira/browse/HIVE-13231
,
Reuben Kuhnert
Reuben Kuhnert created HIVE-12891:
-
Summary: Hive fails when java.io.tmpdir is set to a relative
location
Key: HIVE-12891
URL: https://issues.apache.org/jira/browse/HIVE-12891
Project: Hive
Reuben Kuhnert created HIVE-12469:
-
Summary: Bump Commons-Collections dependency from 3.2.1 to 3.2.2.
to address vulnerability
Key: HIVE-12469
URL: https://issues.apache.org/jira/browse/HIVE-12469
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36942/#review93651
---
This looks good to me.
- Reuben Kuhnert
On July 30, 2015, 9:22
/hadoop/hive/ql/io/parquet/read/ParquetFilterPredicateConverter.java
(line 102)
https://reviews.apache.org/r/36942/#comment147978
ListT has O(N) lookup time. Can we store this in a SetT (O(1)) instead?
- Reuben Kuhnert
On July 30, 2015, 3:43 p.m., Sergio Pena wrote
Reuben Kuhnert created HIVE-10738:
-
Summary: Beeline does not respect hive.cli.print.current.db
Key: HIVE-10738
URL: https://issues.apache.org/jira/browse/HIVE-10738
Project: Hive
Issue Type
---
Tested locally
Thanks,
Reuben Kuhnert
Reuben Kuhnert created HIVE-10656:
-
Summary: Beeline set var=value not carrying over to queries
Key: HIVE-10656
URL: https://issues.apache.org/jira/browse/HIVE-10656
Project: Hive
Issue Type
https://reviews.apache.org/r/33816/#comment133647
Originally I used the warehouse home directory as the base for relative
paths. However, per Lenni's comment, it sounds like it's best to throw an
exception if the user tries to use a anything other than an absolute path.
- Reuben Kuhnert
generated e-mail. To reply, visit:
https://reviews.apache.org/r/33816/#review82781
---
On May 5, 2015, 3:14 p.m., Reuben Kuhnert wrote:
---
This is an automatically generated e-mail
.
- Reuben
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33816/#review82440
---
On May 5, 2015, 3:14 p.m., Reuben Kuhnert wrote
)
-
metastore/src/java/org/apache/hadoop/hive/metastore/Warehouse.java
25119abf97382df7c0615edbaff29ba20624a137
metastore/src/test/org/apache/hadoop/hive/metastore/TestWarehouse.java
PRE-CREATION
Diff: https://reviews.apache.org/r/33816/diff/
Testing
---
Tested locally
Thanks,
Reuben
://reviews.apache.org/r/33680/diff/
Testing
---
Unit tests attached. Also tested locally.
Thanks,
Reuben Kuhnert
7614463525262f01375c1336e89a18670862bb7d
ql/src/java/org/apache/hadoop/hive/ql/parse/ParseUtils.java
373429cbf666f1b19828c532aea3c07f08f95e1a
Diff: https://reviews.apache.org/r/33806/diff/
Testing
---
Tested locally
Thanks,
Reuben Kuhnert
://reviews.apache.org/r/33806/diff/
Testing
---
Tested locally
Thanks,
Reuben Kuhnert
/33813/diff/
Testing
---
Thanks,
Reuben Kuhnert
Reuben Kuhnert created HIVE-10597:
-
Summary: Relative path doesn't work with CREATE TABLE LOCATION
'relative/path'
Key: HIVE-10597
URL: https://issues.apache.org/jira/browse/HIVE-10597
Project: Hive
/diff/
Testing
---
Tested locally
Thanks,
Reuben Kuhnert
,
Reuben Kuhnert
://reviews.apache.org/r/33680/diff/
Testing
---
Unit tests attached. Also tested locally.
Thanks,
Reuben Kuhnert
Hi, Can I be added to the Hive Developer List. My apache ID is
'sircodesalot'.
Thank you
Hi,
My name is Reuben Kuhnert from (Engineer, Cloudera). I would like to be
added to the hive contributor list if possible.
Thank you
48 matches
Mail list logo
