[
https://issues.apache.org/jira/browse/HIVE-3323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13450726#comment-13450726
]
Ashutosh Chauhan commented on HIVE-3323:
Thanks, Travis for updating the patch. I
[
https://issues.apache.org/jira/browse/HIVE-3323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13449024#comment-13449024
]
Ashutosh Chauhan commented on HIVE-3323:
MultiKey stuff you added in OIcache
[
https://issues.apache.org/jira/browse/HIVE-3323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13449063#comment-13449063
]
Travis Crawford commented on HIVE-3323:
---
Thanks for the feedback Ashutosh – I agree
[
https://issues.apache.org/jira/browse/HIVE-3323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13449416#comment-13449416
]
Ashutosh Chauhan commented on HIVE-3323:
+1
ThriftSerde: Enable
[
https://issues.apache.org/jira/browse/HIVE-3323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13447975#comment-13447975
]
Ashutosh Chauhan commented on HIVE-3323:
I agree that enums as string (as oppose to
[
https://issues.apache.org/jira/browse/HIVE-3323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13448079#comment-13448079
]
Travis Crawford commented on HIVE-3323:
---
Sounds good [~ashutoshc]! I'm rebasing this
[
https://issues.apache.org/jira/browse/HIVE-3323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13448155#comment-13448155
]
Jakob Homan commented on HIVE-3323:
---
bq. MegaStruct
eh?
ThriftSerde:
[
https://issues.apache.org/jira/browse/HIVE-3323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13448184#comment-13448184
]
Travis Crawford commented on HIVE-3323:
---
While making a number of thrift-related
[
https://issues.apache.org/jira/browse/HIVE-3323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13445500#comment-13445500
]
Ashutosh Chauhan commented on HIVE-3323:
Travis,
Can you create a review request on
[
https://issues.apache.org/jira/browse/HIVE-3323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13444247#comment-13444247
]
Travis Crawford commented on HIVE-3323:
---
Hey all, good discussion about this enum
[
https://issues.apache.org/jira/browse/HIVE-3323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13440713#comment-13440713
]
Jakob Homan commented on HIVE-3323:
---
One comment I have:
{noformat}
+
[
https://issues.apache.org/jira/browse/HIVE-3323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13440719#comment-13440719
]
Dmitriy V. Ryaboy commented on HIVE-3323:
-
Jakob, that sounds like something to fix
[
https://issues.apache.org/jira/browse/HIVE-3323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13440722#comment-13440722
]
Dmitriy V. Ryaboy commented on HIVE-3323:
-
Sorry, let me try a less snide reply :)
[
https://issues.apache.org/jira/browse/HIVE-3323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13440724#comment-13440724
]
Jakob Homan commented on HIVE-3323:
---
Right, but AvroSerde already does this conversion is
[
https://issues.apache.org/jira/browse/HIVE-3323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13440739#comment-13440739
]
Dmitriy V. Ryaboy commented on HIVE-3323:
-
How about if we (as in, me/feng/travis)
[
https://issues.apache.org/jira/browse/HIVE-3323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13440741#comment-13440741
]
Jakob Homan commented on HIVE-3323:
---
Is the current Thrift behavior worth keeping around?
[
https://issues.apache.org/jira/browse/HIVE-3323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13440748#comment-13440748
]
Dmitriy V. Ryaboy commented on HIVE-3323:
-
We are thinking of a situation where you
[
https://issues.apache.org/jira/browse/HIVE-3323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13440821#comment-13440821
]
Jakob Homan commented on HIVE-3323:
---
OK, but that sounds like a less frequently useful
[
https://issues.apache.org/jira/browse/HIVE-3323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13440838#comment-13440838
]
Dmitriy V. Ryaboy commented on HIVE-3323:
-
I am ok with making the default true.
[
https://issues.apache.org/jira/browse/HIVE-3323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13440844#comment-13440844
]
Feng Peng commented on HIVE-3323:
-
I think it is fine. The current behavior for thrift is
20 matches
Mail list logo
