[
https://issues.apache.org/jira/browse/HIVE-4113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13774088#comment-13774088
]
Hudson commented on HIVE-4113:
--
FAILURE: Integrated in Hive-trunk-hadoop2 #450 (See
[
https://issues.apache.org/jira/browse/HIVE-4113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13773747#comment-13773747
]
Hive QA commented on HIVE-4113:
---
{color:red}Overall{color}: -1 at least one tests failed
[
https://issues.apache.org/jira/browse/HIVE-4113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13773920#comment-13773920
]
Yin Huai commented on HIVE-4113:
Thanks Ashutosh for updating golden files :)
[
https://issues.apache.org/jira/browse/HIVE-4113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13773974#comment-13773974
]
Hive QA commented on HIVE-4113:
---
{color:green}Overall{color}: +1 all checks pass
Here are
[
https://issues.apache.org/jira/browse/HIVE-4113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13772658#comment-13772658
]
Ashutosh Chauhan commented on HIVE-4113:
Its not necessary. I thought it will make
[
https://issues.apache.org/jira/browse/HIVE-4113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13773008#comment-13773008
]
Yin Huai commented on HIVE-4113:
my previous patch deleted some imports
[
https://issues.apache.org/jira/browse/HIVE-4113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13773024#comment-13773024
]
Ashutosh Chauhan commented on HIVE-4113:
Even after fixing import statements, most
[
https://issues.apache.org/jira/browse/HIVE-4113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13773037#comment-13773037
]
Yin Huai commented on HIVE-4113:
the problem is for those TableScanOperators used to load
[
https://issues.apache.org/jira/browse/HIVE-4113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13773113#comment-13773113
]
Yin Huai commented on HIVE-4113:
.6 still has some problems... please ignore it..
[
https://issues.apache.org/jira/browse/HIVE-4113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13773134#comment-13773134
]
Ashutosh Chauhan commented on HIVE-4113:
It seems instead of null check more
[
https://issues.apache.org/jira/browse/HIVE-4113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13773444#comment-13773444
]
Ashutosh Chauhan commented on HIVE-4113:
Thanks Yin for making changes. There seems
[
https://issues.apache.org/jira/browse/HIVE-4113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13773425#comment-13773425
]
Yin Huai commented on HIVE-4113:
[~ashutoshc] it is pretty easy. I just spent sometime on
[
https://issues.apache.org/jira/browse/HIVE-4113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13773624#comment-13773624
]
Yin Huai commented on HIVE-4113:
{code}
input = genConversionSelectOperator(dest, qb,
[
https://issues.apache.org/jira/browse/HIVE-4113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13773677#comment-13773677
]
Yin Huai commented on HIVE-4113:
If a test query contains a query evaluated by multiple MR
[
https://issues.apache.org/jira/browse/HIVE-4113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13773695#comment-13773695
]
Hive QA commented on HIVE-4113:
---
{color:red}Overall{color}: -1 at least one tests failed
[
https://issues.apache.org/jira/browse/HIVE-4113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13773717#comment-13773717
]
Ashutosh Chauhan commented on HIVE-4113:
I think TS does make sense there. So, lets
[
https://issues.apache.org/jira/browse/HIVE-4113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13771652#comment-13771652
]
Ashutosh Chauhan commented on HIVE-4113:
Thanks, [~yhuai] for taking this one up.
[
https://issues.apache.org/jira/browse/HIVE-4113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13771847#comment-13771847
]
Yin Huai commented on HIVE-4113:
READ_ALL_COLUMNS and READ_ALL_COLUMNS_DEFAULT are mainly
[
https://issues.apache.org/jira/browse/HIVE-4113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13771905#comment-13771905
]
Ashutosh Chauhan commented on HIVE-4113:
Sounds good to me. Go ahead and make the
[
https://issues.apache.org/jira/browse/HIVE-4113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13772163#comment-13772163
]
Ashutosh Chauhan commented on HIVE-4113:
[~yhuai] I left some comments on RB. But,
[
https://issues.apache.org/jira/browse/HIVE-4113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13772317#comment-13772317
]
Yin Huai commented on HIVE-4113:
please ignore those duplicated replies...
[
https://issues.apache.org/jira/browse/HIVE-4113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13772590#comment-13772590
]
Yin Huai commented on HIVE-4113:
[~ashutoshc] Using LinkedHashSet as the type of
[
https://issues.apache.org/jira/browse/HIVE-4113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13771243#comment-13771243
]
Yin Huai commented on HIVE-4113:
I thought there was no flag for column pruning, so
[
https://issues.apache.org/jira/browse/HIVE-4113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13771307#comment-13771307
]
Yin Huai commented on HIVE-4113:
[~brocknoland] I have one question. Why do we need
[
https://issues.apache.org/jira/browse/HIVE-4113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13771309#comment-13771309
]
Brock Noland commented on HIVE-4113:
Remove it and see what happens? I don't remember
[
https://issues.apache.org/jira/browse/HIVE-4113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13771370#comment-13771370
]
Yin Huai commented on HIVE-4113:
[~brocknoland] I see. Thanks. I am not sure if those
[
https://issues.apache.org/jira/browse/HIVE-4113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13771530#comment-13771530
]
Yin Huai commented on HIVE-4113:
Three issues:
#
[
https://issues.apache.org/jira/browse/HIVE-4113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13769688#comment-13769688
]
Ashutosh Chauhan commented on HIVE-4113:
In addition to what [~yhuai] suggested for
[
https://issues.apache.org/jira/browse/HIVE-4113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13769693#comment-13769693
]
Brock Noland commented on HIVE-4113:
Agreed. Unfortunately I won't have time to take
[
https://issues.apache.org/jira/browse/HIVE-4113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13769730#comment-13769730
]
Yin Huai commented on HIVE-4113:
Let me take a look. Seems only a few minor changes are
[
https://issues.apache.org/jira/browse/HIVE-4113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13769740#comment-13769740
]
Ashutosh Chauhan commented on HIVE-4113:
Thanks [~yhuai] for volunteering.
[
https://issues.apache.org/jira/browse/HIVE-4113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13769712#comment-13769712
]
Prasanth J commented on HIVE-4113:
--
HIVE-4340 will expose ORC stats through reader
[
https://issues.apache.org/jira/browse/HIVE-4113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13769716#comment-13769716
]
Prasanth J commented on HIVE-4113:
--
Sorry. Please ignore that comment. Row count interface
[
https://issues.apache.org/jira/browse/HIVE-4113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13763425#comment-13763425
]
Ashutosh Chauhan commented on HIVE-4113:
[~brocknoland] Are you still working on
[
https://issues.apache.org/jira/browse/HIVE-4113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13763506#comment-13763506
]
Brock Noland commented on HIVE-4113:
Thanks [~yhuai] for reviewing and thanks Ashutosh
[
https://issues.apache.org/jira/browse/HIVE-4113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13709510#comment-13709510
]
Yin Huai commented on HIVE-4113:
[~brocknoland] Seems that we use setNeededColumnIDs in
[
https://issues.apache.org/jira/browse/HIVE-4113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13709686#comment-13709686
]
Hive QA commented on HIVE-4113:
---
{color:green}Overall:{color}: +1 all checks pass
[
https://issues.apache.org/jira/browse/HIVE-4113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13684535#comment-13684535
]
Brock Noland commented on HIVE-4113:
[~owen.omalley] would you have some time to look
38 matches
Mail list logo
