[
https://issues.apache.org/jira/browse/HIVE-5230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14193060#comment-14193060
]
qiaohaijun commented on HIVE-5230:
--
+1
Better error reporting by async threads in
[
https://issues.apache.org/jira/browse/HIVE-5230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13851237#comment-13851237
]
Thejas M Nair commented on HIVE-5230:
-
Rebased patch looks good. I will commit it
[
https://issues.apache.org/jira/browse/HIVE-5230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13849827#comment-13849827
]
Vaibhav Gumashta commented on HIVE-5230:
[~thejas] Uploaded a rebased patch which
[
https://issues.apache.org/jira/browse/HIVE-5230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13850007#comment-13850007
]
Hive QA commented on HIVE-5230:
---
{color:red}Overall{color}: -1 at least one tests failed
[
https://issues.apache.org/jira/browse/HIVE-5230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13844886#comment-13844886
]
Thejas M Nair commented on HIVE-5230:
-
[~vgumashta] The patch does not apply on trunk
[
https://issues.apache.org/jira/browse/HIVE-5230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13844892#comment-13844892
]
Vaibhav Gumashta commented on HIVE-5230:
[~thejas] Sure, will upload an updated one
[
https://issues.apache.org/jira/browse/HIVE-5230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13843461#comment-13843461
]
Vaibhav Gumashta commented on HIVE-5230:
[~prasadm] Thanks for taking a look.
[
https://issues.apache.org/jira/browse/HIVE-5230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13843474#comment-13843474
]
Thejas M Nair commented on HIVE-5230:
-
+1
Better error reporting by async threads in
[
https://issues.apache.org/jira/browse/HIVE-5230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13843728#comment-13843728
]
Carl Steinbach commented on HIVE-5230:
--
I'm looking at it now.
[~thejas] If you don't
[
https://issues.apache.org/jira/browse/HIVE-5230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13842273#comment-13842273
]
Prasad Mujumdar commented on HIVE-5230:
---
[~vaibhavgumashta] sorry I didn't look at it
[
https://issues.apache.org/jira/browse/HIVE-5230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13839533#comment-13839533
]
Vaibhav Gumashta commented on HIVE-5230:
[~cwsteinbach] Uploaded a new patch fixing
[
https://issues.apache.org/jira/browse/HIVE-5230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13839655#comment-13839655
]
Vaibhav Gumashta commented on HIVE-5230:
[~thejas] Since JDBC doesn't use async api
[
https://issues.apache.org/jira/browse/HIVE-5230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13838035#comment-13838035
]
Brock Noland commented on HIVE-5230:
Hey guys, Carl is correct, this latest patch
[
https://issues.apache.org/jira/browse/HIVE-5230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13838037#comment-13838037
]
Vaibhav Gumashta commented on HIVE-5230:
[~brocknoland] I was away for a while,
[
https://issues.apache.org/jira/browse/HIVE-5230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13838042#comment-13838042
]
Brock Noland commented on HIVE-5230:
Sounds good, thanks!!
Better error reporting by
[
https://issues.apache.org/jira/browse/HIVE-5230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13834224#comment-13834224
]
Carl Steinbach commented on HIVE-5230:
--
I'm looking at it now.
Better error
[
https://issues.apache.org/jira/browse/HIVE-5230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13834296#comment-13834296
]
Carl Steinbach commented on HIVE-5230:
--
[~vaibhavgumashta] The current version of the
[
https://issues.apache.org/jira/browse/HIVE-5230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13833212#comment-13833212
]
Thejas M Nair commented on HIVE-5230:
-
[~vaibhavgumashta] Looks like more changes would
[
https://issues.apache.org/jira/browse/HIVE-5230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13833255#comment-13833255
]
Thejas M Nair commented on HIVE-5230:
-
Rest of the changes look good to me. I think the
[
https://issues.apache.org/jira/browse/HIVE-5230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13830570#comment-13830570
]
Vaibhav Gumashta commented on HIVE-5230:
[~cwsteinbach] [~thejas] If there is any
[
https://issues.apache.org/jira/browse/HIVE-5230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13824039#comment-13824039
]
Vaibhav Gumashta commented on HIVE-5230:
[~cwsteinbach] Updated based on last
[
https://issues.apache.org/jira/browse/HIVE-5230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13821897#comment-13821897
]
Vaibhav Gumashta commented on HIVE-5230:
[~cwsteinbach] Uploaded a new patch based
[
https://issues.apache.org/jira/browse/HIVE-5230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13818805#comment-13818805
]
Vaibhav Gumashta commented on HIVE-5230:
[~thejas] [~prasadm] Attached a new patch
[
https://issues.apache.org/jira/browse/HIVE-5230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13818813#comment-13818813
]
Vaibhav Gumashta commented on HIVE-5230:
Also this is a no-thrift patch.
Better
[
https://issues.apache.org/jira/browse/HIVE-5230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13819295#comment-13819295
]
Carl Steinbach commented on HIVE-5230:
--
I left some comments on reviewboard. Thanks.
[
https://issues.apache.org/jira/browse/HIVE-5230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13816143#comment-13816143
]
Hive QA commented on HIVE-5230:
---
{color:red}Overall{color}: -1 no tests executed
Here are
[
https://issues.apache.org/jira/browse/HIVE-5230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13813603#comment-13813603
]
Thejas M Nair commented on HIVE-5230:
-
Added some review comments to reviewboard.
fyi
[
https://issues.apache.org/jira/browse/HIVE-5230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13811147#comment-13811147
]
Hive QA commented on HIVE-5230:
---
{color:red}Overall{color}: -1 no tests executed
Here are
[
https://issues.apache.org/jira/browse/HIVE-5230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13810827#comment-13810827
]
Vaibhav Gumashta commented on HIVE-5230:
Revised patch:
[
https://issues.apache.org/jira/browse/HIVE-5230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13805403#comment-13805403
]
Prasad Mujumdar commented on HIVE-5230:
---
[~vaibhavgumashta] I haven't yet put in the
[
https://issues.apache.org/jira/browse/HIVE-5230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13805439#comment-13805439
]
Vaibhav Gumashta commented on HIVE-5230:
Thanks Prasad!
Better error reporting by
[
https://issues.apache.org/jira/browse/HIVE-5230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13804438#comment-13804438
]
Vaibhav Gumashta commented on HIVE-5230:
Hi [~prasadm], I might have some time on
[
https://issues.apache.org/jira/browse/HIVE-5230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13797185#comment-13797185
]
Vaibhav Gumashta commented on HIVE-5230:
Thanks [~prasadm]! That will be very
[
https://issues.apache.org/jira/browse/HIVE-5230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13795349#comment-13795349
]
Prasad Mujumdar commented on HIVE-5230:
---
That's certainly useful. I was originally
[
https://issues.apache.org/jira/browse/HIVE-5230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13794504#comment-13794504
]
Vaibhav Gumashta commented on HIVE-5230:
[~prasadm] In case of a remote client, the
[
https://issues.apache.org/jira/browse/HIVE-5230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13793120#comment-13793120
]
Vaibhav Gumashta commented on HIVE-5230:
[~prasadm] Thanks for the patch Prasad. I
[
https://issues.apache.org/jira/browse/HIVE-5230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13778584#comment-13778584
]
Hive QA commented on HIVE-5230:
---
{color:green}Overall{color}: +1 all checks pass
Here are
[
https://issues.apache.org/jira/browse/HIVE-5230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13778703#comment-13778703
]
Brock Noland commented on HIVE-5230:
This looks good to me, meaning +1. One question,
[
https://issues.apache.org/jira/browse/HIVE-5230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13778958#comment-13778958
]
Prasad Mujumdar commented on HIVE-5230:
---
[~brocknoland] Thanks for taking a look.
[
https://issues.apache.org/jira/browse/HIVE-5230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13776507#comment-13776507
]
Prasad Mujumdar commented on HIVE-5230:
---
Hi [~vaibhavgumashta], Are you still working
[
https://issues.apache.org/jira/browse/HIVE-5230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13776791#comment-13776791
]
Vaibhav Gumashta commented on HIVE-5230:
[~prasadm] Hi Prasad, thanks for looking
[
https://issues.apache.org/jira/browse/HIVE-5230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13777006#comment-13777006
]
Prasad Mujumdar commented on HIVE-5230:
---
[~vaibhavgumashta] Hi Vaibhav, I have a
42 matches
Mail list logo