[jira] [Commented] (HIVE-5286) Negative test date_literal1.q fails on java7 because the syntax is valid

2013-11-09 Thread Xuefu Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-5286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13818358#comment-13818358 ] Xuefu Zhang commented on HIVE-5286: --- Patch committed to trunk. Thanks to Szehon for the

[jira] [Commented] (HIVE-5286) Negative test date_literal1.q fails on java7 because the syntax is valid

2013-11-08 Thread Xuefu Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-5286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13817591#comment-13817591 ] Xuefu Zhang commented on HIVE-5286: --- +1, patch looks good to me. Negative test

[jira] [Commented] (HIVE-5286) Negative test date_literal1.q fails on java7 because the syntax is valid

2013-10-31 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-5286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13810545#comment-13810545 ] Hive QA commented on HIVE-5286: --- {color:green}Overall{color}: +1 all checks pass Here are

[jira] [Commented] (HIVE-5286) Negative test date_literal1.q fails on java7 because the syntax is valid

2013-10-30 Thread Szehon Ho (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-5286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13809456#comment-13809456 ] Szehon Ho commented on HIVE-5286: - [~brocknoland], I am wondering what this test was trying

[jira] [Commented] (HIVE-5286) Negative test date_literal1.q fails on java7 because the syntax is valid

2013-10-30 Thread Brock Noland (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-5286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13809472#comment-13809472 ] Brock Noland commented on HIVE-5286: Perhaps we can just remove this test. Looks like

[jira] [Commented] (HIVE-5286) Negative test date_literal1.q fails on java7 because the syntax is valid

2013-10-30 Thread Szehon Ho (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-5286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13809487#comment-13809487 ] Szehon Ho commented on HIVE-5286: - Sounds good, thanks. Negative test date_literal1.q

[jira] [Commented] (HIVE-5286) Negative test date_literal1.q fails on java7 because the syntax is valid

2013-10-30 Thread Jason Dere (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-5286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13809482#comment-13809482 ] Jason Dere commented on HIVE-5286: -- No preference, you can go ahead and remove it.