[jira] [Commented] (HIVE-5657) TopN produces incorrect results with count(distinct)

2013-11-08 Thread Ashutosh Chauhan (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-5657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13817450#comment-13817450 ] Ashutosh Chauhan commented on HIVE-5657: +1 Can you create a follow-up jira for

[jira] [Commented] (HIVE-5657) TopN produces incorrect results with count(distinct)

2013-11-08 Thread Sergey Shelukhin (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-5657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13817574#comment-13817574 ] Sergey Shelukhin commented on HIVE-5657: btw please don't commit, let me address my

[jira] [Commented] (HIVE-5657) TopN produces incorrect results with count(distinct)

2013-11-08 Thread Sergey Shelukhin (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-5657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13817572#comment-13817572 ] Sergey Shelukhin commented on HIVE-5657: seems like too small an item to create

[jira] [Commented] (HIVE-5657) TopN produces incorrect results with count(distinct)

2013-11-08 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-5657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13817982#comment-13817982 ] Hive QA commented on HIVE-5657: --- {color:green}Overall{color}: +1 all checks pass Here are

[jira] [Commented] (HIVE-5657) TopN produces incorrect results with count(distinct)

2013-11-06 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-5657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13814846#comment-13814846 ] Hive QA commented on HIVE-5657: --- {color:green}Overall{color}: +1 all checks pass Here are

[jira] [Commented] (HIVE-5657) TopN produces incorrect results with count(distinct)

2013-11-06 Thread Ashutosh Chauhan (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-5657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13815044#comment-13815044 ] Ashutosh Chauhan commented on HIVE-5657: [~sershe] Can you create a RB for this ?

[jira] [Commented] (HIVE-5657) TopN produces incorrect results with count(distinct)

2013-11-06 Thread Sergey Shelukhin (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-5657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13815199#comment-13815199 ] Sergey Shelukhin commented on HIVE-5657: https://reviews.apache.org/r/15282/ is the

[jira] [Commented] (HIVE-5657) TopN produces incorrect results with count(distinct)

2013-11-04 Thread Sergey Shelukhin (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-5657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13813143#comment-13813143 ] Sergey Shelukhin commented on HIVE-5657: I refactored the code there because it was

[jira] [Commented] (HIVE-5657) TopN produces incorrect results with count(distinct)

2013-11-04 Thread Ashutosh Chauhan (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-5657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13813148#comment-13813148 ] Ashutosh Chauhan commented on HIVE-5657: Sorry for grief [~navis] However,

[jira] [Commented] (HIVE-5657) TopN produces incorrect results with count(distinct)

2013-11-04 Thread Sergey Shelukhin (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-5657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13813604#comment-13813604 ] Sergey Shelukhin commented on HIVE-5657: I think I have the non-vector part, need

[jira] [Commented] (HIVE-5657) TopN produces incorrect results with count(distinct)

2013-11-03 Thread Navis (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-5657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13812617#comment-13812617 ] Navis commented on HIVE-5657: - HIVE-5503 is committed and I cannot rebase on that. Was it

[jira] [Commented] (HIVE-5657) TopN produces incorrect results with count(distinct)

2013-10-31 Thread Sergey Shelukhin (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-5657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13810690#comment-13810690 ] Sergey Shelukhin commented on HIVE-5657: One small comment about the value field

[jira] [Commented] (HIVE-5657) TopN produces incorrect results with count(distinct)

2013-10-31 Thread Phabricator (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-5657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13810688#comment-13810688 ] Phabricator commented on HIVE-5657: --- sershe has commented on the revision HIVE-5657

[jira] [Commented] (HIVE-5657) TopN produces incorrect results with count(distinct)

2013-10-31 Thread Sergey Shelukhin (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-5657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13810692#comment-13810692 ] Sergey Shelukhin commented on HIVE-5657: *committer TopN produces incorrect

[jira] [Commented] (HIVE-5657) TopN produces incorrect results with count(distinct)

2013-10-30 Thread Navis (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-5657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13808830#comment-13808830 ] Navis commented on HIVE-5657: - Distinct bug fix + Multi-distinct support. But huge conflict

[jira] [Commented] (HIVE-5657) TopN produces incorrect results with count(distinct)

2013-10-30 Thread Sergey Shelukhin (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-5657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13809785#comment-13809785 ] Sergey Shelukhin commented on HIVE-5657: Left some comments on fb. Can you

[jira] [Commented] (HIVE-5657) TopN produces incorrect results with count(distinct)

2013-10-30 Thread Phabricator (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-5657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13809784#comment-13809784 ] Phabricator commented on HIVE-5657: --- sershe has commented on the revision HIVE-5657

[jira] [Commented] (HIVE-5657) TopN produces incorrect results with count(distinct)

2013-10-30 Thread Sergey Shelukhin (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-5657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13809787#comment-13809787 ] Sergey Shelukhin commented on HIVE-5657: What do you want to do about conflict? It

[jira] [Commented] (HIVE-5657) TopN produces incorrect results with count(distinct)

2013-10-30 Thread Phabricator (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-5657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13809811#comment-13809811 ] Phabricator commented on HIVE-5657: --- navis has commented on the revision HIVE-5657 [jira]

[jira] [Commented] (HIVE-5657) TopN produces incorrect results with count(distinct)

2013-10-30 Thread Sergey Shelukhin (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-5657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13809819#comment-13809819 ] Sergey Shelukhin commented on HIVE-5657: (responding to FB comment) yeah, it would

[jira] [Commented] (HIVE-5657) TopN produces incorrect results with count(distinct)

2013-10-30 Thread Navis (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-5657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13809835#comment-13809835 ] Navis commented on HIVE-5657: - indexOf() stores keys into hash(yes, confusing name). Exclude or

[jira] [Commented] (HIVE-5657) TopN produces incorrect results with count(distinct)

2013-10-30 Thread Sergey Shelukhin (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-5657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13809846#comment-13809846 ] Sergey Shelukhin commented on HIVE-5657: but the hash for distinct in the review

[jira] [Commented] (HIVE-5657) TopN produces incorrect results with count(distinct)

2013-10-30 Thread Sergey Shelukhin (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-5657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13809847#comment-13809847 ] Sergey Shelukhin commented on HIVE-5657: Ah, sorry, I read the name of the override

[jira] [Commented] (HIVE-5657) TopN produces incorrect results with count(distinct)

2013-10-30 Thread Sergey Shelukhin (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-5657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13809848#comment-13809848 ] Sergey Shelukhin commented on HIVE-5657: Oh, I see how it works now. Logically, is

[jira] [Commented] (HIVE-5657) TopN produces incorrect results with count(distinct)

2013-10-28 Thread Sergey Shelukhin (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-5657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13806882#comment-13806882 ] Sergey Shelukhin commented on HIVE-5657: is it ready for review? I skimmed a bit,

[jira] [Commented] (HIVE-5657) TopN produces incorrect results with count(distinct)

2013-10-27 Thread Navis (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-5657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13806508#comment-13806508 ] Navis commented on HIVE-5657: - Yes, top-n is not working with distincts. Test included in

[jira] [Commented] (HIVE-5657) TopN produces incorrect results with count(distinct)

2013-10-25 Thread Sergey Shelukhin (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-5657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13805933#comment-13805933 ] Sergey Shelukhin commented on HIVE-5657: [~navis] [~ashutoshc] you guys might be