[
https://issues.apache.org/jira/browse/HIVE-5795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13880236#comment-13880236
]
Shuaishuai Nie commented on HIVE-5795:
--
Hi [~thejas]. I checked the latest trunk of
[
https://issues.apache.org/jira/browse/HIVE-5795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13880503#comment-13880503
]
Thejas M Nair commented on HIVE-5795:
-
[~shuainie] Thanks for pointing that out! I have
[
https://issues.apache.org/jira/browse/HIVE-5795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13861911#comment-13861911
]
Shuaishuai Nie commented on HIVE-5795:
--
Thanks [~leftylev] [~thejas]. It seems I don't
[
https://issues.apache.org/jira/browse/HIVE-5795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13861962#comment-13861962
]
Lefty Leverenz commented on HIVE-5795:
--
Got it, thanks [~shuainie]. One doc question:
[
https://issues.apache.org/jira/browse/HIVE-5795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13861969#comment-13861969
]
Shuaishuai Nie commented on HIVE-5795:
--
Hi [~leftylev], this property name cannot be
[
https://issues.apache.org/jira/browse/HIVE-5795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13860872#comment-13860872
]
Thejas M Nair commented on HIVE-5795:
-
+1
Hive should be able to skip header and
[
https://issues.apache.org/jira/browse/HIVE-5795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13860891#comment-13860891
]
Eric Hanson commented on HIVE-5795:
---
+1
Hive should be able to skip header and footer
[
https://issues.apache.org/jira/browse/HIVE-5795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13859817#comment-13859817
]
Hive QA commented on HIVE-5795:
---
{color:green}Overall{color}: +1 all checks pass
Here are
[
https://issues.apache.org/jira/browse/HIVE-5795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13859188#comment-13859188
]
Thejas M Nair commented on HIVE-5795:
-
+1
Hive should be able to skip header and
[
https://issues.apache.org/jira/browse/HIVE-5795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13859243#comment-13859243
]
Lefty Leverenz commented on HIVE-5795:
--
When this is committed, we'll need
[
https://issues.apache.org/jira/browse/HIVE-5795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13859255#comment-13859255
]
Shuaishuai Nie commented on HIVE-5795:
--
Thanks [~leftylev]. Changed the parameter name
[
https://issues.apache.org/jira/browse/HIVE-5795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13859294#comment-13859294
]
Hive QA commented on HIVE-5795:
---
{color:red}Overall{color}: -1 at least one tests failed
[
https://issues.apache.org/jira/browse/HIVE-5795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13859316#comment-13859316
]
Lefty Leverenz commented on HIVE-5795:
--
bq. How do I add the new parameters to the
[
https://issues.apache.org/jira/browse/HIVE-5795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13852755#comment-13852755
]
Hive QA commented on HIVE-5795:
---
{color:red}Overall{color}: -1 at least one tests failed
[
https://issues.apache.org/jira/browse/HIVE-5795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13852448#comment-13852448
]
Eric Hanson commented on HIVE-5795:
---
The coding and comment style looks good now. Thanks.
[
https://issues.apache.org/jira/browse/HIVE-5795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13852467#comment-13852467
]
Hive QA commented on HIVE-5795:
---
{color:red}Overall{color}: -1 at least one tests failed
[
https://issues.apache.org/jira/browse/HIVE-5795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13849774#comment-13849774
]
Shuaishuai Nie commented on HIVE-5795:
--
Sorry, wrong link to the new review board.
[
https://issues.apache.org/jira/browse/HIVE-5795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13849801#comment-13849801
]
Eric Hanson commented on HIVE-5795:
---
Looks good, but there are a bunch of places where
[
https://issues.apache.org/jira/browse/HIVE-5795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13845731#comment-13845731
]
Shuaishuai Nie commented on HIVE-5795:
--
Updated the code review at
[
https://issues.apache.org/jira/browse/HIVE-5795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13825713#comment-13825713
]
Eric Hanson commented on HIVE-5795:
---
Can you put the patch on ReviewBoard to make it
[
https://issues.apache.org/jira/browse/HIVE-5795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13826054#comment-13826054
]
Eric Hanson commented on HIVE-5795:
---
Code review at: https://reviews.apache.org/r/15663/
[
https://issues.apache.org/jira/browse/HIVE-5795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13826075#comment-13826075
]
Eric Hanson commented on HIVE-5795:
---
Shuaishuai -- please see my comments on ReviewBoard
[
https://issues.apache.org/jira/browse/HIVE-5795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13826076#comment-13826076
]
Brock Noland commented on HIVE-5795:
The patch has ArrayList on the LHS. It should be
[
https://issues.apache.org/jira/browse/HIVE-5795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13824662#comment-13824662
]
Hive QA commented on HIVE-5795:
---
{color:red}Overall{color}: -1 at least one tests failed
24 matches
Mail list logo