[jira] [Commented] (HIVE-5795) Hive should be able to skip header and footer rows when reading data file for a table

2014-01-23 Thread Shuaishuai Nie (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-5795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13880236#comment-13880236 ] Shuaishuai Nie commented on HIVE-5795: -- Hi [~thejas]. I checked the latest trunk of

[jira] [Commented] (HIVE-5795) Hive should be able to skip header and footer rows when reading data file for a table

2014-01-23 Thread Thejas M Nair (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-5795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13880503#comment-13880503 ] Thejas M Nair commented on HIVE-5795: - [~shuainie] Thanks for pointing that out! I have

[jira] [Commented] (HIVE-5795) Hive should be able to skip header and footer rows when reading data file for a table

2014-01-03 Thread Shuaishuai Nie (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-5795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13861911#comment-13861911 ] Shuaishuai Nie commented on HIVE-5795: -- Thanks [~leftylev] [~thejas]. It seems I don't

[jira] [Commented] (HIVE-5795) Hive should be able to skip header and footer rows when reading data file for a table

2014-01-03 Thread Lefty Leverenz (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-5795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13861962#comment-13861962 ] Lefty Leverenz commented on HIVE-5795: -- Got it, thanks [~shuainie]. One doc question:

[jira] [Commented] (HIVE-5795) Hive should be able to skip header and footer rows when reading data file for a table

2014-01-03 Thread Shuaishuai Nie (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-5795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13861969#comment-13861969 ] Shuaishuai Nie commented on HIVE-5795: -- Hi [~leftylev], this property name cannot be

[jira] [Commented] (HIVE-5795) Hive should be able to skip header and footer rows when reading data file for a table

2014-01-02 Thread Thejas M Nair (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-5795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13860872#comment-13860872 ] Thejas M Nair commented on HIVE-5795: - +1 Hive should be able to skip header and

[jira] [Commented] (HIVE-5795) Hive should be able to skip header and footer rows when reading data file for a table

2014-01-02 Thread Eric Hanson (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-5795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13860891#comment-13860891 ] Eric Hanson commented on HIVE-5795: --- +1 Hive should be able to skip header and footer

[jira] [Commented] (HIVE-5795) Hive should be able to skip header and footer rows when reading data file for a table

2013-12-31 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-5795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13859817#comment-13859817 ] Hive QA commented on HIVE-5795: --- {color:green}Overall{color}: +1 all checks pass Here are

[jira] [Commented] (HIVE-5795) Hive should be able to skip header and footer rows when reading data file for a table

2013-12-30 Thread Thejas M Nair (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-5795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13859188#comment-13859188 ] Thejas M Nair commented on HIVE-5795: - +1 Hive should be able to skip header and

[jira] [Commented] (HIVE-5795) Hive should be able to skip header and footer rows when reading data file for a table

2013-12-30 Thread Lefty Leverenz (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-5795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13859243#comment-13859243 ] Lefty Leverenz commented on HIVE-5795: -- When this is committed, we'll need

[jira] [Commented] (HIVE-5795) Hive should be able to skip header and footer rows when reading data file for a table

2013-12-30 Thread Shuaishuai Nie (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-5795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13859255#comment-13859255 ] Shuaishuai Nie commented on HIVE-5795: -- Thanks [~leftylev]. Changed the parameter name

[jira] [Commented] (HIVE-5795) Hive should be able to skip header and footer rows when reading data file for a table

2013-12-30 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-5795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13859294#comment-13859294 ] Hive QA commented on HIVE-5795: --- {color:red}Overall{color}: -1 at least one tests failed

[jira] [Commented] (HIVE-5795) Hive should be able to skip header and footer rows when reading data file for a table

2013-12-30 Thread Lefty Leverenz (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-5795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13859316#comment-13859316 ] Lefty Leverenz commented on HIVE-5795: -- bq. How do I add the new parameters to the

[jira] [Commented] (HIVE-5795) Hive should be able to skip header and footer rows when reading data file for a table

2013-12-19 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-5795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13852755#comment-13852755 ] Hive QA commented on HIVE-5795: --- {color:red}Overall{color}: -1 at least one tests failed

[jira] [Commented] (HIVE-5795) Hive should be able to skip header and footer rows when reading data file for a table

2013-12-18 Thread Eric Hanson (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-5795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13852448#comment-13852448 ] Eric Hanson commented on HIVE-5795: --- The coding and comment style looks good now. Thanks.

[jira] [Commented] (HIVE-5795) Hive should be able to skip header and footer rows when reading data file for a table

2013-12-18 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-5795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13852467#comment-13852467 ] Hive QA commented on HIVE-5795: --- {color:red}Overall{color}: -1 at least one tests failed

[jira] [Commented] (HIVE-5795) Hive should be able to skip header and footer rows when reading data file for a table

2013-12-16 Thread Shuaishuai Nie (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-5795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13849774#comment-13849774 ] Shuaishuai Nie commented on HIVE-5795: -- Sorry, wrong link to the new review board.

[jira] [Commented] (HIVE-5795) Hive should be able to skip header and footer rows when reading data file for a table

2013-12-16 Thread Eric Hanson (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-5795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13849801#comment-13849801 ] Eric Hanson commented on HIVE-5795: --- Looks good, but there are a bunch of places where

[jira] [Commented] (HIVE-5795) Hive should be able to skip header and footer rows when reading data file for a table

2013-12-11 Thread Shuaishuai Nie (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-5795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13845731#comment-13845731 ] Shuaishuai Nie commented on HIVE-5795: -- Updated the code review at

[jira] [Commented] (HIVE-5795) Hive should be able to skip header and footer rows when reading data file for a table

2013-11-18 Thread Eric Hanson (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-5795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13825713#comment-13825713 ] Eric Hanson commented on HIVE-5795: --- Can you put the patch on ReviewBoard to make it

[jira] [Commented] (HIVE-5795) Hive should be able to skip header and footer rows when reading data file for a table

2013-11-18 Thread Eric Hanson (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-5795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13826054#comment-13826054 ] Eric Hanson commented on HIVE-5795: --- Code review at: https://reviews.apache.org/r/15663/

[jira] [Commented] (HIVE-5795) Hive should be able to skip header and footer rows when reading data file for a table

2013-11-18 Thread Eric Hanson (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-5795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13826075#comment-13826075 ] Eric Hanson commented on HIVE-5795: --- Shuaishuai -- please see my comments on ReviewBoard

[jira] [Commented] (HIVE-5795) Hive should be able to skip header and footer rows when reading data file for a table

2013-11-18 Thread Brock Noland (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-5795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13826076#comment-13826076 ] Brock Noland commented on HIVE-5795: The patch has ArrayList on the LHS. It should be

[jira] [Commented] (HIVE-5795) Hive should be able to skip header and footer rows when reading data file for a table

2013-11-16 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-5795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13824662#comment-13824662 ] Hive QA commented on HIVE-5795: --- {color:red}Overall{color}: -1 at least one tests failed