[
https://issues.apache.org/jira/browse/HIVE-5895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13837940#comment-13837940
]
Sergey Shelukhin commented on HIVE-5895:
hmm, seemed to have passed on my box
[
https://issues.apache.org/jira/browse/HIVE-5895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13838241#comment-13838241
]
Eric Hanson commented on HIVE-5895:
---
See my comments on RB
vectorization handles
[
https://issues.apache.org/jira/browse/HIVE-5895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13838248#comment-13838248
]
Sergey Shelukhin commented on HIVE-5895:
Are you sure selectedInUse and isRepeating
[
https://issues.apache.org/jira/browse/HIVE-5895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13838263#comment-13838263
]
Eric Hanson commented on HIVE-5895:
---
Yes.
vectorization handles division by zero
[
https://issues.apache.org/jira/browse/HIVE-5895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13838265#comment-13838265
]
Eric Hanson commented on HIVE-5895:
---
E.g. you could have a vectorized row batch with 1024
[
https://issues.apache.org/jira/browse/HIVE-5895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13838316#comment-13838316
]
Hive QA commented on HIVE-5895:
---
{color:green}Overall{color}: +1 all checks pass
Here are
[
https://issues.apache.org/jira/browse/HIVE-5895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13838376#comment-13838376
]
Eric Hanson commented on HIVE-5895:
---
+1
vectorization handles division by zero
[
https://issues.apache.org/jira/browse/HIVE-5895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13838392#comment-13838392
]
Hive QA commented on HIVE-5895:
---
{color:green}Overall{color}: +1 all checks pass
Here are
[
https://issues.apache.org/jira/browse/HIVE-5895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13837046#comment-13837046
]
Eric Hanson commented on HIVE-5895:
---
See my new comments on ReviewBoard
vectorization
[
https://issues.apache.org/jira/browse/HIVE-5895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13837102#comment-13837102
]
Sergey Shelukhin commented on HIVE-5895:
writing the test as it is now depends on
[
https://issues.apache.org/jira/browse/HIVE-5895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13837272#comment-13837272
]
Hive QA commented on HIVE-5895:
---
{color:red}Overall{color}: -1 at least one tests failed
[
https://issues.apache.org/jira/browse/HIVE-5895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13834040#comment-13834040
]
Eric Hanson commented on HIVE-5895:
---
This is looking good overall. Please see my review
[
https://issues.apache.org/jira/browse/HIVE-5895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13834369#comment-13834369
]
Hive QA commented on HIVE-5895:
---
{color:red}Overall{color}: -1 at least one tests failed
[
https://issues.apache.org/jira/browse/HIVE-5895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13833038#comment-13833038
]
Eric Hanson commented on HIVE-5895:
---
For division only, consider doing a final pass over
[
https://issues.apache.org/jira/browse/HIVE-5895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13833046#comment-13833046
]
Sergey Shelukhin commented on HIVE-5895:
Yeah, that's what I'm doing
[
https://issues.apache.org/jira/browse/HIVE-5895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13833048#comment-13833048
]
Eric Hanson commented on HIVE-5895:
---
On second thought, the counting would require a
[
https://issues.apache.org/jira/browse/HIVE-5895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13833049#comment-13833049
]
Sergey Shelukhin commented on HIVE-5895:
probably it can piggyback on the pass
[
https://issues.apache.org/jira/browse/HIVE-5895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13833081#comment-13833081
]
Eric Hanson commented on HIVE-5895:
---
Sounds good. It would be best to make it conditional
[
https://issues.apache.org/jira/browse/HIVE-5895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13833145#comment-13833145
]
Sergey Shelukhin commented on HIVE-5895:
Actually regular division can also produce
[
https://issues.apache.org/jira/browse/HIVE-5895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13833146#comment-13833146
]
Sergey Shelukhin commented on HIVE-5895:
Patch later today...
vectorization
[
https://issues.apache.org/jira/browse/HIVE-5895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13833208#comment-13833208
]
Xuefu Zhang commented on HIVE-5895:
---
I understand that the current division can possibly
[
https://issues.apache.org/jira/browse/HIVE-5895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13833362#comment-13833362
]
Sergey Shelukhin commented on HIVE-5895:
[~xuefuz] infinity can be returned from
[
https://issues.apache.org/jira/browse/HIVE-5895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13833364#comment-13833364
]
Sergey Shelukhin commented on HIVE-5895:
rb at https://reviews.apache.org/r/15869/
23 matches
Mail list logo
