[
https://issues.apache.org/jira/browse/HIVE-1950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14174764#comment-14174764
]
Lefty Leverenz commented on HIVE-1950:
--
Doc note: [~prasanth_j] documented this in
[
https://issues.apache.org/jira/browse/HIVE-1950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12998583#comment-12998583
]
He Yongqiang commented on HIVE-1950:
it's a typo, and i fixed in the new patch.
[
https://issues.apache.org/jira/browse/HIVE-1950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12994610#comment-12994610
]
Ning Zhang commented on HIVE-1950:
--
Yongqiang, I'm still reviewing the new patch (.4) but
[
https://issues.apache.org/jira/browse/HIVE-1950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12993806#comment-12993806
]
Ning Zhang commented on HIVE-1950:
--
Yongqiang, does the review board have the latest
[
https://issues.apache.org/jira/browse/HIVE-1950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12993852#comment-12993852
]
Ning Zhang commented on HIVE-1950:
--
Yongqiang, the patch doesn't compile. Below are some
[
https://issues.apache.org/jira/browse/HIVE-1950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12992674#comment-12992674
]
Namit Jain commented on HIVE-1950:
--
1. Can you change merge_files to concatenate ?
[
https://issues.apache.org/jira/browse/HIVE-1950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12992112#comment-12992112
]
He Yongqiang commented on HIVE-1950:
review comments from internal review:
1) if the
[
https://issues.apache.org/jira/browse/HIVE-1950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12992227#comment-12992227
]
Ning Zhang commented on HIVE-1950:
--
As discussed offline, this patch should be able to
[
https://issues.apache.org/jira/browse/HIVE-1950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12990389#comment-12990389
]
He Yongqiang commented on HIVE-1950:
review board:
https://reviews.apache.org/r/388/