RE: Code Review for HIVE-14888?

2019-06-17 Thread David M
! -Original Message- From: David M Sent: Tuesday, May 14, 2019 8:58 PM To: dev@hive.apache.org Subject: RE: Code Review for HIVE-14888? Awesome, thanks Mani! -Original Message- From: Mani M Sent: Tuesday, May 14, 2019 4:48 PM To: dev@hive.apache.org Subject: Re: Code Review

RE: Code Review for HIVE-14888?

2019-05-14 Thread David M
Awesome, thanks Mani! -Original Message- From: Mani M Sent: Tuesday, May 14, 2019 4:48 PM To: dev@hive.apache.org Subject: Re: Code Review for HIVE-14888? Hi David Currently most of the changes is being reviewed with the help of GitHub pull request. So update your personal fork repo

Re: Code Review for HIVE-14888?

2019-05-14 Thread Mani M
Hi David Currently most of the changes is being reviewed with the help of GitHub pull request. So update your personal fork repo and raise the pull request. With Regards M.Mani +61 432 461 087 On Wed, 15 May 2019, 01:18 David M, wrote: > All, > > Can I get someone to do a quick review of the

Code Review for HIVE-14888?

2019-05-14 Thread David M
All, Can I get someone to do a quick review of the code change for HIVE-14888 (https://issues.apache.org/jira/browse/HIVE-14888)? It's a simple one-line change that has passed tests and analysis, and is ready to be pushed. I've seen some talk about using GitHub's review functionality or other