in the new/touched bits in the PR (or at
> > least
> > > > > that's how it works in tez), that's what we need, so we don't have
> to
> > > > make
> > > > > that huge commit to simply introduce this enforcement
> > > > >
> > > > &
; +1
> > > > >
> > > > >
> > > > >
> > > > > BTW, We have a independent checkstyle file under iceberg module
> > > > > https://github.com/apache/hive/tree/master/iceberg/checkstyle . I
> > > think
> > > > > we need to consider unifin
> > +1
> > > >
> > > >
> > > >
> > > > BTW, We have a independent checkstyle file under iceberg module
> > > > https://github.com/apache/hive/tree/master/iceberg/checkstyle . I
> > think
> > > > we ne
g the checkstyle in all the sub-module.
> > >
> > >
> > > Thanks,
> > > Butao Zhang
> > > Replied Message
> > > | From | Zsolt Miskolczi |
> > > | Date | 1/8/2024 16:19 |
> > > | To | |
> > > | Subject | Re: Forc
hink
> > we need to consider unifing the checkstyle in all the sub-module.
> >
> >
> > Thanks,
> > Butao Zhang
> > Replied Message ----
> > | From | Zsolt Miskolczi |
> > | Date | 1/8/2024 16:19 |
> > | To | |
> > | Subject | Re: Force coding s
yle . I think
> we need to consider unifing the checkstyle in all the sub-module.
>
>
> Thanks,
> Butao Zhang
> Replied Message
> | From | Zsolt Miskolczi |
> | Date | 1/8/2024 16:19 |
> | To | |
> | Subject | Re: Force coding style in hive precommit |
> +1
/2024 16:19 |
| To | |
| Subject | Re: Force coding style in hive precommit |
+1
In case there is an agreement about the coding style, we can prepare a tool
that enforces that style at compile time. Run a tool one time to re-format
all the existing code once. And turn on a compile time check
+1
In case there is an agreement about the coding style, we can prepare a tool
that enforces that style at compile time. Run a tool one time to re-format
all the existing code once. And turn on a compile time check. Iceberg did
the same approach, they had one huge commit with almost 4k files
+1
As it would improve maintainability and code reviews. Sometimes small
indentation/styling issues would kill review cycle time and we can easily avoid
it before requesting review.
Enforcing more rules around it definitely boost guaranteeing quality. We can
integrate it with git hooks. If we
+1, We do have a documentation round it as well:
https://cwiki.apache.org/confluence/display/Hive/HowToContribute#HowToContribute-CodingConventions
so it makes sense to enforce it as well.
Right now we have a small section around this in documentation, We can also
expand this to a new page and
Hi All!
What do you think about forcing coding style in Hive precommit?
I remember, back in the old days, precommit printed some warnings in case
some coding style (formatting, indentation, naming convention, etc.)
problems were found in the patch, now it's simply not used, I guess since
we're
11 matches
Mail list logo
