Re: Integrating Yetus with Precommit job

The FindBugs plugin for Yetus is now working. Yetus will give a -1 if it finds any FindBugs warning in your patch. It gives a 0 for any patch applied to a module that contains existing FindBugs warnings (e.g. ql has 2318 existing FindBugs issues). On Mon, Nov 27, 2017 at 8:57 AM, Andrew Sherman

Re: Integrating Yetus with Precommit job

Thanks, this is going to be useful On Wed, Nov 22, 2017 at 11:28 AM, Vineet Garg wrote: > Thanks Adam! > > > On Nov 22, 2017, at 5:46 AM, Adam Szita wrote: > > > > This is now done. Patch is committed and we deployed the new war file to > > the ptest

Re: Integrating Yetus with Precommit job

Thanks Adam! > On Nov 22, 2017, at 5:46 AM, Adam Szita wrote: > > This is now done. Patch is committed and we deployed the new war file to > the ptest server. > > Jobs that were waiting in queue at the time of ptest server restart have > been retriggered in Jenkins. > > I

Re: Integrating Yetus with Precommit job

Thanks Adam for this work! On Wed, Nov 22, 2017 at 5:46 AM, Adam Szita wrote: > This is now done. Patch is committed and we deployed the new war file to > the ptest server. > > Jobs that were waiting in queue at the time of ptest server restart have > been retriggered in

Re: Integrating Yetus with Precommit job

This is now done. Patch is committed and we deployed the new war file to the ptest server. Jobs that were waiting in queue at the time of ptest server restart have been retriggered in Jenkins. I hope this change will contribute to the overall code quality of Hive in our future patches to come :)

Re: Integrating Yetus with Precommit job

Hi, In the last days all prerequisites have been resolved for this: -ASF headers are fixed -checkstyle is upgraded to support Java8 -proper checkstyle configuration has been introduced to poms that are disconnected from Hive's root pom Thanks Alan for reviewing these. Therefore we plan to move

Re: Integrating Yetus with Precommit job

I’ve put some feedback in HIVE-17995. 17996 and 17997 look good. I’ll commit them once the tests run. I think you’ll need to do similar patches for storage-api, as it is also not connected to the hive pom anymore. Alan. On Tue, Nov 7, 2017 at 6:17 AM, Adam Szita wrote: >

Re: Integrating Yetus with Precommit job

+1 on the ideas. On Tue, Nov 7, 2017 at 6:17 AM, Adam Szita wrote: > Thanks for all the replies. > > Vihang: Good idea on making everything green before turning this on. For > this purpose I've filed a couple of jiras: > -HIVE-17995

Re: Integrating Yetus with Precommit job

Thanks for all the replies. Vihang: Good idea on making everything green before turning this on. For this purpose I've filed a couple of jiras: -HIVE-17995 Run checkstyle on standalone-metastore module with proper configuration -HIVE-17996

Re: Integrating Yetus with Precommit job

+1 - think this will be a great addition to Hive. Helping us catch issues earlier, keeping the Hive code cleaner, etc. Getting the basic Yetus checks to work seems like a great start, do we have follow JIRAs to get more YETUS tests integrated - e.g. FindBugs? On Mon, Nov 6, 2017 at 10:29 AM,

Re: Integrating Yetus with Precommit job

Thanks Adam for this work. This is definitely useful and a good addition to our test infrastructure. Can we fix the existing issues pointed by Yetus (in a separate JIRA) so that we have a +1 from yetus on the current code? Once that is done, committers can help keep it green as they review

Re: Integrating Yetus with Precommit job

+1 Yes, I think this can help us catch many issues early on, it will be very useful! On Mon, Nov 6, 2017 at 7:43 AM, Adam Szita wrote: > Hi all, > > As a next step of test subsystem improvements we would like to have the > Yetus check integrated with the ptest framework.

Integrating Yetus with Precommit job

Hi all, As a next step of test subsystem improvements we would like to have the Yetus check integrated with the ptest framework. This means that whenever a new patch is uploaded - along with the already existing Precommit test run - Hive's Yetus patch check script would be triggered also. This