Re: Is Github PR mandatory?

2019-03-17 Thread Rui Li
Got it. Thanks! On Fri, Mar 15, 2019 at 1:47 PM Mani M wrote: > It's used as substitution for review board. > > > With Regards > M.Mani > +61 432 461 087 > > On Fri, 15 Mar 2019, 13:59 Rui Li, wrote: > > > Hi, > > > > I believe we still need to upload patch to JIRA for precommit testing. So >

Re: Is Github PR mandatory?

2019-03-14 Thread Mani M
It's used as substitution for review board. With Regards M.Mani +61 432 461 087 On Fri, 15 Mar 2019, 13:59 Rui Li, wrote: > Hi, > > I believe we still need to upload patch to JIRA for precommit testing. So > just want to make sure whether opening a github PR is mandatory? Or is it > just a

Is Github PR mandatory?

2019-03-14 Thread Rui Li
Hi, I believe we still need to upload patch to JIRA for precommit testing. So just want to make sure whether opening a github PR is mandatory? Or is it just a substitution for the review board? -- Best regards! Rui Li