Re: [VOTE] Stricter commit guidelines

+1 for stricter commit guidelines. I faced with some flaky tests. Mainly, it is TestTezPerfCliTests and some of LlapLocalCliDriver. Thanks, Igor. On Thu, May 17, 2018, 22:54 Mithun RK wrote: > bq. run tests on 10 “noop" patches > > Good idea, I think. I've upped NOOP patches on some of my JIR

Re: [VOTE] Stricter commit guidelines

bq. run tests on 10 “noop" patches Good idea, I think. I've upped NOOP patches on some of my JIRAs before, only to establish the "acceptable" baseline of failing tests. One problem was that failing-tests tended to change over time, so this needed repeating.:/ The tighter commit rules are a welcom

Re: [VOTE] Stricter commit guidelines

https://issues.apache.org/jira/issues/?jql=project%20%3D%20HIVE%20AND%20tex t%20~%20%22%5C%22NOOP%20jira%5C%22%22 Anything that fails on these JIRAs should be fixed or disabled :) On 18/5/17, 12:32, "Sergey Shelukhin" wrote: >Let me just do that... > >On 18/5/17, 12:31, "Sergey Shelukhin" wrot

Re: [VOTE] Stricter commit guidelines

Let me just do that... On 18/5/17, 12:31, "Sergey Shelukhin" wrote: >I am actually hitting all kinds of test failures clearly unrelated to my >patches now… >Should we create 10 jiras and run tests on 10 “noop" patches to find which >tests are flaky? > >On 18/5/16, 22:58, "Jesus Camacho Rodriguez

Re: [VOTE] Stricter commit guidelines

I am actually hitting all kinds of test failures clearly unrelated to my patches now… Should we create 10 jiras and run tests on 10 “noop" patches to find which tests are flaky? On 18/5/16, 22:58, "Jesus Camacho Rodriguez" wrote: >The vote passes with 19 +1s. Thanks for voting and supporting the

Re: [VOTE] Stricter commit guidelines

The vote passes with 19 +1s. Thanks for voting and supporting the initiative, it has been encouraging to see this reaction from the community. I have changed the committers guide as agreed [2]. We do not have consistent clean runs yet, hence we have more work ahead. Please, get involved identify

Re: [VOTE] Stricter commit guidelines

+1 On Wed, May 16, 2018 at 1:40 PM Yongzhi Chen wrote: > +1 > > On Tue, May 15, 2018 at 9:59 PM, Siddharth Seth wrote: > > > +1 > > > > On Mon, May 14, 2018 at 10:44 PM, Jesus Camacho Rodriguez < > > jcama...@apache.org> wrote: > > > > > After work has been done to ignore most of the tests that

Re: [VOTE] Stricter commit guidelines

+1 On Tue, May 15, 2018 at 9:59 PM, Siddharth Seth wrote: > +1 > > On Mon, May 14, 2018 at 10:44 PM, Jesus Camacho Rodriguez < > jcama...@apache.org> wrote: > > > After work has been done to ignore most of the tests that were failing > > consistently/intermittently [1], I wanted to start this vo

Re: [VOTE] Stricter commit guidelines

+1 On Mon, May 14, 2018 at 10:44 PM, Jesus Camacho Rodriguez < jcama...@apache.org> wrote: > After work has been done to ignore most of the tests that were failing > consistently/intermittently [1], I wanted to start this vote to gather > support from the community to be stricter wrt committing p

Re: [VOTE] Stricter commit guidelines

> > > >> > Alan. > >> > > >> > On Tue, May 15, 2018 at 9:12 AM, Sergio Pena > > > >> > wrote: > >> > > >> >

Re: [VOTE] Stricter commit guidelines

9:12 AM, Sergio Pena > >> > wrote: >> > >> >> +1 >> >> >> >> On Tue, May 15, 2018 at 11:05 AM, Gunther Hagleitner < > > >> ghagleit...@hortonworks.com> wr

Re: [VOTE] Stricter commit guidelines

> >> >> >> On Tue, May 15, 2018 at 11:05 AM, Gunther Hagleitner < >> >> ghagleit...@hortonworks.com> wrote: >> >> >> >>> +1 >> >>> >> >

Re: [VOTE] Stricter commit guidelines

>> > >> > Alan. >> > >> > On Tue, May 15, 2018 at 9:12 AM, Sergio Pena > >> > wrote: >> > >> >> +1 >> >> >> >> On Tue, May 15, 2018 at 11:05 AM, Gunther Hagleitner < >

Re: [VOTE] Stricter commit guidelines

;> +1 > >> > >> On Tue, May 15, 2018 at 11:05 AM, Gunther Hagleitner < > >> ghagleit...@hortonworks.com> wrote: > >> > >>> +1 > >>> ________ > >>> Fro

Re: [VOTE] Stricter commit guidelines

t 11:05 AM, Gunther Hagleitner < > >> ghagleit...@hortonworks.com> wrote: > >> > >>> +1 > >>> ____________ > >>> From: Sankar Hariappan > >>> Sent: Tuesday, May 15, 2018 9:03 AM > >>> To: dev@hive.apache.org > >>> S

Re: [VOTE] Stricter commit guidelines

gt;> ghagleit...@hortonworks.com> wrote: >> >>> +1 >>> >>> From: Sankar Hariappan >>> Sent: Tuesday, May 15, 2018 9:03 AM >>> To: dev@hive.apache.org >>> Subject: Re: [VOTE] Stricter commit guidelines >>> >>>

Re: [VOTE] Stricter commit guidelines

t; Sent: Tuesday, May 15, 2018 9:03 AM > > To: dev@hive.apache.org > > Subject: Re: [VOTE] Stricter commit guidelines > > > > +1 > > > > > > On 15/05/18, 9:30 PM, "Sahil Takiar" wrote: > > > > >+1 > > > > > >On Tue

Re: [VOTE] Stricter commit guidelines

+1 On Tue, May 15, 2018 at 11:05 AM, Gunther Hagleitner < ghagleit...@hortonworks.com> wrote: > +1 > > From: Sankar Hariappan > Sent: Tuesday, May 15, 2018 9:03 AM > To: dev@hive.apache.org > Subject: Re: [VOTE] Stricter commit gu

Re: [VOTE] Stricter commit guidelines

+1 From: Sankar Hariappan Sent: Tuesday, May 15, 2018 9:03 AM To: dev@hive.apache.org Subject: Re: [VOTE] Stricter commit guidelines +1 On 15/05/18, 9:30 PM, "Sahil Takiar" wrote: >+1 > >On Tue, May 15, 2018 at 10:56 AM, Owen O'

Re: [VOTE] Stricter commit guidelines

+1 On 15/05/18, 9:30 PM, "Sahil Takiar" wrote: >+1 > >On Tue, May 15, 2018 at 10:56 AM, Owen O'Malley >wrote: > >> +1 >> >> On Tue, May 15, 2018 at 8:55 AM, Peter Vary wrote: >> >> > +1 - Hoping for something like this for a long while! Thanks for taking >> > this up all! >> > >> > > On May 1

Re: [VOTE] Stricter commit guidelines

+1 On Tue, May 15, 2018 at 10:56 AM, Owen O'Malley wrote: > +1 > > On Tue, May 15, 2018 at 8:55 AM, Peter Vary wrote: > > > +1 - Hoping for something like this for a long while! Thanks for taking > > this up all! > > > > > On May 15, 2018, at 5:44 PM, Jesus Camacho Rodriguez < > > jcama...@apac

Re: [VOTE] Stricter commit guidelines

+1 On Tue, May 15, 2018 at 8:55 AM, Peter Vary wrote: > +1 - Hoping for something like this for a long while! Thanks for taking > this up all! > > > On May 15, 2018, at 5:44 PM, Jesus Camacho Rodriguez < > jcama...@apache.org> wrote: > > > > Forgot to mention the length of the vote in original m

Re: [VOTE] Stricter commit guidelines

+1 - Hoping for something like this for a long while! Thanks for taking this up all! > On May 15, 2018, at 5:44 PM, Jesus Camacho Rodriguez > wrote: > > Forgot to mention the length of the vote in original message. > > Let's leave the vote open for a shorter period than usual, for instance 48

Re: [VOTE] Stricter commit guidelines

Forgot to mention the length of the vote in original message. Let's leave the vote open for a shorter period than usual, for instance 48 hours, i.e., till Wednesday 10pm PST. Situation can only get worse than it is now if we do not take action for a longer period. As Alan suggested, vote passes

Re: [VOTE] Stricter commit guidelines

+1 On Tue, May 15, 2018 at 2:34 AM Rui Li wrote: > +1 > > On Tue, May 15, 2018 at 2:24 PM, Prasanth Jayachandran < > pjayachand...@hortonworks.com> wrote: > > > +1 > > > > > > > > Thanks > > Prasanth > > > > > > > > On Mon, May 14, 2018 at 10:44 PM -0700, "Jesus Camacho Rodriguez" < > > jcama...

Re: [VOTE] Stricter commit guidelines

+1 On Tue, May 15, 2018 at 2:24 PM, Prasanth Jayachandran < pjayachand...@hortonworks.com> wrote: > +1 > > > > Thanks > Prasanth > > > > On Mon, May 14, 2018 at 10:44 PM -0700, "Jesus Camacho Rodriguez" < > jcama...@apache.org> wrote: > > > After work has been done to

Re: [VOTE] Stricter commit guidelines

+1 Thanks Prasanth On Mon, May 14, 2018 at 10:44 PM -0700, "Jesus Camacho Rodriguez" mailto:jcama...@apache.org>> wrote: After work has been done to ignore most of the tests that were failing consistently/intermittently [1], I wanted to start this vote to gather support from the communit

Re: [VOTE] Stricter commit guidelines

+1 On Mon, May 14, 2018 at 10:44 PM, Jesus Camacho Rodriguez wrote: > After work has been done to ignore most of the tests that were failing > consistently/intermittently [1], I wanted to start this vote to gather > support from the community to be stricter wrt committing patches to Hive. The