Re: Review Request 22016: HIVE-7119 Extended ACL's should be inherited if warehouse perm inheritance enabled

2014-05-31 Thread Szehon Ho
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22016/ --- (Updated June 1, 2014, 1:07 a.m.) Review request for hive. Changes ---

Re: Review Request 22016: HIVE-7119 Extended ACL's should be inherited if warehouse perm inheritance enabled

2014-05-30 Thread Xuefu Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22016/#review44404 ---

Re: Review Request 22016: HIVE-7119 Extended ACL's should be inherited if warehouse perm inheritance enabled

2014-05-30 Thread Szehon Ho
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22016/ --- (Updated May 30, 2014, 7:17 p.m.) Review request for hive. Changes ---

Re: Review Request 22016: HIVE-7119 Extended ACL's should be inherited if warehouse perm inheritance enabled

2014-05-29 Thread Ashish Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22016/#review44272 ---

Re: Review Request 22016: HIVE-7119 Extended ACL's should be inherited if warehouse perm inheritance enabled

2014-05-29 Thread Szehon Ho
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22016/ --- (Updated May 29, 2014, 10:49 p.m.) Review request for hive. Changes ---

Re: Review Request 22016: HIVE-7119 Extended ACL's should be inherited if warehouse perm inheritance enabled

2014-05-29 Thread Szehon Ho
On May 29, 2014, 8:28 p.m., Ashish Singh wrote: shims/0.20/src/main/java/org/apache/hadoop/hive/shims/Hadoop20Shims.java, line 666 https://reviews.apache.org/r/22016/diff/1/?file=598635#file598635line666 Shouldn't we be trying to change permission even if we fail to set group?

Re: Review Request 22016: HIVE-7119 Extended ACL's should be inherited if warehouse perm inheritance enabled

2014-05-29 Thread Szehon Ho
On May 29, 2014, 8:28 p.m., Ashish Singh wrote: shims/0.20S/src/main/java/org/apache/hadoop/hive/shims/Hadoop20SShims.java, line 430 https://reviews.apache.org/r/22016/diff/1/?file=598636#file598636line430 This is similar to Hadoop20FileStatus. Could we push them together into

Re: Review Request 22016: HIVE-7119 Extended ACL's should be inherited if warehouse perm inheritance enabled

2014-05-29 Thread Ashish Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22016/#review44329 --- Ship it! LGTM! - Ashish Singh On May 29, 2014, 10:49 p.m.,

Re: Review Request 22016: HIVE-7119 Extended ACL's should be inherited if warehouse perm inheritance enabled

2014-05-29 Thread Ashish Singh
On May 29, 2014, 8:28 p.m., Ashish Singh wrote: shims/0.20/src/main/java/org/apache/hadoop/hive/shims/Hadoop20Shims.java, line 666 https://reviews.apache.org/r/22016/diff/1/?file=598635#file598635line666 Shouldn't we be trying to change permission even if we fail to set group?