---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22772/#review46879
---
data/files/in_file.dat
On June 27, 2014, 5:33 p.m., Xuefu Zhang wrote:
data/files/in_file.dat, line 1
https://reviews.apache.org/r/22772/diff/6/?file=618531#file618531line1
It's fine. I just wanted to point out that reusing existing file/table
is preferred. We don't want to create an one-line for each
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22772/
---
(Updated June 26, 2014, 5:12 p.m.)
Review request for hive.
Changes
---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22772/#review46768
---
data/files/in_file.dat
On June 26, 2014, 6:10 p.m., Xuefu Zhang wrote:
data/files/in_file.dat, line 1
https://reviews.apache.org/r/22772/diff/6/?file=618531#file618531line1
Could we reuse existing file instead of creating new ones?
I could not find an existing data file with the data I need. test2.dat
On June 20, 2014, 1:04 a.m., Jason Dere wrote:
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFInFile.java,
line 99
https://reviews.apache.org/r/22772/diff/2/?file=613098#file613098line99
Rather than having to compare the actual class/class name of the type,
use
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22772/
---
(Updated June 20, 2014, 9:15 p.m.)
Review request for hive.
Changes
---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22772/
---
(Updated June 20, 2014, 9:28 p.m.)
Review request for hive.
Changes
---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22772/#review46347
---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22772/
---
(Updated June 21, 2014, 1:26 a.m.)
Review request for hive.
Changes
---
On June 20, 2014, 11:52 p.m., Jason Dere wrote:
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFInFile.java,
line 84
https://reviews.apache.org/r/22772/diff/4/?file=614380#file614380line84
Same thing here about using getPrimitiveCategory() rather than
class/class
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22772/
---
(Updated June 21, 2014, 1:27 a.m.)
Review request for hive.
Changes
---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22772/
---
(Updated June 19, 2014, 6:55 p.m.)
Review request for hive.
Changes
---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22772/#review46246
---
14 matches
Mail list logo
