Re: Review Request 27401: HIVE-8636 CBO: split cbo_correctness test

2014-11-04 Thread Sergey Shelukhin
On Oct. 31, 2014, 12:42 a.m., Ashutosh Chauhan wrote: data/scripts/q_test_init.sql, line 305 https://reviews.apache.org/r/27401/diff/2/?file=744973#file744973line305 Any reason for this? We have hive.stats.dbclass = fs at the top of file. That should be sufficient for this. this

Re: Review Request 27401: HIVE-8636 CBO: split cbo_correctness test

2014-11-04 Thread Sergey Shelukhin
On Oct. 31, 2014, 1:01 a.m., John Pullokkaran wrote: itests/src/test/resources/testconfiguration.properties, line 65 https://reviews.apache.org/r/27401/diff/2/?file=744974#file744974line65 Why don't we put all CBO subqueries in to a single test? seems it will be too big - Sergey

Re: Review Request 27401: HIVE-8636 CBO: split cbo_correctness test

2014-11-04 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27401/ --- (Updated Nov. 4, 2014, 9:07 p.m.) Review request for hive, Ashutosh Chauhan

Re: Review Request 27401: HIVE-8636 CBO: split cbo_correctness test

2014-11-04 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27401/#review59835 --- data/scripts/q_test_init.sql

Re: Review Request 27401: HIVE-8636 CBO: split cbo_correctness test

2014-11-04 Thread Ashutosh Chauhan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27401/#review59863 --- data/scripts/q_test_init.sql

Re: Review Request 27401: HIVE-8636 CBO: split cbo_correctness test

2014-10-30 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27401/ --- (Updated Oct. 30, 2014, 11:15 p.m.) Review request for hive, Ashutosh Chauhan

Re: Review Request 27401: HIVE-8636 CBO: split cbo_correctness test

2014-10-30 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27401/ --- (Updated Oct. 30, 2014, 11:15 p.m.) Review request for hive, Ashutosh Chauhan

Re: Review Request 27401: HIVE-8636 CBO: split cbo_correctness test

2014-10-30 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27401/#review59275 ---

Re: Review Request 27401: HIVE-8636 CBO: split cbo_correctness test

2014-10-30 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27401/ --- (Updated Oct. 30, 2014, 11:18 p.m.) Review request for hive, Ashutosh Chauhan

Re: Review Request 27401: HIVE-8636 CBO: split cbo_correctness test

2014-10-30 Thread Ashutosh Chauhan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27401/#review59288 --- data/scripts/q_test_init.sql

Re: Review Request 27401: HIVE-8636 CBO: split cbo_correctness test

2014-10-30 Thread John Pullokkaran
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27401/#review59290 --- itests/src/test/resources/testconfiguration.properties