Re: Review Request 29878: Bug with max() together with rank() and grouping sets

2015-01-18 Thread Navis Ryu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29878/ --- (Updated Jan. 19, 2015, 1:10 a.m.) Review request for hive. Changes ---

Re: Review Request 29878: Bug with max() together with rank() and grouping sets

2015-01-18 Thread Navis Ryu
> On Jan. 16, 2015, 6:20 p.m., Ashutosh Chauhan wrote: > > overall looks good. Few minor comments. Thanks for the review. Fixed BucketingSortingInferenceOptimizer to reflect grouping set pruning and changed default value of grouping set id to -1 in semijoin cases. > On Jan. 16, 2015, 6:20 p.

Re: Review Request 29878: Bug with max() together with rank() and grouping sets

2015-01-16 Thread Ashutosh Chauhan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29878/#review68438 --- overall looks good. Few minor comments. ql/src/java/org/apache/had