Re: Review Request 65500: HIVE-18421 : Vectorized execution handles overflows in a different manner than non-vectorized execution

> On Feb. 8, 2018, 3:51 a.m., Aihua Xu wrote: > > ql/src/gen/vectorization/ExpressionTemplates/ColumnArithmeticColumn.txt > > Lines 131 (patched) > > > > > > Can we remove #ELSE from here and some other places

Re: Review Request 65500: HIVE-18421 : Vectorized execution handles overflows in a different manner than non-vectorized execution

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65500/#review197073 --- common/src/java/org/apache/hadoop/hive/conf/HiveConf.java Lines

Re: Review Request 65500: HIVE-18421 : Vectorized execution handles overflows in a different manner than non-vectorized execution

> On Feb. 7, 2018, 2:40 a.m., Sahil Takiar wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/PosModLongToLong.java > > Lines 46-48 (patched) > > > > > > is there a way to do this check just

Re: Review Request 65500: HIVE-18421 : Vectorized execution handles overflows in a different manner than non-vectorized execution

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65500/ --- (Updated Feb. 7, 2018, 7:13 a.m.) Review request for hive, Aihua Xu, Gopal V,

Re: Review Request 65500: HIVE-18421 : Vectorized execution handles overflows in a different manner than non-vectorized execution

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65500/#review196967 --- Fix it, then Ship it! One last comment, otherwise LGTM.

Re: Review Request 65500: HIVE-18421 : Vectorized execution handles overflows in a different manner than non-vectorized execution

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65500/ --- (Updated Feb. 7, 2018, 12:49 a.m.) Review request for hive, Aihua Xu, Gopal V,

Re: Review Request 65500: HIVE-18421 : Vectorized execution handles overflows in a different manner than non-vectorized execution

> On Feb. 7, 2018, 12:17 a.m., Sahil Takiar wrote: > > ql/src/gen/vectorization/TestTemplates/TestClass.txt > > Lines 27 (patched) > > > > > > is this necessary? yes, this is needed since this template is used to

Re: Review Request 65500: HIVE-18421 : Vectorized execution handles overflows in a different manner than non-vectorized execution

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65500/#review196948 --- ql/src/gen/vectorization/TestTemplates/TestClass.txt Lines 27