Re: Review Request 66567: Migrate to Murmur hash for shuffle and bucketing

> On April 14, 2018, 1:13 a.m., Jason Dere wrote: > > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFHash.java > > Lines 32 (patched) > > > > > > Docs for this UDF will probably need to mention that this

Re: Review Request 66567: Migrate to Murmur hash for shuffle and bucketing

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66567/#review202074 ---

Re: Review Request 66567: Migrate to Murmur hash for shuffle and bucketing

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66567/ --- (Updated April 27, 2018, 1:14 a.m.) Review request for hive, Ashutosh Chauhan,

Re: Review Request 66567: Migrate to Murmur hash for shuffle and bucketing

> On April 26, 2018, 1:11 a.m., Jason Dere wrote: > > hcatalog/webhcat/java-client/src/main/java/org/apache/hive/hcatalog/api/HCatTable.java > > Lines 179 (patched) > > > > > > Check the existing table params for

Re: Review Request 66567: Migrate to Murmur hash for shuffle and bucketing

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66567/#review201975 ---

Re: Review Request 66567: Migrate to Murmur hash for shuffle and bucketing

> On April 14, 2018, 1:13 a.m., Jason Dere wrote: > > hbase-handler/src/test/results/positive/external_table_ppd.q.out > > Lines 59 (patched) > > > > > > Are there any tests for the old-style bucketing, to make sure

Re: Review Request 66567: Migrate to Murmur hash for shuffle and bucketing

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66567/ --- (Updated April 25, 2018, 7:21 a.m.) Review request for hive, Ashutosh Chauhan,

Re: Review Request 66567: Migrate to Murmur hash for shuffle and bucketing

> On April 24, 2018, 11:29 p.m., Jason Dere wrote: > > ql/src/java/org/apache/hadoop/hive/ql/metadata/Table.java > > Line 156 (original), 156 (patched) > > > > > > What is the point of the conf and

Re: Review Request 66567: Migrate to Murmur hash for shuffle and bucketing

> On April 24, 2018, 11:29 p.m., Jason Dere wrote: > > ql/src/java/org/apache/hadoop/hive/ql/metadata/Table.java > > Line 156 (original), 156 (patched) > > > > > > What is the point of the conf and

Re: Review Request 66567: Migrate to Murmur hash for shuffle and bucketing

> On April 24, 2018, 11:29 p.m., Jason Dere wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/ReduceSinkOperator.java > > Line 138 (original), 139 (patched) > > > > > > Remove? yes. Thanks for pointing it

Re: Review Request 66567: Migrate to Murmur hash for shuffle and bucketing

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66567/#review201866 ---

Re: Review Request 66567: Migrate to Murmur hash for shuffle and bucketing

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66567/ --- (Updated April 23, 2018, 5:26 p.m.) Review request for hive, Ashutosh Chauhan,

Re: Review Request 66567: Migrate to Murmur hash for shuffle and bucketing

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66567/ --- (Updated April 23, 2018, 4:36 p.m.) Review request for hive, Ashutosh Chauhan,

Re: Review Request 66567: Migrate to Murmur hash for shuffle and bucketing

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66567/ --- (Updated April 19, 2018, 1:44 a.m.) Review request for hive, Ashutosh Chauhan,

Re: Review Request 66567: Migrate to Murmur hash for shuffle and bucketing

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66567/ --- (Updated April 17, 2018, 4:57 a.m.) Review request for hive, Eugene Koifman,

Re: Review Request 66567: Migrate to Murmur hash for shuffle and bucketing

> On April 14, 2018, 1:13 a.m., Jason Dere wrote: > > serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorUtils.java > > Lines 813 (patched) > > > > > > For these primitive types, might make

Re: Review Request 66567: Migrate to Murmur hash for shuffle and bucketing

> On April 14, 2018, 1:13 a.m., Jason Dere wrote: > > serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorUtils.java > > Lines 813 (patched) > > > > > > For these primitive types, might make

Re: Review Request 66567: Migrate to Murmur hash for shuffle and bucketing

> On April 14, 2018, 1:13 a.m., Jason Dere wrote: > > Thanks for the review. I will work on the issues and update the patch. > On April 14, 2018, 1:13 a.m., Jason Dere wrote: > > hbase-handler/src/test/results/positive/external_table_ppd.q.out > > Lines 59 (patched) > >

Re: Review Request 66567: Migrate to Murmur hash for shuffle and bucketing

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66567/#review201133 --- hbase-handler/src/test/results/positive/external_table_ppd.q.out

Re: Review Request 66567: Migrate to Murmur hash for shuffle and bucketing

> On April 13, 2018, 6:05 p.m., Matt McCline wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/ReduceSinkOperator.java > > Lines 338 (patched) > > > > > > Logging per row too expensive to leave in. Thanks for

Re: Review Request 66567: Migrate to Murmur hash for shuffle and bucketing

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66567/#review201121 ---