Re: Review Request: This function overloads the current DateDiff(expr1, expr2) by adding another parameter to specify the units.

2012-08-09 Thread Shefali Vohra
On Aug. 7, 2012, 12:56 a.m., Ashutosh Chauhan wrote: trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFDateDiff.java, line 312 https://reviews.apache.org/r/6027/diff/1/?file=124154#file124154line312 Looks like this function is not used anywhere. Please remove it. fixed! On Aug.

Re: Review Request: This function overloads the current DateDiff(expr1, expr2) by adding another parameter to specify the units.

2012-08-09 Thread Carl Steinbach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6027/#review10098 --- bq. SQL also has a DateDiff() function with some more acceptable

Re: Review Request: This function overloads the current DateDiff(expr1, expr2) by adding another parameter to specify the units.

2012-08-09 Thread Carl Steinbach
On Aug. 10, 2012, midnight, Carl Steinbach wrote: bq. SQL also has a DateDiff() function with some more acceptable units. The order of parameters is different between SQL and Hive. The reason for this is that Hive already has a DateDiff() function with the same first two parameters,

Re: Review Request: This function overloads the current DateDiff(expr1, expr2) by adding another parameter to specify the units.

2012-08-06 Thread Ashutosh Chauhan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6027/#review9924 --- trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFDateDiff.java

Review Request: This function overloads the current DateDiff(expr1, expr2) by adding another parameter to specify the units.

2012-07-17 Thread Shefali Vohra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6027/ --- Review request for hive and Ashutosh Chauhan. Description --- Parameters

Re: Review Request: This function overloads the current DateDiff(expr1, expr2) by adding another parameter to specify the units.

2012-07-17 Thread Shefali Vohra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6027/ --- (Updated July 18, 2012, 12:56 a.m.) Review request for hive and Ashutosh