Re: Review Request 15654: Rewrite Trim and Pad UDFs based on GenericUDF

2013-12-18 Thread Jason Dere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15654/#review30610 ---

Re: Review Request 15654: Rewrite Trim and Pad UDFs based on GenericUDF

2013-12-18 Thread Mohammad Islam
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15654/#review30669 ---

Re: Review Request 15654: Rewrite Trim and Pad UDFs based on GenericUDF

2013-12-18 Thread Mohammad Islam
On Dec. 18, 2013, 5:37 a.m., Xuefu Zhang wrote: ql/src/test/org/apache/hadoop/hive/ql/exec/vector/TestVectorizationContext.java, line 774 https://reviews.apache.org/r/15654/diff/4/?file=399245#file399245line774 I don't think we need the bridge udf for generic UDFs. This change

Re: Review Request 15654: Rewrite Trim and Pad UDFs based on GenericUDF

2013-12-18 Thread Mohammad Islam
On Dec. 18, 2013, 10:58 a.m., Jason Dere wrote: ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBasePad.java, line 78 https://reviews.apache.org/r/15654/diff/4/?file=399238#file399238line78 Having gone through some pain with Hive on Windows, the bytes returned by

Re: Review Request 15654: Rewrite Trim and Pad UDFs based on GenericUDF

2013-12-17 Thread Carl Steinbach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15654/#review30574 --- ql/src/test/org/apache/hadoop/hive/ql/udf/TestGenericUDFLTrim.java

Re: Review Request 15654: Rewrite Trim and Pad UDFs based on GenericUDF

2013-12-17 Thread Mohammad Islam
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15654/ --- (Updated Dec. 18, 2013, 3:16 a.m.) Review request for hive, Ashutosh Chauhan,

Re: Review Request 15654: Rewrite Trim and Pad UDFs based on GenericUDF

2013-12-16 Thread Mohammad Islam
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15654/ --- (Updated Dec. 17, 2013, midnight) Review request for hive, Ashutosh Chauhan,

Review Request 15654: Rewrite Trim and Pad UDFs based on GenericUDF

2013-11-18 Thread Mohammad Islam
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15654/ --- Review request for hive, Ashutosh Chauhan, Carl Steinbach, and Jitendra Pandey.