Re: Review Request 16063: HIVE-4395: Support TFetchOrientation.FIRST for HiveServer2 FetchResults

2013-12-09 Thread Prasad Mujumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16063/ --- (Updated Dec. 9, 2013, 8:41 a.m.) Review request for hive, Brock Noland and

Re: Review Request 16063: HIVE-4395: Support TFetchOrientation.FIRST for HiveServer2 FetchResults

2013-12-06 Thread Carl Steinbach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16063/#review29893 --- ql/src/java/org/apache/hadoop/hive/ql/processors/DfsProcessor.java

Re: Review Request 16063: HIVE-4395: Support TFetchOrientation.FIRST for HiveServer2 FetchResults

2013-12-06 Thread Thejas Nair
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16063/#review29900 --- Thanks for the comprehensive tests!

Re: Review Request 16063: HIVE-4395: Support TFetchOrientation.FIRST for HiveServer2 FetchResults

2013-12-06 Thread Prasad Mujumdar
On Dec. 6, 2013, 6:45 p.m., Carl Steinbach wrote: service/src/java/org/apache/hive/service/cli/operation/GetColumnsOperation.java, line 197 https://reviews.apache.org/r/16063/diff/2/?file=394966#file394966line197 Since this EnumSet if constant I think we should make it a static

Re: Review Request 16063: HIVE-4395: Support TFetchOrientation.FIRST for HiveServer2 FetchResults

2013-12-06 Thread Prasad Mujumdar
On Dec. 6, 2013, 8:04 p.m., Thejas Nair wrote: itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcDriver2.java, line 1833 https://reviews.apache.org/r/16063/diff/2/?file=394957#file394957line1833 comment not applicable ? ah, CPT errors. Removed. On Dec. 6, 2013, 8:04

Re: Review Request 16063: HIVE-4395: Support TFetchOrientation.FIRST for HiveServer2 FetchResults

2013-12-06 Thread Prasad Mujumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16063/ --- (Updated Dec. 7, 2013, 4:24 a.m.) Review request for hive, Brock Noland and

Review Request 16063: HIVE-4395: Support TFetchOrientation.FIRST for HiveServer2 FetchResults

2013-12-05 Thread Prasad Mujumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16063/ --- Review request for hive and Brock Noland. Bugs: HIVE-4395

Re: Review Request 16063: HIVE-4395: Support TFetchOrientation.FIRST for HiveServer2 FetchResults

2013-12-05 Thread Thejas Nair
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16063/#review29866 --- jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java

Re: Review Request 16063: HIVE-4395: Support TFetchOrientation.FIRST for HiveServer2 FetchResults

2013-12-05 Thread Prasad Mujumdar
On Dec. 6, 2013, 3:13 a.m., Thejas Nair wrote: jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java, line 457 https://reviews.apache.org/r/16063/diff/1/?file=394724#file394724line457 I think it will be better to say soemthing like Concurrency level + resultSetConcurrency +

Re: Review Request 16063: HIVE-4395: Support TFetchOrientation.FIRST for HiveServer2 FetchResults

2013-12-05 Thread Prasad Mujumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16063/ --- (Updated Dec. 6, 2013, 5:37 a.m.) Review request for hive, Brock Noland and