Re: Review Request 17061: HIVE-5783 - Native Parquet Support in Hive

2014-02-07 Thread Swarnim Kulkarni
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17061/#review33934 --- ql/src/java/org/apache/hadoop/hive/ql/io/IOConstants.java

Re: Review Request 17061: HIVE-5783 - Native Parquet Support in Hive

2014-02-07 Thread Swarnim Kulkarni
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17061/#review33935 ---

Re: Review Request 17061: HIVE-5783 - Native Parquet Support in Hive

2014-02-04 Thread Brock Noland
On Feb. 3, 2014, 11:53 p.m., Xuefu Zhang wrote: ql/src/java/parquet/hive/DeprecatedParquetInputFormat.java, line 22 https://reviews.apache.org/r/17061/diff/5/?file=454363#file454363line22 I don't quite get how this provides backward compatibility. Please explain. The issue is

Re: Review Request 17061: HIVE-5783 - Native Parquet Support in Hive

2014-02-04 Thread Brock Noland
On Feb. 3, 2014, 11:53 p.m., Xuefu Zhang wrote: ql/src/java/org/apache/hadoop/hive/ql/io/parquet/ProjectionPusher.java, line 102 https://reviews.apache.org/r/17061/diff/5/?file=454335#file454335line102 Same as above. Hive hasn't always been good at handling schemes and URI's in

Re: Review Request 17061: HIVE-5783 - Native Parquet Support in Hive

2014-02-04 Thread Brock Noland
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17061/ --- (Updated Feb. 4, 2014, 4:25 p.m.) Review request for hive. Changes ---

Re: Review Request 17061: HIVE-5783 - Native Parquet Support in Hive

2014-02-04 Thread Brock Noland
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17061/ --- (Updated Feb. 4, 2014, 4:52 p.m.) Review request for hive. Changes ---

Re: Review Request 17061: HIVE-5783 - Native Parquet Support in Hive

2014-02-04 Thread Xuefu Zhang
On Feb. 3, 2014, 11:53 p.m., Xuefu Zhang wrote: ql/src/java/parquet/hive/DeprecatedParquetInputFormat.java, line 22 https://reviews.apache.org/r/17061/diff/5/?file=454363#file454363line22 I don't quite get how this provides backward compatibility. Please explain. Brock Noland

Re: Review Request 17061: HIVE-5783 - Native Parquet Support in Hive

2014-02-04 Thread Brock Noland
On Feb. 3, 2014, 11:53 p.m., Xuefu Zhang wrote: ql/src/java/parquet/hive/DeprecatedParquetInputFormat.java, line 22 https://reviews.apache.org/r/17061/diff/5/?file=454363#file454363line22 I don't quite get how this provides backward compatibility. Please explain. Brock Noland

Re: Review Request 17061: HIVE-5783 - Native Parquet Support in Hive

2014-02-04 Thread Brock Noland
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17061/ --- (Updated Feb. 4, 2014, 8:29 p.m.) Review request for hive. Changes ---

Re: Review Request 17061: HIVE-5783 - Native Parquet Support in Hive

2014-02-04 Thread Xuefu Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17061/#review33638 ---

Re: Review Request 17061: HIVE-5783 - Native Parquet Support in Hive

2014-02-04 Thread Brock Noland
On Feb. 4, 2014, 9:44 p.m., Xuefu Zhang wrote: ql/src/java/org/apache/hadoop/hive/ql/io/parquet/convert/ArrayWritableGroupConverter.java, line 42 https://reviews.apache.org/r/17061/diff/8/?file=469225#file469225line42 I'd rather throw an exception if (count != 1 count != 2) then

Re: Review Request 17061: HIVE-5783 - Native Parquet Support in Hive

2014-02-04 Thread Xuefu Zhang
On Feb. 4, 2014, 9:44 p.m., Xuefu Zhang wrote: ql/src/java/org/apache/hadoop/hive/ql/io/parquet/convert/ArrayWritableGroupConverter.java, line 42 https://reviews.apache.org/r/17061/diff/8/?file=469225#file469225line42 I'd rather throw an exception if (count != 1 count != 2) then

Re: Review Request 17061: HIVE-5783 - Native Parquet Support in Hive

2014-02-04 Thread Brock Noland
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17061/ --- (Updated Feb. 4, 2014, 10:36 p.m.) Review request for hive. Changes ---

Re: Review Request 17061: HIVE-5783 - Native Parquet Support in Hive

2014-02-04 Thread Brock Noland
On Feb. 4, 2014, 9:44 p.m., Xuefu Zhang wrote: ql/src/java/org/apache/hadoop/hive/ql/io/parquet/convert/ArrayWritableGroupConverter.java, line 42 https://reviews.apache.org/r/17061/diff/8/?file=469225#file469225line42 I'd rather throw an exception if (count != 1 count != 2) then

Re: Review Request 17061: HIVE-5783 - Native Parquet Support in Hive

2014-02-03 Thread Xuefu Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17061/#review33473 ---

Re: Review Request 17061: HIVE-5783 - Native Parquet Support in Hive

2014-02-03 Thread Brock Noland
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17061/#review33533 --- Thanks for the comments, Justin, if you see this, I can address

Re: Review Request 17061: HIVE-5783 - Native Parquet Support in Hive

2014-01-30 Thread Brock Noland
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17061/ --- (Updated Jan. 30, 2014, 2:48 p.m.) Review request for hive. Changes ---

Re: Review Request 17061: HIVE-5783 - Native Parquet Support in Hive

2014-01-28 Thread Brock Noland
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17061/ --- (Updated Jan. 28, 2014, 7:07 p.m.) Review request for hive. Changes ---

Re: Review Request 17061: HIVE-5783 - Native Parquet Support in Hive

2014-01-24 Thread Brock Noland
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17061/ --- (Updated Jan. 24, 2014, 5:55 p.m.) Review request for hive. Changes ---

Re: Review Request 17061: HIVE-5783 - Native Parquet Support in Hive

2014-01-20 Thread Brock Noland
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17061/ --- (Updated Jan. 20, 2014, 10:25 p.m.) Review request for hive. Changes ---

Review Request 17061: HIVE-5783 - Native Parquet Support in Hive

2014-01-17 Thread Brock Noland
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17061/ --- Review request for hive. Bugs: HIVE-5783