Re: Review Request 18168: SQL std auth - authorize statements that work with paths

2014-02-17 Thread Ashutosh Chauhan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18168/#review34663 --- common/src/java/org/apache/hadoop/hive/common/FileUtils.java

Review Request 18168: SQL std auth - authorize statements that work with paths

2014-02-16 Thread Thejas Nair
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18168/ --- Review request for hive and Ashutosh Chauhan. Bugs: HIVE-5958

Re: Review Request 18168: SQL std auth - authorize statements that work with paths

2014-02-16 Thread Thejas Nair
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18168/ --- (Updated Feb. 17, 2014, 4:11 a.m.) Review request for hive and Ashutosh

Re: Review Request 18168: SQL std auth - authorize statements that work with paths

2014-02-16 Thread Brock Noland
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18168/#review34608 --- common/src/java/org/apache/hadoop/hive/common/FileUtils.java

Re: Review Request 18168: SQL std auth - authorize statements that work with paths

2014-02-16 Thread Thejas Nair
On Feb. 17, 2014, 4:23 a.m., Brock Noland wrote: common/src/java/org/apache/hadoop/hive/common/FileUtils.java, line 350 https://reviews.apache.org/r/18168/diff/2/?file=487389#file487389line350 since we return in both the true and false case, this should just be: return