Re: Review Request 18224: HIVE-5976 - Decouple input formats from STORED as keywords

2014-02-18 Thread Brock Noland
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18224/ --- (Updated Feb. 18, 2014, 9:21 p.m.) Review request for hive. Changes ---

Re: Review Request 18224: HIVE-5976 - Decouple input formats from STORED as keywords

2014-02-18 Thread Brock Noland
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18224/ --- (Updated Feb. 18, 2014, 9:18 p.m.) Review request for hive. Changes ---

Re: Review Request 18224: HIVE-5976 - Decouple input formats from STORED as keywords

2014-02-18 Thread Brock Noland
> On Feb. 18, 2014, 8:14 p.m., Mohammad Islam wrote: > > I just reviewed the nitty stuffs. Overall, looks good! > > > > I hope someone else can review from a broader perspective. Thank you! These are all good comments and will be fixed in the next version of the patch. - Brock

Re: Review Request 18224: HIVE-5976 - Decouple input formats from STORED as keywords

2014-02-18 Thread Mohammad Islam
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18224/#review34762 --- I just reviewed the nitty stuffs. Overall, looks good! I hope someo

Re: Review Request 18224: HIVE-5976 - Decouple input formats from STORED as keywords

2014-02-18 Thread Brock Noland
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18224/ --- (Updated Feb. 18, 2014, 7:13 p.m.) Review request for hive. Changes ---

Review Request 18224: HIVE-5976 - Decouple input formats from STORED as keywords

2014-02-18 Thread Brock Noland
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18224/ --- Review request for hive. Bugs: HIVE-5976 https://issues.apache.org/jira/bro