Re: Review Request 23799: HIVE-7390: refactor csv output format with in RFC mode and add one more option to support formatting as the csv format in hive cli

> On Aug. 6, 2014, 5:50 a.m., Lars Francke wrote: > > I don't think this latest patch is the one you wanted to upload? I rebased the code to the latest and it has some difference comparing to the v6. - cheng --- This is an automatically

Re: Review Request 23799: HIVE-7390: refactor csv output format with in RFC mode and add one more option to support formatting as the csv format in hive cli

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23799/#review49698 --- I don't think this latest patch is the one you wanted to upload? -

Re: Review Request 23799: HIVE-7390: refactor csv output format with in RFC mode and add one more option to support formatting as the csv format in hive cli

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23799/ --- (Updated Aug. 6, 2014, 5:41 a.m.) Review request for hive. Changes --- a

Re: Review Request 23799: HIVE-7390: refactor csv output format with in RFC mode and add one more option to support formatting as the csv format in hive cli

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23799/#review49673 --- Just one minor comment beeline/src/main/resources/BeeLine.properti

Re: Review Request 23799: HIVE-7390: refactor csv output format with in RFC mode and add one more option to support formatting as the csv format in hive cli

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23799/ --- (Updated Aug. 1, 2014, 4:15 p.m.) Review request for hive. Changes --- d

Re: Review Request 23799: HIVE-7390: refactor csv output format with in RFC mode and add one more option to support formatting as the csv format in hive cli

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23799/#review49325 --- Ship it! Two last minor nit-picks. Apart from that it looks good! T

Re: Review Request 23799: HIVE-7390: refactor csv output format with in RFC mode and add one more option to support formatting as the csv format in hive cli

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23799/ --- (Updated Aug. 1, 2014, 2:32 a.m.) Review request for hive. Changes --- (

Re: Review Request 23799: HIVE-7390: refactor csv output format with in RFC mode and add one more option to support formatting as the csv format in hive cli

> On July 31, 2014, 10:45 a.m., Lars Francke wrote: > > beeline/src/java/org/apache/hive/beeline/SeparatedValuesOutputFormat.java, > > line 50 > > > > > > Instead of initializing it here like this you could get rid of

Re: Review Request 23799: HIVE-7390: refactor csv output format with in RFC mode and add one more option to support formatting as the csv format in hive cli

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23799/#review49214 --- beeline/src/java/org/apache/hive/beeline/BeeLine.java

Re: Review Request 23799: HIVE-7390: refactor csv output format with in RFC mode and add one more option to support formatting as the csv format in hive cli

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23799/ --- (Updated July 31, 2014, 5:34 a.m.) Review request for hive. Changes ---

Re: Review Request 23799: HIVE-7390: refactor csv output format with in RFC mode and add one more option to support formatting as the csv format in hive cli

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23799/#review49091 --- In general this feels a bit awkward. I think better CSV/TSV support

Re: Review Request 23799: HIVE-7390: refactor csv output format with in RFC mode and add one more option to support formatting as the csv format in hive cli

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23799/ --- (Updated July 30, 2014, 8:30 a.m.) Review request for hive. Changes ---

Re: Review Request 23799: HIVE-7390: refactor csv output format with in RFC mode and add one more option to support formatting as the csv format in hive cli

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23799/ --- (Updated July 29, 2014, 2:04 a.m.) Review request for hive. Changes ---

Re: Review Request 23799: HIVE-7390: refactor csv output format with in RFC mode and add one more option to support formatting as the csv format in hive cli

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23799/ --- (Updated July 22, 2014, 8:48 a.m.) Review request for hive. Bugs: HIVE-7390

Review Request 23799: HIVE-7390: refactor csv output format with in RFC mode and add one more option to support formatting as the csv format in hive cli

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23799/ --- Review request for hive. Bugs: HIVE-7390 https://issues.apache.org/jira/bro