Re: Review Request 23820: HIVE-7445:Improve LOGS for Hive when a query is not able to acquire locks

2014-07-23 Thread Lars Francke
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23820/#review48483 ---

Re: Review Request 23820: HIVE-7445:Improve LOGS for Hive when a query is not able to acquire locks

2014-07-23 Thread Chaoyu Tang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23820/ --- (Updated July 23, 2014, 12:38 p.m.) Review request for hive, Brock Noland,

Re: Review Request 23820: HIVE-7445:Improve LOGS for Hive when a query is not able to acquire locks

2014-07-23 Thread Szehon Ho
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23820/#review48601 --- Ship it! - Szehon Ho On July 23, 2014, 12:38 p.m., Chaoyu Tang

Review Request 23820: HIVE-7445:Improve LOGS for Hive when a query is not able to acquire locks

2014-07-22 Thread Chaoyu Tang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23820/ --- Review request for hive, Brock Noland, Prasad Mujumdar, Szehon Ho, and Xuefu

Re: Review Request 23820: HIVE-7445:Improve LOGS for Hive when a query is not able to acquire locks

2014-07-22 Thread Szehon Ho
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23820/#review48441 --- Hey Chaoyu thanks, the logic looks good now. Can you also fix all

Re: Review Request 23820: HIVE-7445:Improve LOGS for Hive when a query is not able to acquire locks

2014-07-22 Thread Szehon Ho
On July 22, 2014, 10:33 p.m., Szehon Ho wrote: Hey Chaoyu thanks, the logic looks good now. Can you also fix all the red-space? It's two lines per indent in hive, thanks. Just realized I had a typo, its two spaces per indent. - Szehon

Re: Review Request 23820: HIVE-7445:Improve LOGS for Hive when a query is not able to acquire locks

2014-07-22 Thread Chaoyu Tang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23820/ --- (Updated July 23, 2014, 2:27 a.m.) Review request for hive, Brock Noland,

Re: Review Request 23820: HIVE-7445:Improve LOGS for Hive when a query is not able to acquire locks

2014-07-22 Thread Chaoyu Tang
On July 22, 2014, 10:33 p.m., Szehon Ho wrote: ql/src/java/org/apache/hadoop/hive/ql/lockmgr/zookeeper/ZooKeeperHiveLockManager.java, line 300 https://reviews.apache.org/r/23820/diff/1/?file=639471#file639471line300 Why was this necessary to change? Hey, Szehon, Thanks for the