Re: Review Request 24467: HIVE-7373: Hive should not remove trailing zeros for decimal numbers

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24467/ --- (Updated Aug. 15, 2014, 8:26 p.m.) Review request for hive. Changes ---

Re: Review Request 24467: HIVE-7373: Hive should not remove trailing zeros for decimal numbers

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24467/ --- (Updated Aug. 15, 2014, 6:01 p.m.) Review request for hive. Bugs: HIVE-7373

Re: Review Request 24467: HIVE-7373: Hive should not remove trailing zeros for decimal numbers

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24467/ --- (Updated Aug. 14, 2014, 7:52 p.m.) Review request for hive. Bugs: HIVE-7373

Re: Review Request 24467: HIVE-7373: Hive should not remove trailing zeros for decimal numbers

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24467/ --- (Updated Aug. 14, 2014, 4 p.m.) Review request for hive. Changes --- Fix

Re: Review Request 24467: HIVE-7373: Hive should not remove trailing zeros for decimal numbers

> On Aug. 11, 2014, 9:55 p.m., Brock Noland wrote: > > common/src/java/org/apache/hadoop/hive/common/type/Decimal128.java, line 642 > > > > > > nit: extra line What's wrong with the extra line? - Sergio --

Re: Review Request 24467: HIVE-7373: Hive should not remove trailing zeros for decimal numbers

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24467/ --- (Updated Aug. 12, 2014, 9:42 p.m.) Review request for hive. Changes ---

Re: Review Request 24467: HIVE-7373: Hive should not remove trailing zeros for decimal numbers

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24467/#review50241 --- This looks really great!! Nice work. One comment a single nit below.

Re: Review Request 24467: HIVE-7373: Hive should not remove trailing zeros for decimal numbers

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24467/ --- (Updated Aug. 11, 2014, 9:22 p.m.) Review request for hive. Changes ---

Re: Review Request 24467: HIVE-7373: Hive should not remove trailing zeros for decimal numbers

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24467/ --- (Updated Aug. 11, 2014, 3:23 a.m.) Review request for hive. Changes ---

Review Request 24467: HIVE-7373: Hive should not remove trailing zeros for decimal numbers

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24467/ --- Review request for hive. Bugs: HIVE-7373 https://issues.apache.org/jira/bro