Re: Review Request 24919: HIVE-7815 : Reduce Side Join with single reducer [Spark Branch]

2014-08-21 Thread Brock Noland
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24919/#review51222 --- Hi Szehon! Thank you very much for this patch! It will enable us

Re: Review Request 24919: HIVE-7815 : Reduce Side Join with single reducer [Spark Branch]

2014-08-21 Thread Szehon Ho
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24919/ --- (Updated Aug. 21, 2014, 10:44 p.m.) Review request for hive and Brock Noland.

Re: Review Request 24919: HIVE-7815 : Reduce Side Join with single reducer [Spark Branch]

2014-08-21 Thread Szehon Ho
On Aug. 21, 2014, 9:41 p.m., Brock Noland wrote: ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkPlanGenerator.java, line 217 https://reviews.apache.org/r/24919/diff/1/?file=665833#file665833line217 I know you didn't write this method but can we remove it? For this one,

Re: Review Request 24919: HIVE-7815 : Reduce Side Join with single reducer [Spark Branch]

2014-08-21 Thread Brock Noland
On Aug. 21, 2014, 9:41 p.m., Brock Noland wrote: ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkPlanGenerator.java, line 217 https://reviews.apache.org/r/24919/diff/1/?file=665833#file665833line217 I know you didn't write this method but can we remove it? Szehon Ho

Re: Review Request 24919: HIVE-7815 : Reduce Side Join with single reducer [Spark Branch]

2014-08-21 Thread Brock Noland
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24919/#review51239 --- Ship it! Ship It! - Brock Noland On Aug. 21, 2014, 10:44 p.m.,

Re: Review Request 24919: HIVE-7815 : Reduce Side Join with single reducer [Spark Branch]

2014-08-21 Thread Brock Noland
On Aug. 21, 2014, 9:41 p.m., Brock Noland wrote: ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkPlanGenerator.java, line 217 https://reviews.apache.org/r/24919/diff/1/?file=665833#file665833line217 I know you didn't write this method but can we remove it? Szehon Ho

Re: Review Request 24919: HIVE-7815 : Reduce Side Join with single reducer [Spark Branch]

2014-08-21 Thread Szehon Ho
On Aug. 21, 2014, 9:41 p.m., Brock Noland wrote: ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkPlanGenerator.java, line 217 https://reviews.apache.org/r/24919/diff/1/?file=665833#file665833line217 I know you didn't write this method but can we remove it? Szehon Ho

Review Request 24919: HIVE-7815 : Reduce Side Join with single reducer [Spark Branch]

2014-08-20 Thread Szehon Ho
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24919/ --- Review request for hive and Brock Noland. Bugs: HIVE-7815