Re: Review Request 25320: HIVE-7971: Support alter table change/replace/add columns for existing partitions

2014-09-25 Thread Jason Dere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25320/ --- (Updated Sept. 26, 2014, 1:40 a.m.) Review request for hive and Gunther Hagleit

Re: Review Request 25320: HIVE-7971: Support alter table change/replace/add columns for existing partitions

2014-09-25 Thread Jason Dere
> On Sept. 12, 2014, 6:58 p.m., Gunther Hagleitner wrote: > > ql/src/test/queries/clientpositive/alter_partition_change_col.q, line 7 > > > > > > it'd be good to test: > > > > - dynamic partition case (no value

Re: Review Request 25320: HIVE-7971: Support alter table change/replace/add columns for existing partitions

2014-09-24 Thread Gunther Hagleitner
> On Sept. 12, 2014, 6:58 p.m., Gunther Hagleitner wrote: > > ql/src/test/queries/clientpositive/alter_partition_change_col.q, line 7 > > > > > > it'd be good to test: > > > > - dynamic partition case (no value

Re: Review Request 25320: HIVE-7971: Support alter table change/replace/add columns for existing partitions

2014-09-24 Thread Gunther Hagleitner
> On Sept. 12, 2014, 6:58 p.m., Gunther Hagleitner wrote: > > ql/src/test/queries/clientpositive/alter_partition_change_col.q, line 7 > > > > > > it'd be good to test: > > > > - dynamic partition case (no value

Re: Review Request 25320: HIVE-7971: Support alter table change/replace/add columns for existing partitions

2014-09-15 Thread Jason Dere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25320/ --- (Updated Sept. 15, 2014, 6:21 p.m.) Review request for hive and Gunther Hagleit

Re: Review Request 25320: HIVE-7971: Support alter table change/replace/add columns for existing partitions

2014-09-15 Thread Jason Dere
> On Sept. 12, 2014, 6:58 p.m., Gunther Hagleitner wrote: > > ql/src/test/queries/clientpositive/alter_partition_change_col.q, line 7 > > > > > > it'd be good to test: > > > > - dynamic partition case (no value

Re: Review Request 25320: HIVE-7971: Support alter table change/replace/add columns for existing partitions

2014-09-12 Thread Jason Dere
> On Sept. 12, 2014, 6:58 p.m., Gunther Hagleitner wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java, line 3255 > > > > > > small recommendation: every branch in this seems to have the same > > if/el

Re: Review Request 25320: HIVE-7971: Support alter table change/replace/add columns for existing partitions

2014-09-12 Thread Gunther Hagleitner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25320/#review53197 --- ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java

Review Request 25320: HIVE-7971: Support alter table change/replace/add columns for existing partitions

2014-09-03 Thread Jason Dere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25320/ --- Review request for hive and Ashutosh Chauhan. Bugs: HIVE-7971 https://issue