Re: Review Request 28147: HIVE-7073:Implement Binary in ParquetSerDe

2014-11-27 Thread cheng xu
On Nov. 24, 2014, 6:17 p.m., Brock Noland wrote: LGTM! One comment below. Sorry for my late response. Update the patch by removing unnecessary import statements and simpfying the type convert methods. - cheng --- This is an

Re: Review Request 28147: HIVE-7073:Implement Binary in ParquetSerDe

2014-11-27 Thread cheng xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28147/ --- (Updated Nov. 28, 2014, 2:19 a.m.) Review request for hive. Repository:

Re: Review Request 28147: HIVE-7073:Implement Binary in ParquetSerDe

2014-11-24 Thread Brock Noland
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28147/#review62822 --- LGTM! One comment below.

Re: Review Request 28147: HIVE-7073:Implement Binary in ParquetSerDe

2014-11-23 Thread Mohit Sabharwal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28147/#review62744 --- data/files/parquet_types.txt

Re: Review Request 28147: HIVE-7073:Implement Binary in ParquetSerDe

2014-11-23 Thread cheng xu
On Nov. 23, 2014, 10:59 p.m., Mohit Sabharwal wrote: data/files/parquet_types.txt, lines 1-3 https://reviews.apache.org/r/28147/diff/3/?file=772138#file772138line1 I think this is bit confusing, since the 0b prefix gives the impression that data is read in binary format, whereas

Re: Review Request 28147: HIVE-7073:Implement Binary in ParquetSerDe

2014-11-23 Thread cheng xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28147/ --- (Updated Nov. 24, 2014, 4:16 a.m.) Review request for hive. Changes ---

Re: Review Request 28147: HIVE-7073:Implement Binary in ParquetSerDe

2014-11-23 Thread Mohit Sabharwal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28147/#review62754 --- Ship it! Thanks for the changes! - Mohit Sabharwal On Nov. 24,

Re: Review Request 28147: HIVE-7073:Implement Binary in ParquetSerDe

2014-11-21 Thread cheng xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28147/ --- (Updated Nov. 21, 2014, 8:53 a.m.) Review request for hive. Changes ---

Re: Review Request 28147: HIVE-7073:Implement Binary in ParquetSerDe

2014-11-18 Thread Mohit Sabharwal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28147/#review61946 --- LGTM. Mickaël Lacour's suggestion of adding a null value test is a

Re: Review Request 28147: HIVE-7073:Implement Binary in ParquetSerDe

2014-11-18 Thread cheng xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28147/ --- (Updated Nov. 19, 2014, 2:01 a.m.) Review request for hive. Changes ---

Re: Review Request 28147: HIVE-7073:Implement Binary in ParquetSerDe

2014-11-18 Thread Mohit Sabharwal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28147/#review62133 --- Ship it! Ship It! - Mohit Sabharwal On Nov. 19, 2014, 2:01

Review Request 28147: HIVE-7073:Implement Binary in ParquetSerDe

2014-11-17 Thread cheng xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28147/ --- Review request for hive. Repository: hive-git Description --- This