----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28982/ -----------------------------------------------------------
Review request for hive. Bugs: HIVE-8848 https://issues.apache.org/jira/browse/HIVE-8848 Repository: hive-git Description ------- I am not sure how nulls are supposed to be stored in text tables, but after loading some data with "null" or "NULL" strings, or x00 characters, we get bunch of annoying logging from LazyPrimitive that data is not in INT format and was converted to null, with data being "null" (string saying "null", I assume from the code). Either load should load them as nulls, or there should be some defined way to load nulls. Diffs ----- accumulo-handler/src/java/org/apache/hadoop/hive/accumulo/LazyAccumuloMap.java effdc4b accumulo-handler/src/java/org/apache/hadoop/hive/accumulo/LazyAccumuloRow.java 3dc2d3c accumulo-handler/src/test/org/apache/hadoop/hive/accumulo/serde/FirstCharAccumuloCompositeRowId.java 8c1ec8d data/files/cbo_t1.txt e8034a4 data/files/cbo_t2.txt 34633d3 data/files/cbo_t3.txt a9c995e data/files/cbo_t4.txt 56e0794 data/files/cbo_t5.txt 245b1b9 data/files/cbo_t6.txt dd72edd hbase-handler/src/java/org/apache/hadoop/hive/hbase/LazyHBaseCellMap.java 2727b36 hbase-handler/src/java/org/apache/hadoop/hive/hbase/LazyHBaseRow.java 8a3eac7 hbase-handler/src/test/org/apache/hadoop/hive/hbase/SampleHBaseKeyFactory.java 2d647e2 hbase-handler/src/test/org/apache/hadoop/hive/hbase/SampleHBaseKeyFactory2.java 7086d57 ql/src/test/results/clientpositive/cbo_gby.q.out 7344c11 ql/src/test/results/clientpositive/cbo_join.q.out e4e4e25 ql/src/test/results/clientpositive/cbo_limit.q.out f4385fa ql/src/test/results/clientpositive/cbo_semijoin.q.out b7f6be4 ql/src/test/results/clientpositive/cbo_simple_select.q.out 87b85cf ql/src/test/results/clientpositive/cbo_udf_udaf.q.out ed3a3e7 ql/src/test/results/clientpositive/cbo_union.q.out eb02b03 ql/src/test/results/clientpositive/cbo_views.q.out 10fa8c8 ql/src/test/results/clientpositive/cbo_windowing.q.out a96def8 ql/src/test/results/clientpositive/tez/cbo_gby.q.out 7344c11 ql/src/test/results/clientpositive/tez/cbo_join.q.out e4e4e25 ql/src/test/results/clientpositive/tez/cbo_limit.q.out f4385fa ql/src/test/results/clientpositive/tez/cbo_semijoin.q.out b7f6be4 ql/src/test/results/clientpositive/tez/cbo_simple_select.q.out 87b85cf ql/src/test/results/clientpositive/tez/cbo_udf_udaf.q.out ed3a3e7 ql/src/test/results/clientpositive/tez/cbo_union.q.out eb02b03 ql/src/test/results/clientpositive/tez/cbo_views.q.out 10fa8c8 ql/src/test/results/clientpositive/tez/cbo_windowing.q.out a96def8 serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroLazyObjectInspector.java a6e8c2c serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyArray.java ce0cfb3 serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyBinary.java c25a1b8 serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyMap.java e6932d9 serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyNonPrimitive.java e4cffc9 serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyObject.java 9b5ccbe serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyObjectBase.java 7e42b3f serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyPrimitive.java 7d23c46 serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyString.java 75b9556 serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyStruct.java 588cc8c serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyUnion.java 22fc638 serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinaryObject.java b3625b3 Diff: https://reviews.apache.org/r/28982/diff/ Testing ------- Thanks, Navis Ryu