----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29374/ -----------------------------------------------------------
Review request for hive. Repository: hive-git Description ------- In DummyTxnManager, the lockMode for a WriteEntity (e.g. database, table) is determined by "complete" instead of its writeType. But since DDL output WriteEntity is usually complete, some DDL operations might be given exclusive locks which are actually not needed, which causes unnecessary locking contention. For example, in createTable, DummyTxnManager suggests an exclusive lock to table database writeentity since it is complete. The patch is to change DummayTxnManager to determine the lockMode for DDL based on output writetype, while still using "complete" for DML operations. Diffs ----- ql/src/java/org/apache/hadoop/hive/ql/lockmgr/DummyTxnManager.java fdf667611cdb68fff0486c9b4287e0c0668ebd06 Diff: https://reviews.apache.org/r/29374/diff/ Testing ------- Manually tested in local machine Thanks, Chaoyu Tang
